[Bug c/58409] New: wrong reordering of volatile writes

[Bug c/58409] New: wrong reordering of volatile writes

[francesco.zappa.nardelli at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58409

            Bug ID: 58409
           Summary: wrong reordering of volatile writes
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: francesco.zappa.nardelli at gmail dot com

In the program below, at least according to the C11 standard, there is a
sequence point between the volatile store to g_3[0][0][0] and the volatile
store to *g_6 (that is, to the volatile int g_5).  As a consequence, the store
to g_3 should be performed before the store to g_5.

struct {
  volatile int f1;
} g_1, *g_2 = &g_1, g_3[1][1][1], **g_4 = &g_2;

volatile int g_5;

static volatile int *g_6 = &g_5;

int func_2 () {
  g_3[0][0][0] = **g_4;
  return 0;
}

int func_1 () {
  *g_6 = func_2 ();
  return 0;
}

void main () {
  func_1 ();
}

If the program is compiled with a recent svn trunk 

$ gcc -v
Target: x86_64-unknown-linux-gnu
Configured with: ../gcc-svn/configure --disable-bootstrap
--enable-languages=c,c++ 
Thread model: posix
gcc version 4.9.0 20130912 (experimental) (GCC) 

at optimisation level -O2 or -O3 then the generated assembler swaps the store
to g_5 with the store to g_3:

main:
        movq    g_4(%rip), %rax
        movq    (%rax), %rax
        movl    (%rax), %eax
        movl    $0, g_5(%rip)
        movl    %eax, g_3(%rip)
        ret

As far as I can tell, this reordering should be considered as a compiler bug. 
The same happens with gcc 4.8.1.

[Bug c/58409] wrong reordering of volatile writes

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58409

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Does:
  g_3[0][0][0].f1 = (**g_4).f1;

Fix the issue if so it is a dup of bug 47409 really.

[Bug c/58409] wrong reordering of volatile writes

[francesco.zappa.nardelli at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58409

--- Comment #2 from Francesco Zappa Nardelli <francesco.zappa.nardelli at gmail dot com> ---
Yes, it does fix the issue.  

So this reordering is another effect of gcc not considering accessing volatile
fields in non-volatile structs as volatile access (as in bug 47409).  Can I ask
about gcc plans for bug 47409?  It has been opened for a couple of years
without a clear decision at the end.

[Bug c/58409] wrong reordering of volatile writes

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58409

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Dup.

*** This bug has been marked as a duplicate of bug 47409 ***