[Bug sanitizer/58420] New: internal compiler error: in ubsan_type_descriptor, at ubsan.c:280

[Bug sanitizer/58420] New: internal compiler error: in ubsan_type_descriptor, at ubsan.c:280

[jan.smets@alcatel-lucent.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58420

            Bug ID: 58420
           Summary: internal compiler error: in ubsan_type_descriptor, at
                    ubsan.c:280
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jan.smets@alcatel-lucent.com
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org

stl.46/bits/locale_facets.h:1585:46: internal compiler error: in
ubsan_type_descriptor, at ubsan.c:280

Line 1585 is '_CharT  _M_atoms_out[__num_base::_S_oend];'


  template<typename _CharT>
    struct __numpunct_cache : public locale::facet
    {
      const char*                       _M_grouping;
      size_t                            _M_grouping_size;
      bool                              _M_use_grouping;
      const _CharT*                     _M_truename;
      size_t                            _M_truename_size;
      const _CharT*                     _M_falsename;
      size_t                            _M_falsename_size;
      _CharT                            _M_decimal_point;
      _CharT                            _M_thousands_sep;

      // A list of valid numeric literals for output: in the standard
      // "C" locale, this is "-+xX0123456789abcdef0123456789ABCDEF".
      // This array contains the chars after having been passed
      // through the current locale's ctype<_CharT>.widen().
      _CharT                            _M_atoms_out[__num_base::_S_oend];

      // A list of valid numeric literals for input: in the standard
      // "C" locale, this is "-+xX0123456789abcdefABCDEF"
      // This array contains the chars after having been passed
      // through the current locale's ctype<_CharT>.widen().
      _CharT                            _M_atoms_in[__num_base::_S_iend];

      bool                              _M_allocated;

      __numpunct_cache(size_t __refs = 0)
      : facet(__refs), _M_grouping(0), _M_grouping_size(0),
        _M_use_grouping(false),
        _M_truename(0), _M_truename_size(0), _M_falsename(0),
        _M_falsename_size(0), _M_decimal_point(_CharT()),
        _M_thousands_sep(_CharT()), _M_allocated(false)
        { }

      ~__numpunct_cache();

      void
      _M_cache(const locale& __loc);

    private:
      __numpunct_cache&
      operator=(const __numpunct_cache&);

      explicit
      __numpunct_cache(const __numpunct_cache&);
    };

[Bug sanitizer/58420] internal compiler error: in ubsan_type_descriptor, at ubsan.c:280

[jan.smets@alcatel-lucent.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58420

--- Comment #1 from Jan Smets <jan.smets@alcatel-lucent.com> ---
This may be because of the (not yet committed) patch for ubsan vla bounds
checking.  

http://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg61427.html

Probably another one for Marek Polacek.
- Jan

[Bug sanitizer/58420] internal compiler error: in ubsan_type_descriptor, at ubsan.c:280

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58420

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-09-14
                 CC|                            |mpolacek at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |mpolacek at gcc dot gnu.org
   Target Milestone|---                         |4.9.0
     Ever confirmed|0                           |1

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Mine.  Thanks for testing ubsan!

[Bug sanitizer/58420] internal compiler error: in ubsan_type_descriptor, at ubsan.c:280

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58420

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Though, could you provide some preprocessed testcase?  At any rate, I think
it's because ubsan_type_descriptor doesn't handle IDENTIFIER_NODEs very well,
this should be fixed as a side effect of
http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00917.html patch once it gets
applied.

[Bug sanitizer/58420] internal compiler error: in ubsan_type_descriptor, at ubsan.c:280

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58420

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug sanitizer/58420] internal compiler error: in ubsan_type_descriptor, at ubsan.c:280

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58420

--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
The ubsan vla-bound patch contains a thinko, it should be fixed by this patch
(forgot to check for TYPE_NAME != NULL):
http://gcc.gnu.org/ml/gcc-patches/2013-09/msg01209.html

[Bug sanitizer/58420] internal compiler error: in ubsan_type_descriptor, at ubsan.c:280

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58420

--- Comment #5 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Wed Sep 25 09:04:20 2013
New Revision: 202887

URL: http://gcc.gnu.org/viewcvs?rev=202887&root=gcc&view=rev
Log:
    PR sanitizer/58420
    * ubsan.c (ubsan_type_descriptor): Handle IDENTIFIER_NODEs
    when determining the type name.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ubsan.c

[Bug sanitizer/58420] internal compiler error: in ubsan_type_descriptor, at ubsan.c:280

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58420

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Should be fixed.