public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/58477] [4.9 Regression] ice in cgraph_speculative_call_info Date: Fri, 06 Dec 2013 15:27:00 -0000 [thread overview] Message-ID: <bug-58477-4-lVZHBJn8IZ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-58477-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58477 --- Comment #5 from Jan Hubicka <hubicka at gcc dot gnu.org> --- I am testing Index: ../gcc/cgraphclones.c =================================================================== --- ../gcc/cgraphclones.c (revision 205737) +++ ../gcc/cgraphclones.c (working copy) @@ -123,7 +123,10 @@ cgraph_clone_edge (struct cgraph_edge *e { tree decl; - if (call_stmt && (decl = gimple_call_fndecl (call_stmt))) + if (call_stmt && (decl = gimple_call_fndecl (call_stmt)) + /* When the call is speculative, we need to resolve it + via cgraph_resolve_speculation and not here. */ + && !e->speculative) { struct cgraph_node *callee = cgraph_get_node (decl); gcc_checking_assert (callee); The problem is that cgraph_clone_edge is too eager to turn the edge into a direct edge because inliner managed to do the same resolution. This fixes the ICE but we however ought to do this optimization at IPA level.
next prev parent reply other threads:[~2013-12-06 15:27 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-09-19 17:59 [Bug c++/58477] New: " dcb314 at hotmail dot com 2013-09-19 18:19 ` [Bug c++/58477] " markus at trippelsdorf dot de 2013-09-19 18:31 ` paolo.carlini at oracle dot com 2013-09-19 19:00 ` hubicka at gcc dot gnu.org 2013-09-20 7:45 ` [Bug c++/58477] [4.9 Regression] " rguenth at gcc dot gnu.org 2013-10-17 9:44 ` dcb314 at hotmail dot com 2013-10-30 13:43 ` rguenth at gcc dot gnu.org 2013-12-06 15:27 ` hubicka at gcc dot gnu.org [this message] 2013-12-14 18:28 ` hubicka at gcc dot gnu.org 2013-12-14 22:08 ` hubicka at gcc dot gnu.org 2013-12-15 11:33 ` hubicka at gcc dot gnu.org 2014-03-02 20:52 ` hubicka at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-58477-4-lVZHBJn8IZ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).