[Bug tree-optimization/58492] New: ICE: verify_flow_info failed

[Bug tree-optimization/58492] New: ICE: verify_flow_info failed

[antoine.balestrat at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58492

            Bug ID: 58492
           Summary: ICE: verify_flow_info failed
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: antoine.balestrat at gmail dot com

Hello ! The following testcase makes GCC 4.9.0 as of 20130921 crash.

$ cat vfi.c
void f(int p, short q)
{
   f(0, 0);
}

$ xgcc -O3 -fipa-pta vfi.c
vfi.c: In function ‘f’:
vfi.c:1:6: error: control flow in the middle of basic block 2
 void f(int p, short q)
      ^
vfi.c:1:6: internal compiler error: verify_flow_info failed
0x617352 verify_flow_info()
        ../../srcdir/gcc/cfghooks.c:260
0x958d3a cleanup_tree_cfg_noloop
        ../../srcdir/gcc/tree-cfgcleanup.c:696
0x958d3a cleanup_tree_cfg()
        ../../srcdir/gcc/tree-cfgcleanup.c:745
0x87f724 execute_function_todo
        ../../srcdir/gcc/passes.c:1791
0x87fe17 execute_todo
        ../../srcdir/gcc/passes.c:1866
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
>From gcc-bugs-return-430346-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Sep 21 14:50:14 2013
Return-Path: <gcc-bugs-return-430346-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 29547 invoked by alias); 21 Sep 2013 14:50:14 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 29513 invoked by uid 48); 21 Sep 2013 14:50:11 -0000
From: "danglin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libfortran/58015] FAIL: gfortran.dg/round_4.f90: Unsatisfied symbol "nextafterl"
Date: Sat, 21 Sep 2013 14:50:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libfortran
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: danglin at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-58015-4-C2ACKUOLxq@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58015-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58015-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-09/txt/msg01586.txt.bz2
Content-length: 1175

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX015

--- Comment #1 from John David Anglin <danglin at gcc dot gnu.org> ---
Causes following fails:
FAIL: gfortran.dg/round_4.f90  -O0  (test for excess errors)
FAIL: gfortran.dg/round_4.f90  -O0  execution test
FAIL: gfortran.dg/round_4.f90  -O1  (test for excess errors)
FAIL: gfortran.dg/round_4.f90  -O1  execution test
FAIL: gfortran.dg/round_4.f90  -O2  (test for excess errors)
FAIL: gfortran.dg/round_4.f90  -O2  execution test
FAIL: gfortran.dg/round_4.f90  -O3 -fomit-frame-pointer  (test for excess
errors
)
FAIL: gfortran.dg/round_4.f90  -O3 -fomit-frame-pointer  execution test
FAIL: gfortran.dg/round_4.f90  -O3 -fomit-frame-pointer -funroll-loops  (test
fo
r excess errors)
FAIL: gfortran.dg/round_4.f90  -O3 -fomit-frame-pointer -funroll-loops
executio
n test
FAIL: gfortran.dg/round_4.f90  -O3 -fomit-frame-pointer -funroll-all-loops
-finl
ine-functions  (test for excess errors)
FAIL: gfortran.dg/round_4.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/round_4.f90  -O3 -g  execution test
FAIL: gfortran.dg/round_4.f90  -Os  (test for excess errors)
FAIL: gfortran.dg/round_4.f90  -Os  execution test

[Bug tree-optimization/58492] [4.9 Regression] ICE: verify_flow_info failed

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58492

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-09-23
                 CC|                            |hubicka at gcc dot gnu.org
   Target Milestone|---                         |4.9.0
            Summary|ICE: verify_flow_info       |[4.9 Regression] ICE:
                   |failed                      |verify_flow_info failed
     Ever confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Results in

<bb2>
f.constprop ();
return;

and f.constprop is stmt_ends_bb_p () now, the original recursion isn't.
That's because it's likely got an endless loop and noreturn?

calling out IPA-PTA is probably bogus.

f is found const by IPA pure const (but f.constprop isn't updated via
clone hook?) and ends up const looping.  IPA-PTA doesn't do anything
and copyprop simply first triggers verification.

[Bug ipa/58492] [4.9 Regression] ICE: verify_flow_info failed

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58492

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
With -fipa-pta at t.c.054t.copyrename2 we have

f.constprop ()
{
  <bb 2>:
  f.constprop ();
  return;

}

f (int p, short int q)
{
  <bb 2>:
  f.constprop ();
  return;

}

but without -fipa-pta we get

f (int p, short int q)
{
  <bb 2>:
  f.constprop ();

}

appearantly

  /* SIPLE IPA passes do not handle callgraphs with IPA transforms in it.
     Apply all trnasforms first.  */
  if (pass->type == SIMPLE_IPA_PASS)
    {
      bool applied = false;
      do_per_function (apply_ipa_transforms, (void *)&applied);
      if (applied)
        symtab_remove_unreachable_nodes (true, dump_file);
      /* Restore current_pass.  */
      current_pass = pass;
    }

breaks things because we instantiate the clone before executing late
local-pure-const for f.constprop () this way and thus miss the state
change in the caller and the fixup-cfg required by it.  In 4.8 we had
as first pass in all_passes a pass_fixup_cfg but appearantly I removed
that(?) ...

Mine.

[Bug ipa/58492] [4.9 Regression] ICE: verify_flow_info failed

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58492

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug ipa/58492] [4.9 Regression] ICE: verify_flow_info failed

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58492

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Tue Nov  5 15:09:40 2013
New Revision: 204399

URL: http://gcc.gnu.org/viewcvs?rev=204399&root=gcc&view=rev
Log:
2013-11-05  Richard Biener  <rguenther@suse.de>

    PR ipa/58492
    * passes.def (all_passes): Start with pass_fixup_cfg again.

    * gcc.dg/ipa/pr58492.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.dg/ipa/pr58492.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/passes.def
    trunk/gcc/testsuite/ChangeLog