[Bug target/58507] New: Incorrect parsing of `-mmcu=msp430*`

[Bug target/58507] New: Incorrect parsing of `-mmcu=msp430*`

[errordeveloper at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58507

            Bug ID: 58507
           Summary: Incorrect parsing of `-mmcu=msp430*`
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: errordeveloper at gmail dot com
                CC: dj at redhat dot com, nickc at redhat dot com

% cat test.c
#include <msp430fr5739.h>

int main() { return 0; };

% msp430-elf-gcc -mmcu=msp430fr5739 test.c
-I/home/ilya/msp430/msp430-elf-21092013-0/msp430-elf/include/msp430
/home/ilya/msp430/msp430-elf-21092013-0/bin/../lib/gcc/msp430-elf/4.9.0/../../../../msp430-elf/bin/ld:
error: /tmp/cc5edjEZ.o uses MSP430X instructions but
/home/ilya/msp430/msp430-elf-21092013-0/bin/../lib/gcc/msp430-elf/4.9.0/../../../../msp430-elf/lib/crt0.o
uses MSP430
/home/ilya/msp430/msp430-elf-21092013-0/bin/../lib/gcc/msp430-elf/4.9.0/../../../../msp430-elf/bin/ld:
failed to merge target specific data of file /tmp/cc5edjEZ.o
collect2: error: ld returned 1 exit status


Checking this reviles a dull parameter parsing bug:

% msp430-elf-gcc -mmcu=msp430 test.c
-I/home/ilya/msp430/msp430-elf-21092013-0/msp430-elf/include/msp430 -c
% msp430-elf-objdump -x test.o | grep -i arch
architecture: msp:11, flags 0x00000010:

% msp430-elf-gcc -mmcu=msp430x test.c
-I/home/ilya/msp430/msp430-elf-21092013-0/msp430-elf/include/msp430 -c
% msp430-elf-objdump -x test.o | grep -i arch
architecture: msp:430X, flags 0x00000010:

% msp430-elf-gcc -mmcu=msp430fr5739 test.c
-I/home/ilya/msp430/msp430-elf-21092013-0/msp430-elf/include/msp430 -c
% msp430-elf-objdump -x test.o | grep -i arch
architecture: msp:430X, flags 0x00000010:

Here are the revision ID's for your reference:

gcc 25bd6b06e5c81ff8c97d6671651442305a2cbbb2
newlib 090b27c6ed560767408293f185aa313eeef23d74
binutils e1926926db9154828b02a83c3d094ba6c39247e0
gdb 7.6.50.20130921
msp430mcu d5dd733e674dfd80781669a98ef85fd57526ce47
mspdebug 0.22

The compilation was done according to:
http://sourceforge.net/apps/mediawiki/mspgcc/index.php?title=Install:redhat

A x86 binary can be found here:
https://s3.amazonaws.com/com.xively.packages/msp430-elf-21092013-0.txz

[Bug target/58507] Incorrect parsing of `-mmcu=msp430*`

[nickc at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58507

--- Comment #1 from Nick Clifton <nickc at redhat dot com> ---
Created attachment 30910
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30910&action=edit
Fix objdump output

Proposed patch to fix objdump output

[Bug target/58507] Incorrect parsing of `-mmcu=msp430*`

[nickc at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58507

--- Comment #2 from Nick Clifton <nickc at redhat dot com> ---
Created attachment 30916
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30916&action=edit
Add parsing of known MSP430 MCU types

I am currently testing this patch to see if it introduces any regressions into
the gcc testsuite...

[Bug target/58507] Incorrect parsing of `-mmcu=msp430*`

[nickc at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58507

--- Comment #3 from Nick Clifton <nickc at redhat dot com> ---
Hi Ilya,

  I have now checked my patches in.  If you use the latest (development) FSF
sources for GCC and the binutils you should see that correct parsing of the
-mmcu command line option and the correct display of the MSP430 architecture
variant.

Cheers
  Nick

[Bug target/58507] Incorrect parsing of `-mmcu=msp430*`

[jozefl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58507

jozefl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jozefl at gcc dot gnu.org
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from jozefl at gcc dot gnu.org ---
Fixed.