From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 523AD3858D32; Sat,  3 Jun 2023 09:02:35 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 523AD3858D32
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1685782955;
	bh=ubbV9UVvNWAajC67/KxsqcMh7zp11N9Dk166RGwWQl4=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=UQxAbCmoFB+qM5/c5/HxEpxZ/Tk+WRQcVob1wYZrWvitgME+B3KuAm/5Zd0Bd2fNy
	 7FBR3YDXEOTc+APzZx3wEiKuXkfGk4yfrPa6dgXbOXVB/mq6j2spRjjbFjilR1kqT6
	 Sa0/aC5HnheyvJc0f3s7MzvHdEC6X+X7bq0oYMLA=
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/58517] ifcvt (after combine) puts ccreg
 clobbering insn between ccset insn and ccreg use
Date: Sat, 03 Jun 2023 09:02:33 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pinskia at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-58517-4-5lpgl8BZYj@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58517-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58517-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D58517

--- Comment #14 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Oleg Endo from comment #13)
> (In reply to Andrew Pinski from comment #12)
> > Created attachment 55239 [details]
> > Patch which does work on this
> >=20
> > Though, I need to double to make sure it works for other cases still.
> > sh is the case where we have a non-CC mode register for the flags which=
 is
> > why this was harder than other targets.
>=20
> Thanks for looking at this (after 10 years .. wow, time flies).
>=20
>=20
> > diff --git a/gcc/config/sh/sh.md b/gcc/config/sh/sh.md
> > index 4622dba0121..ae1a0f7eb7c 100644
> > --- a/gcc/config/sh/sh.md
> > +++ b/gcc/config/sh/sh.md
> > @@ -1510,7 +1510,7 @@ (define_expand "movsicc"
> >    rtx op0 =3D XEXP (operands[1], 0);
> >    rtx op1 =3D XEXP (operands[1], 1);
> >
> > -  if (! currently_expanding_to_rtl)
> > +  if (0 && ! currently_expanding_to_rtl)
> >      FAIL;
> >
> >   switch (code)
> > diff --git a/gcc/config/sh/t-sh b/gcc/config/sh/t-sh
> > index 1cc8c39d2a8..8ffcc288cf3 100644
> > --- a/gcc/config/sh/t-sh
> > +++ b/gcc/config/sh/t-sh
> > @@ -89,8 +89,8 @@ MULTILIB_OSDIRNAMES =3D \
> >  	m4a=3D!m4a $(OTHER_ENDIAN)/m4a=3D!$(OTHER_ENDIAN)/m4a \
> >  	m4al=3D!m4al $(OTHER_ENDIAN)/m4al=3D!$(OTHER_ENDIAN)/m4al
> >=20=20
> > -$(out_object_file): gt-sh.h
> > -gt-sh.h : s-gtype ; @true
> > +#$(out_object_file): gt-sh.h
> > +#gt-sh.h : s-gtype ; @true
> >=20=20
> >  # Local Variables:
> >  # mode: Makefile
>=20
> Are these hunks intentional?

No. The second one was me trying to figure out why if I did make clean, the
build would then fail, I thought it wad related to that but it was a m2 (the
language) vs having a multilib dir named m2.=