public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/58574] [4.8/4.9 Regression] Wrong code due to s390x machine reorg pass
Date: Mon, 30 Sep 2013 11:02:00 -0000	[thread overview]
Message-ID: <bug-58574-4-OHWGCVhdex@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-58574-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58574

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I'd say the bug is in s390_chunkify_start:
          if (GET_CODE (pat) == PARALLEL && XVECLEN (pat, 0) > 2)
            pat = XVECEXP (pat, 0, 0);
Dunno what exactly the > 2 condition has been added for, JUMP_INSNs with
PARALLEL with XVECLEN (pat, 0) == 2 are:
1) casesi_jump
2) *cmp_and_br_signed_<mode>, *cmp_and_br_unsigned_<mode>,
*icmp_and_br_signed_<mode>, *icmp_and_br_unsigned_<mode>
3) *ccraw_to_int
I can understand why you wouldn't want to handle 1) in there, and supposedly
3) should be split before machine reorg or worst case at the start of it.  But
2), this case, it looks wrong not to do anything here.

Note that similar condition is in s390_split_branches, no idea what do you want
to do there.  But perhaps TARGET_Z10 implies TARGET_ZARCH and thus
s390_split_branches would be never called.


  parent reply	other threads:[~2013-09-30 11:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-58574-4@http.gcc.gnu.org/bugzilla/>
2013-09-29 19:15 ` jakub at gcc dot gnu.org
2013-09-29 20:18 ` mpolacek at gcc dot gnu.org
2013-09-30 11:02 ` jakub at gcc dot gnu.org [this message]
2013-09-30 11:15 ` jakub at gcc dot gnu.org
2013-09-30 11:17 ` jakub at gcc dot gnu.org
2013-09-30 11:58 ` krebbel at gcc dot gnu.org
2013-09-30 12:00 ` krebbel at gcc dot gnu.org
2013-09-30 13:11 ` krebbel at gcc dot gnu.org
2013-09-30 13:17 ` jakub at gcc dot gnu.org
2013-09-30 13:33 ` jakub at gcc dot gnu.org
2013-10-01  6:58 ` jakub at gcc dot gnu.org
2013-10-01 12:28 ` krebbel at gcc dot gnu.org
2013-10-01 12:38 ` jakub at gcc dot gnu.org
2013-10-01 13:33 ` krebbel at gcc dot gnu.org
2013-10-01 13:46 ` krebbel at gcc dot gnu.org
2013-10-01 13:50 ` jakub at gcc dot gnu.org
2013-10-01 14:00 ` [Bug target/58574] [4.7 " jakub at gcc dot gnu.org
2014-06-12 13:30 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-58574-4-OHWGCVhdex@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).