* [Bug fortran/58593] [4.9 Regression] internal compiler error: in gfc_conv_string_tmp, at fortran/trans-expr.c:2360
[not found] <bug-58593-4@http.gcc.gnu.org/bugzilla/>
@ 2013-10-02 7:58 ` burnus at gcc dot gnu.org
2013-10-02 8:03 ` burnus at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 5+ messages in thread
From: burnus at gcc dot gnu.org @ 2013-10-02 7:58 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58593
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |burnus at gcc dot gnu.org
Ever confirmed|0 |1
--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Confirmed. - Sorry for the breakage and thanks for the report!
I wonder why this didn't trigger in the test suite. (Glancing a the code, I
don't see why it fails. But I'll find out!)
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug fortran/58593] [4.9 Regression] internal compiler error: in gfc_conv_string_tmp, at fortran/trans-expr.c:2360
[not found] <bug-58593-4@http.gcc.gnu.org/bugzilla/>
2013-10-02 7:58 ` [Bug fortran/58593] [4.9 Regression] internal compiler error: in gfc_conv_string_tmp, at fortran/trans-expr.c:2360 burnus at gcc dot gnu.org
@ 2013-10-02 8:03 ` burnus at gcc dot gnu.org
2013-10-02 9:09 ` Joost.VandeVondele at mat dot ethz.ch
` (2 subsequent siblings)
4 siblings, 0 replies; 5+ messages in thread
From: burnus at gcc dot gnu.org @ 2013-10-02 8:03 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58593
--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Tobias Burnus from comment #1)
> Glancing a the code, I don't see why it fails.
Shot into the dark:
--- a/gcc/fortran/trans-expr.c
+++ b/gcc/fortran/trans-expr.c
@@ -2359,4 +2359,4 @@ gfc_conv_string_tmp (gfc_se * se, tree type, tree len)
tmp = TREE_TYPE (type);
- gcc_assert (TREE_CODE (tmp) == ARRAY_TYPE);
- tmp = TYPE_SIZE_UNIT (TREE_TYPE (tmp));
+ if (TREE_CODE (tmp) == ARRAY_TYPE)
+ tmp = TYPE_SIZE_UNIT (TREE_TYPE (tmp));
tmp = fold_build2_loc (input_location, MULT_EXPR, size_type_node,
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug fortran/58593] [4.9 Regression] internal compiler error: in gfc_conv_string_tmp, at fortran/trans-expr.c:2360
[not found] <bug-58593-4@http.gcc.gnu.org/bugzilla/>
2013-10-02 7:58 ` [Bug fortran/58593] [4.9 Regression] internal compiler error: in gfc_conv_string_tmp, at fortran/trans-expr.c:2360 burnus at gcc dot gnu.org
2013-10-02 8:03 ` burnus at gcc dot gnu.org
@ 2013-10-02 9:09 ` Joost.VandeVondele at mat dot ethz.ch
2013-10-02 21:02 ` burnus at gcc dot gnu.org
2013-10-02 21:04 ` burnus at gcc dot gnu.org
4 siblings, 0 replies; 5+ messages in thread
From: Joost.VandeVondele at mat dot ethz.ch @ 2013-10-02 9:09 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58593
--- Comment #3 from Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> ---
(In reply to Tobias Burnus from comment #1)
> Confirmed. - Sorry for the breakage and thanks for the report!
Not sure how the saying goes exactly, but 'those that do a lot can break a
lot'. I'm happy my bug reports are useful, and in exchange I get a high quality
compiler.
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug fortran/58593] [4.9 Regression] internal compiler error: in gfc_conv_string_tmp, at fortran/trans-expr.c:2360
[not found] <bug-58593-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2013-10-02 9:09 ` Joost.VandeVondele at mat dot ethz.ch
@ 2013-10-02 21:02 ` burnus at gcc dot gnu.org
2013-10-02 21:04 ` burnus at gcc dot gnu.org
4 siblings, 0 replies; 5+ messages in thread
From: burnus at gcc dot gnu.org @ 2013-10-02 21:02 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58593
--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Author: burnus
Date: Wed Oct 2 21:02:14 2013
New Revision: 203135
URL: http://gcc.gnu.org/viewcvs?rev=203135&root=gcc&view=rev
Log:
2013-10-02 Tobias Burnus <burnus@net-b.de>
PR fortran/58593
* trans-expr.c (gfc_conv_string_tmp): Fix obtaining
the byte size of a single character.
2013-10-02 Tobias Burnus <burnus@net-b.de>
PR fortran/58593
* gfortran.dg/char_length_19.f90: New.
Added:
trunk/gcc/testsuite/gfortran.dg/char_length_19.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/trans-expr.c
trunk/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug fortran/58593] [4.9 Regression] internal compiler error: in gfc_conv_string_tmp, at fortran/trans-expr.c:2360
[not found] <bug-58593-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2013-10-02 21:02 ` burnus at gcc dot gnu.org
@ 2013-10-02 21:04 ` burnus at gcc dot gnu.org
4 siblings, 0 replies; 5+ messages in thread
From: burnus at gcc dot gnu.org @ 2013-10-02 21:04 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58593
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Tobias Burnus <burnus at gcc dot gnu.org> ---
FIXED on the trunk (4.9) - which was only affected. (The patch is slightly
different from the one in comment 2, which doesn't work.)
^ permalink raw reply [flat|nested] 5+ messages in thread