[Bug c++/58703] [4.9 Regression] ICE with invalid types in OpenMP declare reduction clause

[Bug c++/58703] [4.9 Regression] ICE with invalid types in OpenMP declare reduction clause

[reichelt at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58703

Volker Reichelt <reichelt at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |error-recovery,
                   |                            |ice-on-invalid-code
   Target Milestone|---                         |4.9.0
      Known to fail|                            |4.9.0

[Bug c++/58703] New: [4.9 Regression] ICE with invalid types in OpenMP declare reduction clause

[reichelt at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58703

            Bug ID: 58703
           Summary: [4.9 Regression] ICE with invalid types in OpenMP
                    declare reduction clause
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: reichelt at gcc dot gnu.org

The following invalid code snippet (compiled with "-fopenmp") triggers an ICE
on trunk:

====================================================================
#pragma omp declare reduction (+ : char[] : omp_out += omp_in)
#pragma omp declare reduction (+ : char() : omp_out += omp_in)
====================================================================

bug.cc:1:36: error: function or array type 'char []' in '#pragma omp declare
reduction'
 #pragma omp declare reduction (+ : char[] : omp_out += omp_in)
                                    ^
bug.cc:2:36: error: function or array type 'char()' in '#pragma omp declare
reduction'
 #pragma omp declare reduction (+ : char() : omp_out += omp_in)
                                    ^
bug.cc:2:63: internal compiler error: in cp_parser_translation_unit, at
cp/parser.c:4019
 #pragma omp declare reduction (+ : char() : omp_out += omp_in)
                                                               ^
0x66b3b0 cp_parser_translation_unit
        ../../gcc/gcc/cp/parser.c:4018
0x66b3b0 c_parse_file()
        ../../gcc/gcc/cp/parser.c:30962
0x787f73 c_common_parse_file()
        ../../gcc/gcc/c-family/c-opts.c:1046
Please submit a full bug report, [etc.]

[Bug c++/58703] [4.9 Regression] ICE with invalid types in OpenMP declare reduction clause

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58703

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5

[Bug c++/58703] [4.9 Regression] ICE with invalid types in OpenMP declare reduction clause

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58703

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-02-03
     Ever confirmed|0                           |1

[Bug c++/58703] [4.9 Regression] ICE with invalid types in OpenMP declare reduction clause

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58703

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 32028
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32028&action=edit
gcc49-pr58703.patch

Untested fix.

[Bug c++/58703] [4.9 Regression] ICE with invalid types in OpenMP declare reduction clause

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58703

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Wed Feb  5 15:32:01 2014
New Revision: 207511

URL: http://gcc.gnu.org/viewcvs?rev=207511&root=gcc&view=rev
Log:
    PR c++/58703
    * parser.c (cp_parser_omp_declare_reduction): Save and free
    declarator_obstack.

    * c-c++-common/gomp/pr58703.c: New test.

Added:
    trunk/gcc/testsuite/c-c++-common/gomp/pr58703.c
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/parser.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/58703] [4.9 Regression] ICE with invalid types in OpenMP declare reduction clause

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58703

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.