public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/58721] [4.9 Regression] The subroutine perdida is no longer inlined in fatigue.f90
Date: Fri, 06 Dec 2013 16:25:00 -0000	[thread overview]
Message-ID: <bug-58721-4-OpJxihZmzT@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-58721-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721

--- Comment #10 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
OK,
seems that the problem is with Fortran generating internally __builtin_expect
to control various construct.  I would make a lot more sense to use
GIMPLE_PREDICT for those cases. With GIMPLE_PREDICT one can have more fine
grained control over
the hint and handle it as separate predicter.

I wonder if some Fortran maintainer can look into this and update the lowering?
c/c-typeck.c:    add_stmt (build_predict_expr (PRED_CONTINUE, NOT_TAKEN));
cp/cp-gimplify.c:  tree pred = build_predict_expr (PRED_CONTINUE, NOT_TAKEN);

are examples how these are used.  Unlike builtin_expect you do not add it into
the expression, but you drop it on the unlikely code path.

Honza


  parent reply	other threads:[~2013-12-06 16:25 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-14  8:22 [Bug tree-optimization/58721] New: " dominiq at lps dot ens.fr
2013-10-14  8:59 ` [Bug ipa/58721] " rguenth at gcc dot gnu.org
2013-11-05 15:02 ` rguenth at gcc dot gnu.org
2013-11-28 14:01 ` ysrumyan at gmail dot com
2013-11-28 19:19 ` hjl.tools at gmail dot com
2013-11-28 23:04 ` dominiq at lps dot ens.fr
2013-12-02 12:12 ` ysrumyan at gmail dot com
2013-12-02 12:13 ` ysrumyan at gmail dot com
2013-12-03 15:02 ` dominiq at lps dot ens.fr
2013-12-03 15:55 ` ysrumyan at gmail dot com
2013-12-06  9:54 ` dominiq at lps dot ens.fr
2013-12-06 15:19 ` hubicka at gcc dot gnu.org
2013-12-06 16:25 ` hubicka at gcc dot gnu.org [this message]
2013-12-06 18:20 ` hubicka at gcc dot gnu.org
2013-12-06 19:18 ` dominiq at lps dot ens.fr
2013-12-08 11:44 ` Joost.VandeVondele at mat dot ethz.ch
2013-12-10  9:20 ` hubicka at ucw dot cz
2013-12-10  9:23 ` hubicka at ucw dot cz
2013-12-10 22:30 ` burnus at gcc dot gnu.org
2013-12-26 15:51 ` hubicka at gcc dot gnu.org
2014-03-02  6:24 ` burnus at gcc dot gnu.org
2014-03-14 14:53 ` jakub at gcc dot gnu.org
2014-03-14 17:27 ` jakub at gcc dot gnu.org
2014-03-14 18:11 ` redi at gcc dot gnu.org
2014-03-14 18:12 ` redi at gcc dot gnu.org
2014-03-18 11:31 ` jakub at gcc dot gnu.org
2014-03-18 11:39 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-58721-4-OpJxihZmzT@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).