public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "paolo.carlini at oracle dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/58724] doc: use of attributes for namespace is not clear Date: Mon, 14 Oct 2013 15:54:00 -0000 [thread overview] Message-ID: <bug-58724-4-nznucMyzT9@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-58724-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58724 Paolo Carlini <paolo.carlini at oracle dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Last reconfirmed| |2013-10-14 Ever confirmed|0 |1 --- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> --- In mainline (I don't think this can be fixed in 4.8.x), it seems to me that the below may be all there is to the issue (for more about TREE_PURPOSE vs get_attribute_name, see PR58600). Can you test it on your code? //////////////// Index: name-lookup.c =================================================================== --- name-lookup.c (revision 203517) +++ name-lookup.c (working copy) @@ -3571,7 +3571,7 @@ for (d = attributes; d; d = TREE_CHAIN (d)) { - tree name = TREE_PURPOSE (d); + tree name = get_attribute_name (d); tree args = TREE_VALUE (d); if (is_attribute_p ("visibility", name))
next prev parent reply other threads:[~2013-10-14 15:54 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-10-14 15:20 [Bug c++/58724] New: " akim.demaille at gmail dot com 2013-10-14 15:54 ` paolo.carlini at oracle dot com [this message] 2013-10-14 15:57 ` [Bug c++/58724] " akim.demaille at gmail dot com 2013-10-14 16:01 ` paolo.carlini at oracle dot com 2013-10-14 16:03 ` paolo.carlini at oracle dot com 2013-10-14 16:17 ` [Bug c++/58724] ICE with attribute [[gnu::visibility("default")]] on namespace paolo.carlini at oracle dot com 2013-10-16 9:13 ` paolo.carlini at oracle dot com 2013-10-23 0:16 ` paolo.carlini at oracle dot com 2013-11-05 15:24 ` paolo at gcc dot gnu.org 2013-11-05 15:26 ` paolo.carlini at oracle dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-58724-4-nznucMyzT9@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).