* [Bug fortran/58754] ICE/Regression in [4.7/4.8/4.9] with allocatable character arrays
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
@ 2013-10-16 21:01 ` burnus at gcc dot gnu.org
2013-11-19 9:50 ` [Bug fortran/58754] [4.7/4.8/4.9 Regression] " rguenth at gcc dot gnu.org
` (15 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: burnus at gcc dot gnu.org @ 2013-10-16 21:01 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |ice-on-valid-code
Status|UNCONFIRMED |NEW
Last reconfirmed| |2013-10-16
CC| |burnus at gcc dot gnu.org
Known to work| |4.6.3
Depends on| |57456
Ever confirmed|0 |1
Known to fail| |4.7.3, 4.8.1, 4.9.0
--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
The segfault occurs for trans-array.c's gfc_array_init_size:
5064 if (expr3_elem_size != NULL_TREE)
5065 tmp = expr3_elem_size;
5066 else if (expr3 != NULL)
5067 {
...
5089 tmp = TYPE_SIZE_UNIT (gfc_get_element_type (type));
5092 element_size = fold_convert (size_type_node, tmp);
And here tmp == NULL. I think the problem is that characters have to be handled
separately.
There should be somewhere a PR which is about moving all the memory size
calculation to gfc_trans_allocate - which already does it for scalars - instead
of partially repeating it in gfc_array_init_size. (The current algorithm might
also cause multiple function evaluation, which is wrong, too.)
I believe unifying the could would be the proper fix (and good in terms of code
size/maintenance as well). -- The PR I meant is: PR57456.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.7/4.8/4.9 Regression] with allocatable character arrays
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
2013-10-16 21:01 ` [Bug fortran/58754] ICE/Regression in [4.7/4.8/4.9] with allocatable character arrays burnus at gcc dot gnu.org
@ 2013-11-19 9:50 ` rguenth at gcc dot gnu.org
2014-06-12 13:48 ` [Bug fortran/58754] [4.7/4.8/4.9/4.10 " rguenth at gcc dot gnu.org
` (14 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-11-19 9:50 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P4
Target Milestone|--- |4.7.4
Summary|ICE/Regression in |[4.7/4.8/4.9 Regression]
|[4.7/4.8/4.9] with |with allocatable character
|allocatable character |arrays
|arrays |
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.7/4.8/4.9/4.10 Regression] with allocatable character arrays
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
2013-10-16 21:01 ` [Bug fortran/58754] ICE/Regression in [4.7/4.8/4.9] with allocatable character arrays burnus at gcc dot gnu.org
2013-11-19 9:50 ` [Bug fortran/58754] [4.7/4.8/4.9 Regression] " rguenth at gcc dot gnu.org
@ 2014-06-12 13:48 ` rguenth at gcc dot gnu.org
2014-11-25 15:41 ` [Bug fortran/58754] [4.8/4.9/5 " janus at gcc dot gnu.org
` (13 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-06-12 13:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.7.4 |4.8.4
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
The 4.7 branch is being closed, moving target milestone to 4.8.4.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.8/4.9/5 Regression] with allocatable character arrays
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2014-06-12 13:48 ` [Bug fortran/58754] [4.7/4.8/4.9/4.10 " rguenth at gcc dot gnu.org
@ 2014-11-25 15:41 ` janus at gcc dot gnu.org
2014-12-19 13:43 ` [Bug fortran/58754] [4.8/4.9/5 Regression] ICE on allocating character array with source jakub at gcc dot gnu.org
` (12 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: janus at gcc dot gnu.org @ 2014-11-25 15:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
janus at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |janus at gcc dot gnu.org
--- Comment #3 from janus at gcc dot gnu.org ---
*** Bug 64069 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.8/4.9/5 Regression] ICE on allocating character array with source
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2014-11-25 15:41 ` [Bug fortran/58754] [4.8/4.9/5 " janus at gcc dot gnu.org
@ 2014-12-19 13:43 ` jakub at gcc dot gnu.org
2015-04-11 21:50 ` pault at gcc dot gnu.org
` (11 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2014-12-19 13:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.8.4 |4.8.5
--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.4 has been released.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.8/4.9/5 Regression] ICE on allocating character array with source
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2014-12-19 13:43 ` [Bug fortran/58754] [4.8/4.9/5 Regression] ICE on allocating character array with source jakub at gcc dot gnu.org
@ 2015-04-11 21:50 ` pault at gcc dot gnu.org
2015-04-12 8:36 ` dominiq at lps dot ens.fr
` (10 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: pault at gcc dot gnu.org @ 2015-04-11 21:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
Paul Thomas <pault at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pault at gcc dot gnu.org
Assignee|unassigned at gcc dot gnu.org |pault at gcc dot gnu.org
--- Comment #5 from Paul Thomas <pault at gcc dot gnu.org> ---
Created attachment 35301
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35301&action=edit
A preliminary patch
This fixes the problem. However, it will produce multiple evaluations of
function results and expressions. I will introduce a temporary to cover those
cases.
Paul
PS It's a pity I did not clock this before the RC!
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.8/4.9/5 Regression] ICE on allocating character array with source
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2015-04-11 21:50 ` pault at gcc dot gnu.org
@ 2015-04-12 8:36 ` dominiq at lps dot ens.fr
2015-04-17 15:58 ` [Bug fortran/58754] [4.8/4.9/5/6 " pault at gcc dot gnu.org
` (9 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: dominiq at lps dot ens.fr @ 2015-04-12 8:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
--- Comment #6 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> This fixes the problem.
Confirmed.
> However, it will produce multiple evaluations of function results
> and expressions. I will introduce a temporary to cover those cases.
Is it obvious?
> PS It's a pity I did not clock this before the RC!
No RC yet!
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.8/4.9/5/6 Regression] ICE on allocating character array with source
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2015-04-12 8:36 ` dominiq at lps dot ens.fr
@ 2015-04-17 15:58 ` pault at gcc dot gnu.org
2015-04-17 16:03 ` dominiq at lps dot ens.fr
` (8 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: pault at gcc dot gnu.org @ 2015-04-17 15:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
--- Comment #7 from Paul Thomas <pault at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #6)
> > This fixes the problem.
>
> Confirmed.
>
> > However, it will produce multiple evaluations of function results
> > and expressions. I will introduce a temporary to cover those cases.
>
> Is it obvious?
>
> > PS It's a pity I did not clock this before the RC!
>
> No RC yet!
What, really?
Paul
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.8/4.9/5/6 Regression] ICE on allocating character array with source
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2015-04-17 15:58 ` [Bug fortran/58754] [4.8/4.9/5/6 " pault at gcc dot gnu.org
@ 2015-04-17 16:03 ` dominiq at lps dot ens.fr
2015-04-17 17:47 ` paul.richard.thomas at gmail dot com
` (7 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: dominiq at lps dot ens.fr @ 2015-04-17 16:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
--- Comment #8 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> > No RC yet!
>
> What, really?
Now yes. 5.1 should be available in the middle of next week.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.8/4.9/5/6 Regression] ICE on allocating character array with source
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2015-04-17 16:03 ` dominiq at lps dot ens.fr
@ 2015-04-17 17:47 ` paul.richard.thomas at gmail dot com
2015-06-23 8:27 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: paul.richard.thomas at gmail dot com @ 2015-04-17 17:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
--- Comment #9 from paul.richard.thomas at gmail dot com <paul.richard.thomas at gmail dot com> ---
Ah that's a pity. I thought that 5.0 had closed when Tobias was
panicking about his co-array patch. I didn't think to check.
Cheers
Paul
On 17 April 2015 at 18:03, dominiq at lps dot ens.fr
<gcc-bugzilla@gcc.gnu.org> wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
>
> --- Comment #8 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
>> > No RC yet!
>>
>> What, really?
>
> Now yes. 5.1 should be available in the middle of next week.
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
> You are the assignee for the bug.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.8/4.9/5/6 Regression] ICE on allocating character array with source
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
` (9 preceding siblings ...)
2015-04-17 17:47 ` paul.richard.thomas at gmail dot com
@ 2015-06-23 8:27 ` rguenth at gcc dot gnu.org
2015-06-26 20:17 ` [Bug fortran/58754] [4.9/5/6 " jakub at gcc dot gnu.org
` (5 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: rguenth at gcc dot gnu.org @ 2015-06-23 8:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.8.5 |4.9.3
--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
The gcc-4_8-branch is being closed, re-targeting regressions to 4.9.3.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.9/5/6 Regression] ICE on allocating character array with source
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
` (10 preceding siblings ...)
2015-06-23 8:27 ` rguenth at gcc dot gnu.org
@ 2015-06-26 20:17 ` jakub at gcc dot gnu.org
2015-06-26 20:38 ` jakub at gcc dot gnu.org
` (4 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2015-06-26 20:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.3 has been released.
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.9/5/6 Regression] ICE on allocating character array with source
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
` (11 preceding siblings ...)
2015-06-26 20:17 ` [Bug fortran/58754] [4.9/5/6 " jakub at gcc dot gnu.org
@ 2015-06-26 20:38 ` jakub at gcc dot gnu.org
2015-10-19 19:46 ` [Bug fortran/58754] [4.9/5 " pault at gcc dot gnu.org
` (3 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2015-06-26 20:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.9.3 |4.9.4
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.9/5 Regression] ICE on allocating character array with source
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
` (12 preceding siblings ...)
2015-06-26 20:38 ` jakub at gcc dot gnu.org
@ 2015-10-19 19:46 ` pault at gcc dot gnu.org
2015-10-22 18:05 ` pault at gcc dot gnu.org
` (2 subsequent siblings)
16 siblings, 0 replies; 17+ messages in thread
From: pault at gcc dot gnu.org @ 2015-10-19 19:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
Paul Thomas <pault at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[4.9/5/6 Regression] ICE on |[4.9/5 Regression] ICE on
|allocating character array |allocating character array
|with source |with source
--- Comment #12 from Paul Thomas <pault at gcc dot gnu.org> ---
This is fixed on trunk - I suspect that Andre has put it right. I have applied
my patch to 5 branch and am regtesting it right now.
Paul
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.9/5 Regression] ICE on allocating character array with source
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
` (13 preceding siblings ...)
2015-10-19 19:46 ` [Bug fortran/58754] [4.9/5 " pault at gcc dot gnu.org
@ 2015-10-22 18:05 ` pault at gcc dot gnu.org
2015-10-22 18:09 ` pault at gcc dot gnu.org
2015-10-22 18:11 ` pault at gcc dot gnu.org
16 siblings, 0 replies; 17+ messages in thread
From: pault at gcc dot gnu.org @ 2015-10-22 18:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
--- Comment #13 from Paul Thomas <pault at gcc dot gnu.org> ---
Author: pault
Date: Thu Oct 22 18:05:21 2015
New Revision: 229179
URL: https://gcc.gnu.org/viewcvs?rev=229179&root=gcc&view=rev
Log:
2015-10-22 Paul Thomas <pault@gcc.gnu.org>
PR fortran/58754
* trans-stmt.c (gfc_trans_allocate): Do not use the scalar
character assignment if the allocate expression is an array
descriptor.
2015-10-22 Paul Thomas <pault@gcc.gnu.org>
PR fortran/58754
* gfortran.dg/pr58754.f90: New test
Added:
branches/gcc-5-branch/gcc/testsuite/gfortran.dg/pr58754.f90
Modified:
branches/gcc-5-branch/gcc/fortran/ChangeLog
branches/gcc-5-branch/gcc/fortran/trans-stmt.c
branches/gcc-5-branch/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.9/5 Regression] ICE on allocating character array with source
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
` (14 preceding siblings ...)
2015-10-22 18:05 ` pault at gcc dot gnu.org
@ 2015-10-22 18:09 ` pault at gcc dot gnu.org
2015-10-22 18:11 ` pault at gcc dot gnu.org
16 siblings, 0 replies; 17+ messages in thread
From: pault at gcc dot gnu.org @ 2015-10-22 18:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
--- Comment #14 from Paul Thomas <pault at gcc dot gnu.org> ---
Author: pault
Date: Thu Oct 22 18:08:31 2015
New Revision: 229180
URL: https://gcc.gnu.org/viewcvs?rev=229180&root=gcc&view=rev
Log:
2015-10-22 Paul Thomas <pault@gcc.gnu.org>
PR fortran/58754
* gfortran.dg/pr58754.f90: New test
Added:
branches/gcc-4_9-branch/gcc/testsuite/gfortran.dg/pr58754.f90
Modified:
branches/gcc-4_9-branch/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug fortran/58754] [4.9/5 Regression] ICE on allocating character array with source
[not found] <bug-58754-4@http.gcc.gnu.org/bugzilla/>
` (15 preceding siblings ...)
2015-10-22 18:09 ` pault at gcc dot gnu.org
@ 2015-10-22 18:11 ` pault at gcc dot gnu.org
16 siblings, 0 replies; 17+ messages in thread
From: pault at gcc dot gnu.org @ 2015-10-22 18:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
Paul Thomas <pault at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #15 from Paul Thomas <pault at gcc dot gnu.org> ---
Dear Juergen,
Thanks for the report. I am sorry that it has taken a long time to get round to
fixing it.
Best regards
Paul
^ permalink raw reply [flat|nested] 17+ messages in thread