From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-432569-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 19345 invoked by alias); 23 Oct 2013 16:19:26 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 19229 invoked by uid 55); 23 Oct 2013 16:19:21 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/58775] [4.9 Regression] reassoc1 causes an ICE with some bool arithmetic
Date: Wed, 23 Oct 2013 16:19:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: critical
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-58775-4-cQUj79fOUK@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58775-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58775-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-10/txt/msg01713.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58775

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Wed Oct 23 16:19:17 2013
New Revision: 203979

URL: http://gcc.gnu.org/viewcvs?rev=203979&root=gcc&view=rev
Log:
    PR tree-optimization/58775
    PR tree-optimization/58791
    * tree-ssa-reassoc.c (reassoc_stmt_dominates_stmt_p): New function.
    (insert_stmt_after): Rewritten, don't move the stmt, but really
    insert it.
    (get_stmt_uid_with_default): Remove.
    (build_and_add_sum): Use insert_stmt_after and
    reassoc_stmt_dominates_stmt_p.  Fix up uid if bb contains only
    labels.
    (update_range_test): Set uid on stmts added by
    force_gimple_operand_gsi.  Don't immediately modify statements
    in inter-bb optimization, just update oe->op values.
    (optimize_range_tests): Return bool whether any changed have
    been made.
    (update_ops): New function.
    (struct inter_bb_range_test_entry): New type.
    (maybe_optimize_range_tests): Perform statement changes here.
    (not_dominated_by, appears_later_in_bb, get_def_stmt,
    ensure_ops_are_available): Remove.
    (find_insert_point): Rewritten.
    (rewrite_expr_tree): Remove MOVED argument, add CHANGED argument,
    return LHS of the (new resp. old) stmt.  Don't call
    ensure_ops_are_available, don't reuse SSA_NAMEs, recurse first
    instead of last, move new stmt at the right place.
    (linearize_expr, repropagate_negates): Don't reuse SSA_NAMEs.
    (negate_value): Likewise.  Set uids.
    (break_up_subtract_bb): Initialize uids.
    (reassociate_bb): Adjust rewrite_expr_tree caller.
    (do_reassoc): Don't call renumber_gimple_stmt_uids.

    * gcc.dg/guality/pr58791-1.c: New test.
    * gcc.dg/guality/pr58791-2.c: New test.
    * gcc.dg/guality/pr58791-3.c: New test.
    * gcc.dg/guality/pr58791-4.c: New test.
    * gcc.dg/guality/pr58791-5.c: New test.
    * gcc.c-torture/compile/pr58775.c: New test.
    * gcc.dg/tree-ssa/reassoc-28.c: Don't scan reassoc1 dump.

Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/pr58775.c
    trunk/gcc/testsuite/gcc.dg/guality/pr58791-1.c
    trunk/gcc/testsuite/gcc.dg/guality/pr58791-2.c
    trunk/gcc/testsuite/gcc.dg/guality/pr58791-3.c
    trunk/gcc/testsuite/gcc.dg/guality/pr58791-4.c
    trunk/gcc/testsuite/gcc.dg/guality/pr58791-5.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/tree-ssa/reassoc-28.c
    trunk/gcc/tree-ssa-reassoc.c