[Bug fortran/58813] New: SIGSEGV in show_locus at error.c:310

[Bug fortran/58813] New: SIGSEGV in show_locus at error.c:310

[zeccav at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58813

            Bug ID: 58813
           Summary: SIGSEGV in show_locus at error.c:310
           Product: gcc
           Version: 4.8.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zeccav at gmail dot com

! SIGSEGV in show_locus at error.c:310
! must be compiled as free form
! if seen as fixed format no SIGSEGV
! valgrind and sanitizer say invalid read at symbol.c:5001 "dummies =
sym->formal;" 
! sym already freed at symbol.c:2519? In gfc_free_symbol "free (sym);"
! linked to bug 56674?
      MODULE m
      PUBLIC t
      CONTAINS
      SUBROUTINE s
       TYPE(t)
      END SUBROUTINE
      END MODULE
!f951: internal compiler error: Segmentation fault
!0x869b1f crash_signal
!        ../../gcc-4.8.2/gcc/toplev.c:332
!0x50b1eb show_locus
!        ../../gcc-4.8.2/gcc/fortran/error.c:310
!0x50ba80 show_loci
!        ../../gcc-4.8.2/gcc/fortran/error.c:434
!0x50ba80 error_print
!        ../../gcc-4.8.2/gcc/fortran/error.c:666
!0x50c568 gfc_error(char const*, ...)
!        ../../gcc-4.8.2/gcc/fortran/error.c:961
!0x5142e7 check_interface0
!        ../../gcc-4.8.2/gcc/fortran/interface.c:1477
!0x516bc4 check_sym_interfaces
!        ../../gcc-4.8.2/gcc/fortran/interface.c:1589
!0x57e493 do_traverse_symtree
!        ../../gcc-4.8.2/gcc/fortran/symbol.c:3575
!0x516cac gfc_check_interfaces(gfc_namespace*)
!        ../../gcc-4.8.2/gcc/fortran/interface.c:1699
!0x55d31e resolve_types
!        ../../gcc-4.8.2/gcc/fortran/resolve.c:14989
!0x55dba0 gfc_resolve
!        ../../gcc-4.8.2/gcc/fortran/resolve.c:15073
!0x552286 gfc_parse_file()
!        ../../gcc-4.8.2/gcc/fortran/parse.c:4614
!0x58e195 gfc_be_parse_file
!        ../../gcc-4.8.2/gcc/fortran/f95-lang.c:189
!Please submit a full bug report,
!with preprocessed source if appropriate.
!Please include the complete backtrace with any bug report.

[Bug fortran/58813] SIGSEGV in show_locus at error.c:310

[kargl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58813

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |kargl at gcc dot gnu.org
         Resolution|---                         |FIXED

--- Comment #1 from kargl at gcc dot gnu.org ---
With trunk gfortran gives

troutmask:sgk[209] gfc4x -c b.f90
b.f90:5.16:

         type(t)
                1
Error: Derived type 't' at (1) is being used before it is defined
b.f90:7:

end module m
1
Error: Procedure 'block@6' in generic interface 't' at (1) is neither function
nor subroutine

[Bug fortran/58813] SIGSEGV in show_locus at error.c:310

[kargl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58813

--- Comment #2 from kargl at gcc dot gnu.org ---
(In reply to kargl from comment #1)
> With trunk gfortran gives
> 
> troutmask:sgk[209] gfc4x -c b.f90
> b.f90:5.16:
> 
>          type(t)
>                 1
> Error: Derived type 't' at (1) is being used before it is defined
> b.f90:7:
> 
> end module m
> 1
> Error: Procedure 'block@6' in generic interface 't' at (1) is neither
> function nor subroutine

I get a similar error message with 4.6.4, 4.7.4, and 4.8.2 20130916.

[Bug fortran/58813] SIGSEGV in show_locus at error.c:310

[burnus at gcc dot gnu.org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 5476 bytes --]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58813

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
      Known to work|                            |4.6.3
           Keywords|                            |error-recovery,
                   |                            |ice-on-invalid-code
   Last reconfirmed|                            |2013-10-21
                 CC|                            |burnus at gcc dot gnu.org
         Resolution|FIXED                       |---
     Ever confirmed|0                           |1
      Known to fail|                            |4.7.3, 4.8.2, 4.9.0

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> ---
REOPEN.

I see this issue also with the trunk. With MALLOC_PERTURB_ set, it segfaults in

0x5f8e1c resolve_fl_procedure
        ../../gcc/fortran/resolve.c:10980


Without, it compiles, but shows:

Error: Procedure 'ySâ–’+' in generic interface 't' at (1) is neither function nor
subroutine

where the procedure name is garbage.


(It works with GCC <= 4.6. I assume it is a side effect of the constructor
patch.)
>From gcc-bugs-return-432373-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 21 16:07:35 2013
Return-Path: <gcc-bugs-return-432373-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 17732 invoked by alias); 21 Oct 2013 16:07:35 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 17689 invoked by uid 48); 21 Oct 2013 16:07:32 -0000
From: "law at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/58759] [4.9 Regression] wrong code (segfaults) at -O2 on x86_64-linux-gnu in 32-bit mode
Date: Mon, 21 Oct 2013 16:07:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: law at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-58759-4-Ntk1gLcJhb@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58759-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58759-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-10/txt/msg01517.txt.bz2
Content-length: 2309

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX759

Jeffrey A. Law <law at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vmakarov at redhat dot com

--- Comment #5 from Jeffrey A. Law <law at redhat dot com> ---
Really looks like an LRA/IRA issue to me.  The problem insn doesn't exist until
reloading.  It gets created here:

#0  make_insn_raw (pattern=0x7ffff0308000) at
/home/gcc/GIT/gcc/gcc/emit-rtl.c:3654
#1  0x0000000000789ead in emit_insn (x=0x7ffff0308000) at
/home/gcc/GIT/gcc/gcc/emit-rtl.c:4737
#2  0x0000000000df5214 in ix86_expand_move (mode=SImode,
operands=0x7fffffffdb60) at /home/gcc/GIT/gcc/gcc/config/i386/i386.c:16419
#3  0x0000000000eb7484 in gen_movsi (operand0=0x7ffff0300fe0,
operand1=0x7ffff03072a0) at /home/gcc/GIT/gcc/gcc/config/i386/i386.md:1788
#4  0x00000000007d0609 in insn_gen_fn::operator() (this=0x1512cd0
<insn_data+99216>, a0=0x7ffff0300fe0, a1=0x7ffff03072a0) at
/home/gcc/GIT/gcc/gcc/recog.h:284
#5  0x00000000007b4d94 in emit_move_insn_1 (x=0x7ffff0300fe0, y=0x7ffff03072a0)
at /home/gcc/GIT/gcc/gcc/expr.c:3447
#6  0x00000000009dd1c3 in gen_move_insn (x=0x7ffff0300fe0, y=0x7ffff03072a0) at
/home/gcc/GIT/gcc/gcc/optabs.c:4812
#7  0x000000000097534a in emit_spill_move (to_púlse,
mem_pseudo=0x7ffff03072a0, val=0x7ffff0300fe0) at
/home/gcc/GIT/gcc/gcc/lra-constraints.c:880
#8  0x000000000097eb18 in split_reg (before_púlse, original_regno\x115,
insn=0x7ffff02ea400, next_usage_insns=0x7ffff0304828) at
/home/gcc/GIT/gcc/gcc/lra-constraints.c:4628
#9  0x0000000000980eee in inherit_in_ebb (head=0x7ffff02fa870,
tail=0x7ffff0304828) at /home/gcc/GIT/gcc/gcc/lra-constraints.c:5244
#10 0x00000000009811e8 in lra_inheritance () at
/home/gcc/GIT/gcc/gcc/lra-constraints.c:5311
#11 0x000000000096b92d in lra (f=0x0) at /home/gcc/GIT/gcc/gcc/lra.c:2338
#12 0x000000000091d079 in do_reload () at /home/gcc/GIT/gcc/gcc/ira.c:4686

We've had numerous problems with reload in the past trying to store into
readonly memory due to reloading values with known equivalent memory locations
(as is the case here).  I wouldn't be surprised to see some of the same
problems showing up in IRA.

Vlad, can you take a look?

[Bug fortran/58813] SIGSEGV in show_locus at error.c:310

[sgk at troutmask dot apl.washington.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58813

--- Comment #4 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Mon, Oct 21, 2013 at 04:01:43PM +0000, burnus at gcc dot gnu.org wrote:
> 
> Error: Procedure 'yS???+' in generic interface 't' at (1) is neither
> function nor subroutine
> 
> where the procedure name is garbage.
> 

Like many error messages, this is a run-on error due to the
first one.  If one fixes the first error, the second goes
away.  The best fix would be to change gfc_option.max_errors 
from 25 to 1.

[Bug fortran/58813] SIGSEGV in show_locus at error.c:310

[zeccav at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58813

--- Comment #5 from Vittorio Zecca <zeccav at gmail dot com> ---
I did not know about MALLOC_PERTURB_ I just put in my .bashrc profile
export MALLOC_PERTURB_=$(($RANDOM % 255 + 1))

gfortran fails in different places if the input file is .f or .f90

As .f I get bus error at resolve.c:11510 'gfc_notify_std
(GFC_STD_F2003, "Procedure "',
as .f90 I get segmentation fault at error.c:310 "error_string (f->filename);"

[Bug fortran/58813] SIGSEGV in show_locus at error.c:310

[sgk at troutmask dot apl.washington.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58813

--- Comment #7 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Tue, Oct 22, 2013 at 06:40:22AM +0000, zeccav at gmail dot com wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58813
> 
> --- Comment #6 from Vittorio Zecca <zeccav at gmail dot com> ---
> I found that
> export MALLOC_PERTURB_=256
> produces a quiet NaN. I'll use this one in my .bashrc
> It seems to me that the earlier symptom of malfunctioning
> is in symbol.c:5001 " dummies = sym->formal;" where sym points the wrong way.

What happens if you use -fmax-errors=1?

[Bug fortran/58813] SIGSEGV in show_locus at error.c:310

[zeccav at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58813

--- Comment #8 from Vittorio Zecca <zeccav at gmail dot com> ---
If I use the option -fmax-errors=1 the ICE disappears, but using this
option as a default
would potentially increase the time needed to get an error free code.
A code containing many errors would require as many iterations of
error fixing and compilation.
I believe gfortran makes an excellent job at recovering from source
errors and issuing
as many as possible meaningful error messages.
This code is a special case where gfortran fails while recovering, in
my opinion this case
should be fixed to keep the current unlimited default for -fmax-errors.

[Bug fortran/58813] SIGSEGV in show_locus at error.c:310

[kargl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58813

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|kargl at gcc dot gnu.org           |

--- Comment #9 from kargl at gcc dot gnu.org ---
Remove myself from cc list.

[Bug fortran/58813] SIGSEGV in show_locus at error.c:310

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58813

--- Comment #10 from Mikael Morin <mikael at gcc dot gnu.org> ---
Author: mikael
Date: Fri Apr 10 11:29:53 2015
New Revision: 221972

URL: https://gcc.gnu.org/viewcvs?rev=221972&root=gcc&view=rev
Log:
    PR fortran/56674
    PR fortran/58813
    PR fortran/59016
    PR fortran/59024
fortran/
    * symbol.c (save_symbol_data, gfc_save_symbol_data): Rename the
    former to the latter and make it non-static.  Update callers.
    * gfortran.h (gfc_save_symbol_data): New prototype.
    * decl.c (gfc_match_decl_type_spec): Call 'gfc_save_symbol_data'
    before modifying symbols 'sym' and 'dt_sym'.
testsuite/
    * gfortran.dg/used_types_27.f90: New.


Added:
    trunk/gcc/testsuite/gfortran.dg/used_types_27.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/decl.c
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/symbol.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/58813] SIGSEGV in show_locus at error.c:310

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58813

--- Comment #11 from Mikael Morin <mikael at gcc dot gnu.org> ---
Author: mikael
Date: Tue Apr 14 09:18:15 2015
New Revision: 222078

URL: https://gcc.gnu.org/viewcvs?rev=222078&root=gcc&view=rev
Log:
    PR fortran/56674
    PR fortran/58813
    PR fortran/59016
    PR fortran/59024
fortran/
    * symbol.c (save_symbol_data, gfc_save_symbol_data): Rename the
    former to the latter and make it non-static.  Update callers.
    * gfortran.h (gfc_save_symbol_data): New prototype.
    * decl.c (gfc_match_decl_type_spec): Call 'gfc_save_symbol_data'
    before modifying symbols 'sym' and 'dt_sym'.
testsuite/
    * gfortran.dg/used_types_27.f90: New.


Added:
    branches/gcc-4_9-branch/gcc/testsuite/gfortran.dg/used_types_27.f90
Modified:
    branches/gcc-4_9-branch/gcc/fortran/ChangeLog
    branches/gcc-4_9-branch/gcc/fortran/decl.c
    branches/gcc-4_9-branch/gcc/fortran/gfortran.h
    branches/gcc-4_9-branch/gcc/fortran/symbol.c
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog

[Bug fortran/58813] SIGSEGV in show_locus at error.c:310

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58813

--- Comment #12 from Mikael Morin <mikael at gcc dot gnu.org> ---
Author: mikael
Date: Tue Apr 14 12:23:30 2015
New Revision: 222086

URL: https://gcc.gnu.org/viewcvs?rev=222086&root=gcc&view=rev
Log:
    PR fortran/56674
    PR fortran/58813
    PR fortran/59016
    PR fortran/59024
fortran/
    * symbol.c (save_symbol_data, gfc_save_symbol_data): Rename the
    former to the latter and make it non-static.  Update callers.
    * gfortran.h (gfc_save_symbol_data): New prototype.
    * decl.c (gfc_match_decl_type_spec): Call 'gfc_save_symbol_data'
    before modifying symbols 'sym' and 'dt_sym'.
testsuite/
    * gfortran.dg/used_types_27.f90: New.


Added:
    branches/gcc-4_8-branch/gcc/testsuite/gfortran.dg/used_types_27.f90
Modified:
    branches/gcc-4_8-branch/gcc/fortran/ChangeLog
    branches/gcc-4_8-branch/gcc/fortran/decl.c
    branches/gcc-4_8-branch/gcc/fortran/gfortran.h
    branches/gcc-4_8-branch/gcc/fortran/symbol.c
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog

[Bug fortran/58813] SIGSEGV in show_locus at error.c:310

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58813

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
                 CC|                            |mikael at gcc dot gnu.org
         Resolution|---                         |DUPLICATE

--- Comment #13 from Mikael Morin <mikael at gcc dot gnu.org> ---
Dup.

*** This bug has been marked as a duplicate of bug 59016 ***