public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug testsuite/58851] FAIL: gfortran.dg/unlimited_polymorphic_13.f90 -O0 execution test Date: Wed, 23 Oct 2013 20:57:00 -0000 [thread overview] Message-ID: <bug-58851-4-gZt1iASLSd@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-58851-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58851 --- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> --- (In reply to paul.richard.thomas@gmail.com from comment #3) > I had changed the testcase to: ... which is in the essential part the same. (I had a few more checks, but those do not really matter.) > Is it not the case that the select type (o) is unnecessary for the test? > That is ' if (storage_size(o) /= sz) call abort()' is all that is needed? For this bug, yes. But I think checking that within SELECT TYPE the correct SIZE_OF is applied, doesn't harm. Thus, I think it is useful to have. I leave committing the patch to you – I think either of our versions is fine. >From gcc-bugs-return-432587-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Oct 23 21:14:01 2013 Return-Path: <gcc-bugs-return-432587-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org> Delivered-To: listarch-gcc-bugs@gcc.gnu.org Received: (qmail 18903 invoked by alias); 23 Oct 2013 21:14:00 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: <gcc-bugs.gcc.gnu.org> List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/> List-Post: <mailto:gcc-bugs@gcc.gnu.org> List-Help: <mailto:gcc-bugs-help@gcc.gnu.org> Sender: gcc-bugs-owner@gcc.gnu.org Delivered-To: mailing list gcc-bugs@gcc.gnu.org Received: (qmail 18825 invoked by uid 55); 23 Oct 2013 21:13:55 -0000 From: "tmsriram at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/57756] Function target attribute is retaining state of previously seen function Date: Wed, 23 Oct 2013 21:14:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 4.9.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: tmsriram at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: <bug-57756-4-ITWDSRJa19@http.gcc.gnu.org/bugzilla/> In-Reply-To: <bug-57756-4@http.gcc.gnu.org/bugzilla/> References: <bug-57756-4@http.gcc.gnu.org/bugzilla/> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2013-10/txt/msg01731.txt.bz2 Content-length: 779 http://gcc.gnu.org/bugzilla/show_bug.cgi?idW756 --- Comment #5 from tmsriram at gcc dot gnu.org <tmsriram at gcc dot gnu.org> --- Author: tmsriram Date: Wed Oct 23 21:13:50 2013 New Revision: 203991 URL: http://gcc.gnu.org/viewcvs?rev 3991&root=gcc&view=rev Log: PR target/57756 Replace further references to global_options in functions ix86_option_override_internal and ix86_valid_target_attribute_tree in config/i386/i386.c. PR target/57756 * config/i386/i386.c (ix86_option_override_internal): Change TARGET_SSE2 to TARGET_SSE2_P (opts->...) (ix86_valid_target_attribute_tree): Change TARGET_64BIT to TARGET_64BIT_P (opts->...) Change TARGET_SSE to TARGET_SSE_P (opts->...) Modified: trunk/gcc/ChangeLog trunk/gcc/config/i386/i386.c
next prev parent reply other threads:[~2013-10-23 20:57 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-58851-4@http.gcc.gnu.org/bugzilla/> 2013-10-23 11:29 ` pault at gcc dot gnu.org 2013-10-23 15:44 ` burnus at gcc dot gnu.org 2013-10-23 20:39 ` paul.richard.thomas at gmail dot com 2013-10-23 20:57 ` burnus at gcc dot gnu.org [this message] 2013-10-25 9:12 ` paul.richard.thomas at gmail dot com 2013-10-30 9:23 ` schwab@linux-m68k.org 2013-10-30 9:42 ` paul.richard.thomas at gmail dot com 2013-11-02 22:18 ` schwab@linux-m68k.org 2013-11-04 18:41 ` burnus at gcc dot gnu.org 2013-11-04 19:15 ` paul.richard.thomas at gmail dot com 2013-11-04 20:47 ` schwab@linux-m68k.org 2013-11-04 21:28 ` burnus at gcc dot gnu.org 2013-11-04 22:23 ` schwab@linux-m68k.org 2014-03-17 9:23 ` schwab at gcc dot gnu.org 2014-03-17 9:25 ` schwab@linux-m68k.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-58851-4-gZt1iASLSd@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).