public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/58853] [4.9 regression] ICE in expand_set_or_movmem_prologue_epilogue_by_misaligned_moves
Date: Mon, 11 Nov 2013 16:41:00 -0000	[thread overview]
Message-ID: <bug-58853-4-RNBBVJhLDy@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-58853-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58853

--- Comment #7 from Jan Hubicka <hubicka at ucw dot cz> ---
> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
> index 53e04c4..dd8d943 100644
> --- a/gcc/config/i386/i386.c
> +++ b/gcc/config/i386/i386.c
> @@ -23766,6 +23766,7 @@ ix86_expand_set_or_movmem (rtx dst, rtx src, rtx
> count_exp, rtx 
> val_exp,
>       also avoids redundant job when sizes are known precisely.  */
>    misaligned_prologue_used = (TARGET_MISALIGNED_MOVE_STRING_PROLOGUES
>                    && MAX (desired_align, epilogue_size_needed) <= 32
> +                  && desired_align <= epilogue_size_needed
>                    && ((desired_align > align && !align_bytes)
>                    || (!count && epilogue_size_needed > 1)));
> 
> avoids crash.

Yes, we can add this, too, for correctness with manual changes to tunning flags
(so the patch is approved).
What confuses me is why TARGET_MISALIGNED_MOVE_STRING_PROLOGUES seems to be
true
given that

DEF_TUNE (TARGET_MISALIGNED_MOVE_STRING_PROLOGUES,
          "misaligned_move_string_prologues",
          m_386 | m_486 | m_CORE_ALL | m_AMD_MULTIPLE | m_GENERIC)

and we tune for pentiumpro (that was intentionally left out for this purpose)

Honza


  parent reply	other threads:[~2013-11-11 16:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-23 14:05 [Bug rtl-optimization/58853] New: [4.9 regression] ICE after r203937 ysrumyan at gmail dot com
2013-10-23 14:40 ` [Bug rtl-optimization/58853] " izamyatin at gmail dot com
2013-10-23 14:45 ` hubicka at gcc dot gnu.org
2013-10-23 17:52 ` [Bug target/58853] [4.9 regression] ICE in expand_set_or_movmem_prologue_epilogue_by_misaligned_moves ebotcazou at gcc dot gnu.org
2013-11-05  8:41 ` ubizjak at gmail dot com
2013-11-05  9:19 ` hubicka at ucw dot cz
2013-11-07 13:56 ` hjl.tools at gmail dot com
2013-11-11 16:41 ` hubicka at ucw dot cz [this message]
2013-11-11 16:55 ` ubizjak at gmail dot com
2013-11-11 17:04 ` ubizjak at gmail dot com
2013-11-11 20:02 ` uros at gcc dot gnu.org
2013-11-11 20:12 ` ubizjak at gmail dot com
2013-11-14 21:27 ` uros at gcc dot gnu.org
2013-11-14 21:30 ` ubizjak at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-58853-4-RNBBVJhLDy@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).