From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-434289-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 11586 invoked by alias); 11 Nov 2013 16:41:05 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 10141 invoked by uid 55); 11 Nov 2013 16:40:22 -0000
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/58853] [4.9 regression] ICE in expand_set_or_movmem_prologue_epilogue_by_misaligned_moves
Date: Mon, 11 Nov 2013 16:41:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: hubicka at ucw dot cz
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: hubicka at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-58853-4-RNBBVJhLDy@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58853-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58853-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-11/txt/msg01066.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58853

--- Comment #7 from Jan Hubicka <hubicka at ucw dot cz> ---
> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
> index 53e04c4..dd8d943 100644
> --- a/gcc/config/i386/i386.c
> +++ b/gcc/config/i386/i386.c
> @@ -23766,6 +23766,7 @@ ix86_expand_set_or_movmem (rtx dst, rtx src, rtx
> count_exp, rtx 
> val_exp,
>       also avoids redundant job when sizes are known precisely.  */
>    misaligned_prologue_used = (TARGET_MISALIGNED_MOVE_STRING_PROLOGUES
>                    && MAX (desired_align, epilogue_size_needed) <= 32
> +                  && desired_align <= epilogue_size_needed
>                    && ((desired_align > align && !align_bytes)
>                    || (!count && epilogue_size_needed > 1)));
> 
> avoids crash.

Yes, we can add this, too, for correctness with manual changes to tunning flags
(so the patch is approved).
What confuses me is why TARGET_MISALIGNED_MOVE_STRING_PROLOGUES seems to be
true
given that

DEF_TUNE (TARGET_MISALIGNED_MOVE_STRING_PROLOGUES,
          "misaligned_move_string_prologues",
          m_386 | m_486 | m_CORE_ALL | m_AMD_MULTIPLE | m_GENERIC)

and we tune for pentiumpro (that was intentionally left out for this purpose)

Honza