public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tejohnson at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/58862] [4.9 Regression] LTO profiledbootstrap failure: lto1: ICE in edge_badness, at ipa-inline.c:1008
Date: Tue, 29 Oct 2013 15:05:00 -0000	[thread overview]
Message-ID: <bug-58862-4-4aHyV24gtK@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-58862-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58862

Teresa Johnson <tejohnson at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tejohnson at gcc dot gnu.org,
                   |                            |tejohnson at google dot com

--- Comment #3 from Teresa Johnson <tejohnson at google dot com> ---
I hit the "verify_flow_info: Wrong probability of edge" error in a
profiledbootstrap. I triaged this down to the following commit, made by me:

------------------------------------------------------------------------
r203823 | tejohnson | 2013-10-18 07:36:53 -0700 (Fri, 18 Oct 2013) | 5 lines
Changed paths:
   M /trunk/gcc/ChangeLog
   M /trunk/gcc/tree-ssa-tail-merge.c

2013-10-18  Teresa Johnson  <tejohnson@google.com>

        * tree-ssa-tail-merge.c (replace_block_by): Update edge
        weights during merging.

------------------------------------------------------------------------

Investigating right now. Looks like there were profile weight insanities going
into this code, that were magnified by the fixes being performed by my change.
To avoid the error, I need to adjust the change I made to ensure that the
profile insanities don't get propagated into the edge probabilities.

In the case I looked at, the edge weight insanities were originally introduced 
during jump threading. I had previously made a fix to the profile updates being
done by that optimization (r203041, committed by law), but there have been a
number of changes to that code since then so this needs to be revisited.

I will get a fix for the failure though hopefully today.

Thanks,
Teresa


  parent reply	other threads:[~2013-10-29 15:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24 13:13 [Bug ipa/58862] New: " ubizjak at gmail dot com
2013-10-24 13:18 ` [Bug ipa/58862] " ubizjak at gmail dot com
2013-10-24 13:41 ` [Bug ipa/58862] [4.9 Regression] " rguenth at gcc dot gnu.org
2013-10-29 15:05 ` tejohnson at google dot com [this message]
2013-10-29 16:33 ` tejohnson at google dot com
2013-10-29 20:39 ` tejohnson at gcc dot gnu.org
2013-10-30 13:10 ` tejohnson at google dot com
2013-10-30 13:17 ` paulo@matos-sorge.com
2013-11-01 17:01 ` paulo@matos-sorge.com
2013-11-01 17:14 ` tejohnson at google dot com
2013-11-01 17:16 ` ubizjak at gmail dot com
2013-11-02 11:40 ` ubizjak at gmail dot com
2013-11-04 19:11 ` tejohnson at google dot com
2013-11-04 19:12 ` tejohnson at google dot com
2013-11-04 19:13 ` tejohnson at google dot com
2013-11-12 15:49 ` tejohnson at google dot com
2013-11-12 19:00 ` ubizjak at gmail dot com
2013-11-13 21:49 ` tejohnson at gcc dot gnu.org
2013-11-13 21:51 ` tejohnson at gcc dot gnu.org
2013-11-14  7:53 ` ubizjak at gmail dot com
2013-11-26  3:48 ` tejohnson at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-58862-4-4aHyV24gtK@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).