public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug bootstrap/58918] New: [4.9 regression] cilk #includes alloc.h unconditionally, even when not present
@ 2013-10-29 22:38 gerald at pfeifer dot com
2013-10-30 10:21 ` [Bug bootstrap/58918] " rguenth at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: gerald at pfeifer dot com @ 2013-10-29 22:38 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58918
Bug ID: 58918
Summary: [4.9 regression] cilk #includes alloc.h
unconditionally, even when not present
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: bootstrap
Assignee: unassigned at gcc dot gnu.org
Reporter: gerald at pfeifer dot com
/scratch/tmp/gerald/gcc-HEAD/libcilkrts/runtime/config/x86/cilk-abi-vla.c:66:21:
fatal error: alloca.h: No such file or directory
# include <alloca.h>
on amd64-unknown-freebsd8.2 and, I assume, several other non-GNU
platforms.
/usr/include/stdlib.h has alloca on those platforms.
Perhaps __builtin_alloca could be another option?
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug bootstrap/58918] [4.9 regression] cilk #includes alloc.h unconditionally, even when not present
2013-10-29 22:38 [Bug bootstrap/58918] New: [4.9 regression] cilk #includes alloc.h unconditionally, even when not present gerald at pfeifer dot com
@ 2013-10-30 10:21 ` rguenth at gcc dot gnu.org
2013-10-30 16:57 ` joseph at codesourcery dot com
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-10-30 10:21 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58918
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.9.0
--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
XALLOCA
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug bootstrap/58918] [4.9 regression] cilk #includes alloc.h unconditionally, even when not present
2013-10-29 22:38 [Bug bootstrap/58918] New: [4.9 regression] cilk #includes alloc.h unconditionally, even when not present gerald at pfeifer dot com
2013-10-30 10:21 ` [Bug bootstrap/58918] " rguenth at gcc dot gnu.org
@ 2013-10-30 16:57 ` joseph at codesourcery dot com
2013-10-30 17:03 ` law at redhat dot com
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: joseph at codesourcery dot com @ 2013-10-30 16:57 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58918
--- Comment #2 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
XALLOCA is a libiberty macro, target libraries shouldn't be using
libiberty headers.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug bootstrap/58918] [4.9 regression] cilk #includes alloc.h unconditionally, even when not present
2013-10-29 22:38 [Bug bootstrap/58918] New: [4.9 regression] cilk #includes alloc.h unconditionally, even when not present gerald at pfeifer dot com
2013-10-30 10:21 ` [Bug bootstrap/58918] " rguenth at gcc dot gnu.org
2013-10-30 16:57 ` joseph at codesourcery dot com
@ 2013-10-30 17:03 ` law at redhat dot com
2013-10-30 22:51 ` bviyer at gcc dot gnu.org
2013-11-19 10:39 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: law at redhat dot com @ 2013-10-30 17:03 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58918
Jeffrey A. Law <law at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |law at redhat dot com
Assignee|unassigned at gcc dot gnu.org |bviyer at gmail dot com
--- Comment #3 from Jeffrey A. Law <law at redhat dot com> ---
I think the include ought to be wrapped inside an #ifdef HAVE_ALLOCA_H. That's
the core issue here -- some systems simply don't have alloca.h. So test for it
and only include it if it exists.
I agree with Joseph that XALLOCA isn't appropriate here. Even more so as GCC
is a downstream user of this library, so adding that kind of dependency simply
isn't going to fly.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug bootstrap/58918] [4.9 regression] cilk #includes alloc.h unconditionally, even when not present
2013-10-29 22:38 [Bug bootstrap/58918] New: [4.9 regression] cilk #includes alloc.h unconditionally, even when not present gerald at pfeifer dot com
` (2 preceding siblings ...)
2013-10-30 17:03 ` law at redhat dot com
@ 2013-10-30 22:51 ` bviyer at gcc dot gnu.org
2013-11-19 10:39 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: bviyer at gcc dot gnu.org @ 2013-10-30 22:51 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58918
--- Comment #4 from bviyer at gcc dot gnu.org ---
Author: bviyer
Date: Wed Oct 30 22:51:29 2013
New Revision: 204232
URL: http://gcc.gnu.org/viewcvs?rev=204232&root=gcc&view=rev
Log:
Fix for bug Bootstrap/58918.
+2013-10-30 Balaji V. Iyer <balaji.v.iyer@intel.com>
+
+ * configure: Reconfigured.
+ * configure.ac: Add AC_FUNC_ALLOCA.
+ * runtime/sysdep-unix.c: Added check for alloca.h before
+ including it.
+ * config/x86/cilk-abi-vla.c: Likewise.
+ * runtime/cilk_fiber-unix.cpp: Likewise.
+
Modified:
trunk/libcilkrts/ChangeLog
trunk/libcilkrts/Makefile.in
trunk/libcilkrts/configure
trunk/libcilkrts/configure.ac
trunk/libcilkrts/runtime/cilk_fiber-unix.cpp
trunk/libcilkrts/runtime/config/x86/cilk-abi-vla.c
trunk/libcilkrts/runtime/sysdep-unix.c
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug bootstrap/58918] [4.9 regression] cilk #includes alloc.h unconditionally, even when not present
2013-10-29 22:38 [Bug bootstrap/58918] New: [4.9 regression] cilk #includes alloc.h unconditionally, even when not present gerald at pfeifer dot com
` (3 preceding siblings ...)
2013-10-30 22:51 ` bviyer at gcc dot gnu.org
@ 2013-11-19 10:39 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-11-19 10:39 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58918
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed I assume.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-19 10:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-29 22:38 [Bug bootstrap/58918] New: [4.9 regression] cilk #includes alloc.h unconditionally, even when not present gerald at pfeifer dot com
2013-10-30 10:21 ` [Bug bootstrap/58918] " rguenth at gcc dot gnu.org
2013-10-30 16:57 ` joseph at codesourcery dot com
2013-10-30 17:03 ` law at redhat dot com
2013-10-30 22:51 ` bviyer at gcc dot gnu.org
2013-11-19 10:39 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).