[Bug libstdc++/58962] New: Pretty printers use obsolete Python syntax

[Bug libstdc++/58962] New: Pretty printers use obsolete Python syntax

[bmerry at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58962

            Bug ID: 58962
           Summary: Pretty printers use obsolete Python syntax
           Product: gcc
           Version: 4.8.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: bmerry at gmail dot com

Created attachment 31135
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=31135&action=edit
Patch to update raise statements to modern Python syntax

The pretty printers shipped with GCC 4.8.1 use the obsolete

raise ExceptionClass, argument

format for raising exceptions. Modern Python (not sure when it was introduced,
but the Python 2.6 docs seems to support it so it has been around for a while)
instead uses

raise ExceptionClass(arguments...)

and the old form is not supported in Python 3. The result is that when I try to
load the pretty printers via .gdbinit in Ubuntu 13.10, I get this message:

Traceback (most recent call last):
  File "<string>", line 3, in <module>
  File "/usr/share/gcc-4.8/python/libstdcxx/v6/printers.py", line 54
    raise ValueError, "Cannot find type %s::%s" % (str(orig), name)
                    ^
SyntaxError: invalid syntax
/home/bruce/.gdbinit:7: Error in sourced command file:
Error while executing Python code.

I've attached a patch which changes the raise statements to use the new syntax.
It's against the version shipped with Ubuntu 13.10 in libstdc++6-4.8-dbg; I
haven't checked whether Ubuntu have added their own patches.

[Bug libstdc++/58962] Pretty printers use obsolete Python syntax

[bmerry at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58962

--- Comment #1 from Bruce Merry <bmerry at gmail dot com> ---
I've now realised that this is actually just the tip of the iceberg - I suspect
that libstdc++'s pretty printers aren't Python 3 ready, while Ubuntu is
shipping a gdb linked to libython 3.3. Feel free to close if this is as
expected.

[Bug libstdc++/58962] Pretty printers use obsolete Python syntax

[gonzalo.bonigo at tallertechnologies dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58962

GonzaloBonigo <gonzalo.bonigo at tallertechnologies dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gonzalo.bonigo@tallertechno
                   |                            |logies.com

--- Comment #2 from GonzaloBonigo <gonzalo.bonigo at tallertechnologies dot com> ---
Please, assign it to me.

[Bug libstdc++/58962] Pretty printers use obsolete Python syntax

[daniel.gutson at tallertechnologies dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58962

--- Comment #3 from Daniel Gutson <daniel.gutson at tallertechnologies dot com> ---
Please do not close this issue.(In reply to Bruce Merry from comment #1)
> I've now realised that this is actually just the tip of the iceberg - I
> suspect that libstdc++'s pretty printers aren't Python 3 ready, while Ubuntu
> is shipping a gdb linked to libython 3.3. Feel free to close if this is as
> expected.

Please don't close this issue, it is completely relevant since not only for
ubuntu but for other distros too.

Syntax should work both with python versions 2 and 3 at ever possible.

[Bug libstdc++/58962] Pretty printers use obsolete Python syntax

[bmerry at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58962

--- Comment #4 from Bruce Merry <bmerry at gmail dot com> ---
Incidentally, the workaround I have been using is to just run the script
through 2to3. Since Python only tells you things have gone wrong when you
execute the code I can't guarantee that this fixes everything, but I've yet to
hit any further Python 2 vs 3 issues after doing this.

[Bug libstdc++/58962] Pretty printers use obsolete Python syntax

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58962

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Fri Jul 11 13:43:07 2014
New Revision: 212453

URL: https://gcc.gnu.org/viewcvs?rev=212453&root=gcc&view=rev
Log:
2014-07-11  Samuel Bronson  <naesten@gmail.com>
        Matthias Klose  <doko@ubuntu.com>

    PR libstdc++/58962
    * python/libstdcxx/v6/printers.py: Port to Python 2+3
    (imap): New compat function.
    (izip): Likewise.
    (Iterator): New mixin to allow writing iterators in Python 3 style
    regardless of which version we're running on.
    [Python3] (long) New compat alias for "int".
    * testsuite/lib/gdb-test.exp: Port to Python 2+3 (print syntax)

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/python/libstdcxx/v6/printers.py
    trunk/libstdc++-v3/testsuite/lib/gdb-test.exp

[Bug libstdc++/58962] Pretty printers use obsolete Python syntax

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58962

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.10.0

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The trunk version of the printers should now work with both Python 2 and 3

[Bug libstdc++/58962] Pretty printers use obsolete Python syntax

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58962

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Mon Aug  4 18:50:30 2014
New Revision: 213604

URL: https://gcc.gnu.org/viewcvs?rev=213604&root=gcc&view=rev
Log:
2014-08-04  Samuel Bronson  <naesten@gmail.com>

    Backport r212453 from trunk
    2014-07-11  Samuel Bronson  <naesten@gmail.com>
            Matthias Klose  <doko@ubuntu.com>

    PR libstdc++/58962
    * python/libstdcxx/v6/printers.py: Port to Python 2+3
    (imap): New compat function.
    (izip): Likewise.
    (Iterator): New mixin to allow writing iterators in Python 3 style
    regardless of which version we're running on.
    [Python3] (long) New compat alias for "int".
    * testsuite/lib/gdb-test.exp: Port to Python 2+3 (print syntax)

    Backport r210625 from trunk
    2014-05-19  Jonathan Wakely  <jwakely@redhat.com>

    * python/libstdcxx/v6/printers.py: Use Python3 raise syntax.

Modified:
    branches/gcc-4_9-branch/libstdc++-v3/ChangeLog
    branches/gcc-4_9-branch/libstdc++-v3/python/libstdcxx/v6/printers.py
    branches/gcc-4_9-branch/libstdc++-v3/testsuite/lib/gdb-test.exp

[Bug libstdc++/58962] Pretty printers use obsolete Python syntax

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58962

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.10.0                      |4.9.2

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
backported for 4.9.2

[Bug libstdc++/58962] Pretty printers use obsolete Python syntax

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58962

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Thu Aug 28 16:22:21 2014
New Revision: 214682

URL: https://gcc.gnu.org/viewcvs?rev=214682&root=gcc&view=rev
Log:
2014-08-28  Samuel Bronson  <naesten@gmail.com>

    Backport r212453 from trunk
    2014-07-11  Samuel Bronson  <naesten@gmail.com>
            Matthias Klose  <doko@ubuntu.com>

    PR libstdc++/58962
    * python/libstdcxx/v6/printers.py: Port to Python 2+3
    (imap): New compat function.
    (izip): Likewise.
    (Iterator): New mixin to allow writing iterators in Python 3 style
    regardless of which version we're running on.
    [Python3] (long) New compat alias for "int".
    * testsuite/lib/gdb-test.exp: Port to Python 2+3 (print syntax)

    Backport r210625 from trunk
    2014-05-19  Jonathan Wakely  <jwakely@redhat.com>

    * python/libstdcxx/v6/printers.py: Use Python3 raise syntax.

Modified:
    branches/gcc-4_8-branch/libstdc++-v3/ChangeLog
    branches/gcc-4_8-branch/libstdc++-v3/python/libstdcxx/v6/printers.py
    branches/gcc-4_8-branch/libstdc++-v3/testsuite/lib/gdb-test.exp

[Bug libstdc++/58962] Pretty printers use obsolete Python syntax

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58962

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.2                       |4.8.4