[Bug sanitizer/59009] New: libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[Bug sanitizer/59009] New: libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[bergner at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

            Bug ID: 59009
           Summary: libsanitizer merge from upstream r191666 breaks
                    bootstrap on powerpc64-linux
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: bergner at gcc dot gnu.org
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org

The recent merge of upstream libsanitizer broke bootstrap on powerpc64-linux
with:

In file included from
/home/bergner/gcc/gcc-fsf-mainline-base/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:21:0:
/usr/include/asm/stat.h:31:2: error: ‘ino_t’ does not name a type
  ino_t  st_ino;
  ^
/usr/include/asm/stat.h:33:2: error: ‘nlink_t’ does not name a type
  nlink_t  st_nlink;
  ^
/usr/include/asm/stat.h:34:2: error: ‘mode_t’ does not name a type
  mode_t  st_mode;
  ^
/usr/include/asm/stat.h:39:2: error: ‘uid_t’ does not name a type
  uid_t  st_uid;
  ^
/usr/include/asm/stat.h:40:2: error: ‘gid_t’ does not name a type
  gid_t  st_gid;
  ^
/usr/include/asm/stat.h:42:2: error: ‘off_t’ does not name a type
  off_t  st_size;
  ^
/home/bergner/gcc/gcc-fsf-mainline-base/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:29:73:
error: invalid application of ‘sizeof’ to incomplete type
‘__sanitizer::__old_kernel_stat’
   unsigned struct___old_kernel_stat_sz = sizeof(struct __old_kernel_stat);
                                                                         ^
make[4]: *** [sanitizer_platform_limits_linux.lo] Error 1

Even if we were to resolve the missing types, the PPC64 kernel does not define
a "struct __old_kernel_stat", because it never had one.  What is libsanitizer
even doing with the __old_kernel_stat?  We switched away from the old kernel
stat ages ago, so I can't believe we're trying to support running on the
ancient kernels.
>From gcc-bugs-return-433647-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Nov 05 18:49:08 2013
Return-Path: <gcc-bugs-return-433647-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 23566 invoked by alias); 5 Nov 2013 18:49:07 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 20895 invoked by uid 48); 5 Nov 2013 18:47:05 -0000
From: "benlynn at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/59010] New: ICE in make_Decl_
Date: Tue, 05 Nov 2013 18:49:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: benlynn at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-59010-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-11/txt/msg00424.txt.bz2
Content-length: 365

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY010

            Bug ID: 59010
           Summary: ICE in make_Decl_
           Product: gcc
           Version: 4.8.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: benlynn at gmail dot com

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build
           Priority|P3                          |P1

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[eugeni.stepanov at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #2 from Evgeniy Stepanov <eugeni.stepanov at gmail dot com> ---
As discussed in a email thread on gcc-patches, we will probably move away from
including kernel headers and just define all the types in our code.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[mikpelinux at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

Mikael Pettersson <mikpelinux at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikpelinux at gmail dot com

--- Comment #3 from Mikael Pettersson <mikpelinux at gmail dot com> ---
Bootstrap of gcc-4.9-20131110 on sparc64-linux is also broken in the same way.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[meissner at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

Michael Meissner <meissner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |meissner at gcc dot gnu.org

--- Comment #4 from Michael Meissner <meissner at gcc dot gnu.org> ---
It has been a week since you broke the build for powerpc64 and other targets. 
Please immediately revert these patches to allow the ports to build while you
work on patches that will not break on the major host/targets.

Quoting from the GCC development plan.

If a patch is committed which introduces a regression on any target which the
Steering Committee considers to be important and if:

the problem is reported to the original poster;
48 hours pass without the original poster or any other party indicating that a
fix will be forthcoming in the very near future;
two people with write privileges to the affected area of the compiler determine
that the best course of action is to revert the patch;
then they may revert the patch.

(The list of important targets will be revised at the beginning of each release
cycle, if necessary, and is part of the release criteria.)

After the patch has been reverted, the poster may appeal the decision to the
Steering Committee.

Note that no distinction is made between patches which are themselves buggy and
patches that expose latent bugs elsewhere in the compiler.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[kcc at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #5 from Kostya Serebryany <kcc at gcc dot gnu.org> ---
So far we were not even able to reproduce it. 
As I told in another thread, please apply any minimal #ifdef patch to 
sanitizer_platform_limits_linux.cc to make it compile (while keeping tests
running on x86_86).

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[mikpelinux at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #6 from Mikael Pettersson <mikpelinux at gmail dot com> ---
(In reply to Kostya Serebryany from comment #5)
> So far we were not even able to reproduce it. 

Building gcc trunk as a cross to ppc64-linux reproduces the build failure for
me.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[kcc at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #7 from Kostya Serebryany <kcc at gcc dot gnu.org> ---
Is this fixed by  http://gcc.gnu.org/viewcvs?rev=204726&root=gcc&view=rev ?

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[bergner at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #9 from Peter Bergner <bergner at gcc dot gnu.org> ---
I'm testing a fix for the left over failures.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[meissner at linux dot vnet.ibm.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #10 from Michael Meissner <meissner at linux dot vnet.ibm.com> ---
On Wed, Nov 13, 2013 at 06:03:50AM +0000, kcc at gcc dot gnu.org wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009
> 
> --- Comment #7 from Kostya Serebryany <kcc at gcc dot gnu.org> ---
> Is this fixed by  http://gcc.gnu.org/viewcvs?rev=204726&root=gcc&view=rev ?

No, other patches are needed as communicated in the other threads on this.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Peter Bergner from comment #11)
> This patch seem to have fixed the last of the powerpc64-linux build failures:
> 
> Index: libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc
> ===================================================================
> --- libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc
> (revision 204747)
> +++ libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc
> (working copy)
> @@ -855,6 +855,7 @@ CHECK_STRUCT_SIZE_AND_OFFSET(sigaction, 
>  CHECK_STRUCT_SIZE_AND_OFFSET(sigaction, sa_restorer);
>  #endif
>  
> +#ifdef SYSCALL_INTERCEPTION
>  #if SANITIZER_LINUX
>  CHECK_TYPE_SIZE(__sysctl_args);
>  CHECK_SIZE_AND_OFFSET(__sysctl_args, name);
> @@ -872,6 +873,7 @@ CHECK_TYPE_SIZE(__kernel_off_t);
>  CHECK_TYPE_SIZE(__kernel_loff_t);
>  CHECK_TYPE_SIZE(__kernel_fd_set);
>  #endif
> +#endif
>  
>  #if !SANITIZER_ANDROID
>  CHECK_TYPE_SIZE(wordexp_t);

If it compiles/links and you don't get new undefined symbols from libasan, then
I guess it should work (of course, please do make check to verify).  If Kostya
doesn't have anything against it and testing looks good, please write a
ChangeLog and check it in.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[kcc at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #13 from Kostya Serebryany <kcc at gcc dot gnu.org> ---
No objections, thanks!

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[bergner at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #14 from Peter Bergner <bergner at gcc dot gnu.org> ---
Author: bergner
Date: Wed Nov 13 22:34:33 2013
New Revision: 204757

URL: http://gcc.gnu.org/viewcvs?rev=204757&root=gcc&view=rev
Log:
    PR sanitizer/59009
    * sanitizer_common/sanitizer_platform_limits_posix.cc: Temporarily
    ifdef out more source.

Modified:
    trunk/libsanitizer/ChangeLog
    trunk/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #15 from dave.anglin at bell dot net ---
As of revision 204772, there are still problems on hppa-linux.

libtool: compile:  /home/dave/gnu/gcc/objdir/./gcc/xgcc -shared-libgcc  
-B/home/dave/gnu/gcc/objdir/./gcc -nostdinc++ -L/home/dave/gnu/gcc/ 
objdir/hppa-linux-gnu/libstdc++-v3/src -L/home/dave/gnu/gcc/objdir/ 
hppa-linux-gnu/libstdc++-v3/src/.libs -L/home/dave/gnu/gcc/objdir/hppa- 
linux-gnu/libstdc++-v3/libsupc++/.libs -B/home/dave/opt/gnu/gcc/ 
gcc-4.9/hppa-linux-gnu/bin/ -B/home/dave/opt/gnu/gcc/gcc-4.9/hppa- 
linux-gnu/lib/ -isystem /home/dave/opt/gnu/gcc/gcc-4.9/hppa-linux-gnu/ 
include -isystem /home/dave/opt/gnu/gcc/gcc-4.9/hppa-linux-gnu/sys- 
include -D_GNU_SOURCE -D_DEBUG -D__STDC_CONSTANT_MACROS - 
D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I. -I../../../../gcc/ 
libsanitizer/sanitizer_common -I ../../../../gcc/libsanitizer/include - 
Wall -W -Wno-unused-parameter -Wwrite-strings -pedantic -Wno-long-long  
-fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind- 
tables -fvisibility=hidden -Wno-variadic-macros -I../../libstdc++-v3/ 
include -I../../libstdc++-v3/include/hppa-linux-gnu -I../../../../gcc/ 
libsanitizer/../libstdc++-v3/libsupc++ -g -O2 -D_GNU_SOURCE -MT  
sanitizer_linux.lo -MD -MP -MF .deps/sanitizer_linux.Tpo - 
c ../../../../gcc/libsanitizer/sanitizer_common/sanitizer_linux.cc -o  
sanitizer_linux.o >/dev/null 2>&1
In file included from ../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_platform_limits_posix.cc:17:0:
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_internal_defs.h:247:72: error: size of array  
‘assertion_failed__849’ is negative
      typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int) 
(pred)-1]
                                                                         ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_internal_defs.h:241:30: note: in expansion of macro  
‘IMPL_COMPILER_ASSERT’
  #define COMPILER_CHECK(pred) IMPL_COMPILER_ASSERT(pred, __LINE__)
                               ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_platform_limits_posix.cc:849:1: note: in expansion of macro  
‘COMPILER_CHECK’
  COMPILER_CHECK(sizeof(__sanitizer_sigaction) == sizeof(struct  
sigaction));
  ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_internal_defs.h:247:72: error: size of array  
‘assertion_failed__852’ is negative
      typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int) 
(pred)-1]
                                                                         ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_internal_defs.h:241:30: note: in expansion of macro  
‘IMPL_COMPILER_ASSERT’
  #define COMPILER_CHECK(pred) IMPL_COMPILER_ASSERT(pred, __LINE__)
                               ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_platform_limits_posix.cc:752:3: note: in expansion of macro  
‘COMPILER_CHECK’
    COMPILER_CHECK(offsetof(struct __sanitizer_##CLASS, MEMBER)  
==          \
    ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_platform_limits_posix.cc:852:1: note: in expansion of macro  
‘CHECK_STRUCT_SIZE_AND_OFFSET’
  CHECK_STRUCT_SIZE_AND_OFFSET(sigaction, sa_mask);
  ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_internal_defs.h:247:72: error: size of array  
‘assertion_failed__853’ is negative
      typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int) 
(pred)-1]
                                                                         ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_internal_defs.h:241:30: note: in expansion of macro  
‘IMPL_COMPILER_ASSERT’
  #define COMPILER_CHECK(pred) IMPL_COMPILER_ASSERT(pred, __LINE__)
                               ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_platform_limits_posix.cc:752:3: note: in expansion of macro  
‘COMPILER_CHECK’
    COMPILER_CHECK(offsetof(struct __sanitizer_##CLASS, MEMBER)  
==          \
    ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_platform_limits_posix.cc:853:1: note: in expansion of macro  
‘CHECK_STRUCT_SIZE_AND_OFFSET’
  CHECK_STRUCT_SIZE_AND_OFFSET(sigaction, sa_flags);
  ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_platform_limits_posix.cc:855:41: error: ‘struct sigaction’  
has no member named ‘sa_restorer’
  CHECK_STRUCT_SIZE_AND_OFFSET(sigaction, sa_restorer);
                                          ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_internal_defs.h:247:65: note: in definition of macro  
‘IMPL_COMPILER_ASSERT’
      typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int) 
(pred)-1]
                                                                  ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_platform_limits_posix.cc:750:3: note: in expansion of macro  
‘COMPILER_CHECK’
    COMPILER_CHECK(sizeof(((struct __sanitizer_##CLASS *) NULL)- 
 >MEMBER) == \
    ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_platform_limits_posix.cc:855:1: note: in expansion of macro  
‘CHECK_STRUCT_SIZE_AND_OFFSET’
  CHECK_STRUCT_SIZE_AND_OFFSET(sigaction, sa_restorer);
  ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_platform_limits_posix.cc:855:41: error: ‘struct sigaction’  
has no member named ‘sa_restorer’
  CHECK_STRUCT_SIZE_AND_OFFSET(sigaction, sa_restorer);
                                          ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_internal_defs.h:247:65: note: in definition of macro  
‘IMPL_COMPILER_ASSERT’
      typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int) 
(pred)-1]
                                                                  ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_platform_limits_posix.cc:752:3: note: in expansion of macro  
‘COMPILER_CHECK’
    COMPILER_CHECK(offsetof(struct __sanitizer_##CLASS, MEMBER)  
==          \
    ^
../../../../gcc/libsanitizer/sanitizer_common/ 
sanitizer_platform_limits_posix.cc:855:1: note: in expansion of macro  
‘CHECK_STRUCT_SIZE_AND_OFFSET’
  CHECK_STRUCT_SIZE_AND_OFFSET(sigaction, sa_restorer);
  ^
make[4]: *** [sanitizer_platform_limits_posix.lo] Error 1


--
John David Anglin    dave.anglin@bell.net
>From gcc-bugs-return-434548-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Nov 14 05:09:36 2013
Return-Path: <gcc-bugs-return-434548-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 6578 invoked by alias); 14 Nov 2013 05:09:35 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 6541 invoked by uid 48); 14 Nov 2013 05:09:30 -0000
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/58963] Does C++ need flag_complex_method = 2?
Date: Thu, 14 Nov 2013 05:09:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pinskia at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-58963-4-m1Lz7Ls6LW@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58963-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58963-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-11/txt/msg01325.txt.bz2
Content-length: 523

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX963

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The real answer is yes C++ needs it. see
http://gcc.gnu.org/ml/gcc/2007-07/msg00124.html and PR 30482.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[bergner at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #16 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to dave.anglin from comment #15)
> As of revision 204772, there are still problems on hppa-linux.

Does the following patch fix them?  I don't know whether it creates more
problems than it solves, but worth a try.  I'll try on powerpc64-linux to see
if it breaks anything for us.


Index: sanitizer_common/sanitizer_platform_limits_posix.cc
===================================================================
--- sanitizer_common/sanitizer_platform_limits_posix.cc    (revision 204792)
+++ sanitizer_common/sanitizer_platform_limits_posix.cc    (working copy)
@@ -846,6 +846,7 @@ CHECK_TYPE_SIZE(nfds_t);

 CHECK_TYPE_SIZE(sigset_t);

+#ifdef SYSCALL_INTERCEPTION
 COMPILER_CHECK(sizeof(__sanitizer_sigaction) == sizeof(struct sigaction));
 // Can't write checks for sa_handler and sa_sigaction due to them being
 // preprocessor macros.
@@ -855,7 +856,6 @@ CHECK_STRUCT_SIZE_AND_OFFSET(sigaction, 
 CHECK_STRUCT_SIZE_AND_OFFSET(sigaction, sa_restorer);
 #endif

-#ifdef SYSCALL_INTERCEPTION
 #if SANITIZER_LINUX
 CHECK_TYPE_SIZE(__sysctl_args);
 CHECK_SIZE_AND_OFFSET(__sysctl_args, name);

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[bergner at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #17 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Peter Bergner from comment #16)
> (In reply to dave.anglin from comment #15)
> > As of revision 204772, there are still problems on hppa-linux.
> 
> Does the following patch fix them?  I don't know whether it creates more
> problems than it solves, but worth a try.  I'll try on powerpc64-linux to
> see if it breaks anything for us.

This survived bootstrap and regtesting on powerpc64-linux and did not introduce
any undefined symbol error in the testsuite.

Dave, can you try this patch to see if it cleans up the errors you're seeing?

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #18 from dave.anglin at bell dot net ---
On 11/14/2013 12:26 PM, bergner at gcc dot gnu.org wrote:
> Dave, can you try this patch to see if it cleans up the errors you're seeing?
I will try it later today when I get home.

Dave

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[bergner at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #19 from Peter Bergner <bergner at gcc dot gnu.org> ---
Someone on my team reported that our internal bootstrap tester is still
failing.  It is failing due to the linux/mroute6.h header file not existing. 
Our builds are occurring on SLES10 and RHEL5 and that kernel header didn't
exist yet when SLES10/RHEL5 were released.  I'm going to fire off my own build
on them and see if I can work around them commenting more code out.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #20 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
If I remove the
#include <linux/mroute6.h>
it still compiles just fine here on Fedora 19, looks like only the
linux/mroute.h
ioctls are instrumented.
Anyway, sounds to me like this badly needs autoconf and HAVE_LINUX_MROUTE6_H
etc.
for headers which aren't available everywhere.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #21 from dave.anglin at bell dot net ---
On 14-Nov-13, at 12:26 PM, bergner at gcc dot gnu.org wrote:

> Dave, can you try this patch to see if it cleans up the errors  
> you're seeing?

Patch cleans up the errors.

Dave
--
John David Anglin    dave.anglin@bell.net

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #22 from John David Anglin <danglin at gcc dot gnu.org> ---
New errors have have appeared on hppa-linux:

In file included from
../../../../gcc/libsanitizer/sanitizer_common/sanitizer_pl
atform_limits_linux.cc:40:0:
/usr/include/hppa-linux-gnu/asm/stat.h:15:2: error: ‘time_t’ does not name a
typ
e
  time_t  st_atime;
  ^
/usr/include/hppa-linux-gnu/asm/stat.h:17:2: error: ‘time_t’ does not name a
typ
e
  time_t  st_mtime;
  ^
/usr/include/hppa-linux-gnu/asm/stat.h:19:2: error: ‘time_t’ does not name a
type
  time_t  st_ctime;
  ^
/usr/include/hppa-linux-gnu/asm/stat.h:50:2: error: ‘time_t’ does not name a
type
  time_t  st_atime;
  ^
/usr/include/hppa-linux-gnu/asm/stat.h:52:2: error: ‘time_t’ does not name a
type
  time_t  st_mtime;
  ^
/usr/include/hppa-linux-gnu/asm/stat.h:54:2: error: ‘time_t’ does not name a
type
  time_t  st_ctime;
  ^
In file included from
../../../../gcc/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:20:0:
../../../../gcc/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:66:16:
error: ‘struct___old_kernel_stat_sz’ was not declared in this scope
 COMPILER_CHECK(struct___old_kernel_stat_sz == sizeof(struct
__old_kernel_stat));
                ^
../../../../gcc/libsanitizer/sanitizer_common/sanitizer_internal_defs.h:257:65:
note: in definition of macro ‘IMPL_COMPILER_ASSERT’
     typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int)(pred)-1]
                                                                 ^
../../../../gcc/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:66:1:
note: in expansion of macro ‘COMPILER_CHECK’
 COMPILER_CHECK(struct___old_kernel_stat_sz == sizeof(struct
__old_kernel_stat));
 ^
../../../../gcc/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:66:78:
error: invalid application of ‘sizeof’ to incomplete type ‘__old_kernel_stat’
 COMPILER_CHECK(struct___old_kernel_stat_sz == sizeof(struct
__old_kernel_stat));
                                                                              ^
../../../../gcc/libsanitizer/sanitizer_common/sanitizer_internal_defs.h:257:65:
note: in definition of macro ‘IMPL_COMPILER_ASSERT’
     typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int)(pred)-1]
                                                                 ^
../../../../gcc/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:66:1:
note: in expansion of macro ‘COMPILER_CHECK’
 COMPILER_CHECK(struct___old_kernel_stat_sz == sizeof(struct
__old_kernel_stat));
 ^
../../../../gcc/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:69:16:
error: ‘struct_kernel_stat_sz’ was not declared in this scope
 COMPILER_CHECK(struct_kernel_stat_sz == sizeof(struct stat));
                ^
../../../../gcc/libsanitizer/sanitizer_common/sanitizer_internal_defs.h:257:65:
note: in definition of macro ‘IMPL_COMPILER_ASSERT’
     typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int)(pred)-1]
                                                                 ^
../../../../gcc/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:69:1:
note: in expansion of macro ‘COMPILER_CHECK’
 COMPILER_CHECK(struct_kernel_stat_sz == sizeof(struct stat));
 ^
make[4]: *** [sanitizer_platform_limits_linux.lo] Error 1

The time_t error is from a kernel header.
>From gcc-bugs-return-436993-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Dec 08 17:41:49 2013
Return-Path: <gcc-bugs-return-436993-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 4825 invoked by alias); 8 Dec 2013 17:41:49 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 4768 invoked by uid 48); 8 Dec 2013 17:41:45 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux
Date: Sun, 08 Dec 2013 17:41:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: sanitizer
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords: build
X-Bugzilla-Severity: blocker
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59009-4-8BLyb6tbk7@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59009-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59009-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg00648.txt.bz2
Content-length: 1672

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY009

--- Comment #23 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
On x86_64-apple-darwin10, bootstrap fails with

libtool: compile:  /opt/gcc/build_w/./gcc/xgcc -shared-libgcc
-B/opt/gcc/build_w/./gcc -nostdinc++
-L/opt/gcc/build_w/x86_64-apple-darwin10.8.0/libstdc++-v3/src
-L/opt/gcc/build_w/x86_64-apple-darwin10.8.0/libstdc++-v3/src/.libs
-L/opt/gcc/build_w/x86_64-apple-darwin10.8.0/libstdc++-v3/libsupc++/.libs
-B/opt/gcc/gcc4.9w/x86_64-apple-darwin10.8.0/bin/
-B/opt/gcc/gcc4.9w/x86_64-apple-darwin10.8.0/lib/ -isystem
/opt/gcc/gcc4.9w/x86_64-apple-darwin10.8.0/include -isystem
/opt/gcc/gcc4.9w/x86_64-apple-darwin10.8.0/sys-include -D_GNU_SOURCE -D_DEBUG
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I.
-I../../../../work/libsanitizer/sanitizer_common -I
../../../../work/libsanitizer/include -Wall -W -Wno-unused-parameter
-Wwrite-strings -pedantic -Wno-long-long -fPIC -fno-builtin -fno-exceptions
-fno-rtti -fomit-frame-pointer -funwind-tables -fvisibility=hidden
-Wno-variadic-macros -I../../libstdc++-v3/include
-I../../libstdc++-v3/include/x86_64-apple-darwin10.8.0
-I../../../../work/libsanitizer/../libstdc++-v3/libsupc++ -g -O2 -MT
sanitizer_posix_libcdep.lo -MD -MP -MF .deps/sanitizer_posix_libcdep.Tpo -c
../../../../work/libsanitizer/sanitizer_common/sanitizer_posix_libcdep.cc
-fno-common -DPIC -o .libs/sanitizer_posix_libcdep.o
../../../../work/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc:763:39:
error: 'EOWNERDEAD' was not declared in this scope
   extern const int errno_EOWNERDEAD = EOWNERDEAD;

but succeeds on x86_64-apple-darwin13.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[kcc at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #24 from Kostya Serebryany <kcc at gcc dot gnu.org> ---

> sanitizer_platform_limits_posix.cc:763:39: error: 'EOWNERDEAD' was not

We see this bug ourselves, the fix is under review upstream.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #25 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> > sanitizer_platform_limits_posix.cc:763:39: error: 'EOWNERDEAD' was not
>
> We see this bug ourselves, the fix is under review upstream.

Would it be possible to post the fix? TIA.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[kcc at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #26 from Kostya Serebryany <kcc at gcc dot gnu.org> ---
> Would it be possible to post the fix? TIA.
Committed upstream as http://llvm.org/viewvc/llvm-project?rev=196779&view=rev
Feel free to commit the exact same change to gcc
or wait for the next merge (will try this week, but no promises)

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #27 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> > Would it be possible to post the fix? TIA.
> Committed upstream as http://llvm.org/viewvc/llvm-project?rev=196779&view=rev
> Feel free to commit the exact same change to gcc
> or wait for the next merge (will try this week, but no promises)

Thanks for the pointer, it allowed to bootstrap r205803.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #28 from John David Anglin <danglin at gcc dot gnu.org> ---
Bootstrap is also broken on fairly old arm box:

libtool: compile:  /home/dave/gnu/gcc/objdir/./gcc/xgcc -shared-libgcc
-B/home/d
ave/gnu/gcc/objdir/./gcc -nostdinc++
-L/home/dave/gnu/gcc/objdir/armv5tejl-unkno
wn-linux-gnueabi/libstdc++-v3/src
-L/home/dave/gnu/gcc/objdir/armv5tejl-unknown-
linux-gnueabi/libstdc++-v3/src/.libs
-L/home/dave/gnu/gcc/objdir/armv5tejl-unkno
wn-linux-gnueabi/libstdc++-v3/libsupc++/.libs
-B/home/dave/opt/gnu/gcc/gcc-4.9/a
rmv5tejl-unknown-linux-gnueabi/bin/
-B/home/dave/opt/gnu/gcc/gcc-4.9/armv5tejl-u
nknown-linux-gnueabi/lib/ -isystem
/home/dave/opt/gnu/gcc/gcc-4.9/armv5tejl-unkn
own-linux-gnueabi/include -isystem
/home/dave/opt/gnu/gcc/gcc-4.9/armv5tejl-unkn
own-linux-gnueabi/sys-include -D_GNU_SOURCE -D_DEBUG -D__STDC_CONSTANT_MACROS
-D
__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I.
-I../../../../gcc/libsanitizer/sa
nitizer_common -I ../../../../gcc/libsanitizer/include -Wall -W
-Wno-unused-para
meter -Wwrite-strings -pedantic -Wno-long-long -fPIC -fno-builtin
-fno-exception
s -fno-rtti -fomit-frame-pointer -funwind-tables -fvisibility=hidden
-Wno-variad
ic-macros -I../../libstdc++-v3/include
-I../../libstdc++-v3/include/armv5tejl-unknown-linux-gnueabi
-I../../../../gcc/libsanitizer/../libstdc++-v3/libsupc++ -g -O2 -D_GNU_SOURCE
-MT sanitizer_platform_limits_linux.lo -MD -MP -MF
.deps/sanitizer_platform_limits_linux.Tpo -c
../../../../gcc/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc
 -fPIC -DPIC -o .libs/sanitizer_platform_limits_linux.o
../../../../gcc/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:58:30:
fatal error: linux/perf_event.h: No such file or directory
 #include <linux/perf_event.h>

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #29 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to John David Anglin from comment #28)
> Bootstrap is also broken on fairly old arm box:
> 
> libtool: compile:  /home/dave/gnu/gcc/objdir/./gcc/xgcc -shared-libgcc
> -B/home/d
> ave/gnu/gcc/objdir/./gcc -nostdinc++
> -L/home/dave/gnu/gcc/objdir/armv5tejl-unkno
> wn-linux-gnueabi/libstdc++-v3/src
> -L/home/dave/gnu/gcc/objdir/armv5tejl-unknown-
> linux-gnueabi/libstdc++-v3/src/.libs
> -L/home/dave/gnu/gcc/objdir/armv5tejl-unkno
> wn-linux-gnueabi/libstdc++-v3/libsupc++/.libs
> -B/home/dave/opt/gnu/gcc/gcc-4.9/a
> rmv5tejl-unknown-linux-gnueabi/bin/
> -B/home/dave/opt/gnu/gcc/gcc-4.9/armv5tejl-u
> nknown-linux-gnueabi/lib/ -isystem
> /home/dave/opt/gnu/gcc/gcc-4.9/armv5tejl-unkn
> own-linux-gnueabi/include -isystem
> /home/dave/opt/gnu/gcc/gcc-4.9/armv5tejl-unkn
> own-linux-gnueabi/sys-include -D_GNU_SOURCE -D_DEBUG
> -D__STDC_CONSTANT_MACROS -D
> __STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I.
> -I../../../../gcc/libsanitizer/sa
> nitizer_common -I ../../../../gcc/libsanitizer/include -Wall -W
> -Wno-unused-para
> meter -Wwrite-strings -pedantic -Wno-long-long -fPIC -fno-builtin
> -fno-exception
> s -fno-rtti -fomit-frame-pointer -funwind-tables -fvisibility=hidden
> -Wno-variad
> ic-macros -I../../libstdc++-v3/include
> -I../../libstdc++-v3/include/armv5tejl-unknown-linux-gnueabi
> -I../../../../gcc/libsanitizer/../libstdc++-v3/libsupc++ -g -O2
> -D_GNU_SOURCE -MT sanitizer_platform_limits_linux.lo -MD -MP -MF
> .deps/sanitizer_platform_limits_linux.Tpo -c
> ../../../../gcc/libsanitizer/sanitizer_common/
> sanitizer_platform_limits_linux.cc  -fPIC -DPIC -o
> .libs/sanitizer_platform_limits_linux.o
> ../../../../gcc/libsanitizer/sanitizer_common/
> sanitizer_platform_limits_linux.cc:58:30: fatal error: linux/perf_event.h:
> No such file or directory
>  #include <linux/perf_event.h>

For that a patch has been posted, just not reviewed:
http://gcc.gnu.org/ml/gcc-patches/2013-12/msg00963.html

As for hppa, the change to enable it isn't in upstream GCC, so you as a
maintainer need to make it working first and if changes are needed for
compiler-rt maintained code, make sure it is accepted there first too.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |howarth at nitro dot med.uc.edu

--- Comment #30 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
*** Bug 59456 has been marked as a duplicate of this bug. ***

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #31 from dave.anglin at bell dot net ---
On 12/10/2013 11:49 AM, jakub at gcc dot gnu.org wrote:
> For that a patch has been posted, just not reviewed:
> http://gcc.gnu.org/ml/gcc-patches/2013-12/msg00963.html
Excellent.
>
> As for hppa, the change to enable it isn't in upstream GCC, so you as a
> maintainer need to make it working first and if changes are needed for
> compiler-rt maintained code, make sure it is accepted there first too.
I'm fully aware that the change to enable isn't upstream.  I'm still 
debating in my mind whether
this should be done or not.  At the moment, there are no additional 
changes to the compiler-rt
code as far as I know. However, things seem fragile and possibly this 
library is unsuitable for
an architecture that is only supported by Gentoo and Debian unstable 
Linux ports.

I'm not sure what the issue is with the hppa kernel typedef for time_t.  
It seems defined by the
generic linux type definitions.  If this needs to be changed for 
libsanitizer, I would like to
understand why.  As far as I can tell, hppa isn't unique in using time_t 
in uapi/asm/stat.h
although the majority of ports only use base types.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #32 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> > > Would it be possible to post the fix? TIA.
> > Committed upstream as http://llvm.org/viewvc/llvm-project?rev=196779&view=rev
> > Feel free to commit the exact same change to gcc
> > or wait for the next merge (will try this week, but no promises)
>
> Thanks for the pointer, it allowed to bootstrap r205803.

I understand "no promises", but it is broken bootstrap with a known fix.
Waiting for more than a week seems excessive!

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[kcc at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #33 from Kostya Serebryany <kcc at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #32)
> > > > Would it be possible to post the fix? TIA.
> > > Committed upstream as http://llvm.org/viewvc/llvm-project?rev=196779&view=rev
> > > Feel free to commit the exact same change to gcc
> > > or wait for the next merge (will try this week, but no promises)
> >
> > Thanks for the pointer, it allowed to bootstrap r205803.
> 
> I understand "no promises", but it is broken bootstrap with a known fix.
> Waiting for more than a week seems excessive!
Sorry. Feel free to commit the exact fix as in 
http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_platform_limits_posix.cc?r1=196779&r2=196778&pathrev=196779
directly to GCC.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #34 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Feel free to commit the exact fix as in ...

Sorry, no write access.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[kcc at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #35 from Kostya Serebryany <kcc at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #34)
> > Feel free to commit the exact fix as in ...
> 
> Sorry, no write access.

Give me 1-2 hours. 
Just in case, please verify that the patch still works on Mac 10.6 
(I don't have access to 10.6)

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #36 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Give me 1-2 hours. 
> Just in case, please verify that the patch still works on Mac 10.6 
> (I don't have access to 10.6)

Already done: see comment 27. Anyway, I guarantee a quick feedback!-)

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[kcc at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #37 from Kostya Serebryany <kcc at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #36)
> > Give me 1-2 hours. 
> > Just in case, please verify that the patch still works on Mac 10.6 
> > (I don't have access to 10.6)
> 
> Already done: see comment 27. Anyway, I guarantee a quick feedback!-)
Done, r206113.

Is there anything else left in this bug?

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #38 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
(In reply to Kostya Serebryany from comment #37)
> Done, r206113.

Thanks, I successfully bootstrapped r206120 (with a fix for pr59541) on
x86_64-apple-darwin10.

> Is there anything else left in this bug?

I don't think so for darwin, but AFAICT it may remain issues for hppa-linux
(comment 22) and a "fairly old arm box" comments 28 and 29.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #39 from dave.anglin at bell dot net ---
On 12/19/2013 5:36 PM, dominiq at lps dot ens.fr wrote:
>> Is there anything else left in this bug?
> I don't think so for darwin, but AFAICT it may remain issues for hppa-linux
> (comment 22) and a "fairly old arm box" comments 28 and 29.
Rechecking status on the arm box.  I have been working on a linux and
glibc update for it, but this is non trivial because of a variety
of hardware not supported in the standard kernel.  There is considerable
code rot.

I doubt the hppa-linux issue is fixed.  It needs a kernel header
update or the check disabled.

Dave

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #40 from dave.anglin at bell dot net ---
On 12/19/2013 5:53 PM, John David Anglin wrote:
> Rechecking status on the arm box.
Problem is still there:

../../../../gcc/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:58:30: 
fatal error: linux/perf_event.h: No such file or directory
  #include <linux/perf_event.h>

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.0                       |4.9.1

--- Comment #41 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.0 has been released

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.1                       |4.9.2

--- Comment #42 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.1 has been released.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[sandra at codesourcery dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

Sandra Loosemore <sandra at codesourcery dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandra at codesourcery dot com

--- Comment #43 from Sandra Loosemore <sandra at codesourcery dot com> ---
I'm seeing the same errors as in Comment 8 (complaints about arrays with
negative sizes) when building a cross for aarch64-linux-gnu from mainline head.
 I'm confused about the status of this issue -- is there an uncommitted patch
out there somewhere?

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #44 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Sandra Loosemore from comment #43)
> I'm seeing the same errors as in Comment 8 (complaints about arrays with
> negative sizes) when building a cross for aarch64-linux-gnu from mainline
> head.  I'm confused about the status of this issue -- is there an
> uncommitted patch out there somewhere?

Yes there is a missing patch for aarch64 with the later kernel header files.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.2                       |4.9.3

--- Comment #45 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.2 has been released.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux

[jiwang at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

Jiong Wang <jiwang at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jiwang at gcc dot gnu.org

--- Comment #46 from Jiong Wang <jiwang at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #44)
> (In reply to Sandra Loosemore from comment #43)
> > I'm seeing the same errors as in Comment 8 (complaints about arrays with
> > negative sizes) when building a cross for aarch64-linux-gnu from mainline
> > head.  I'm confused about the status of this issue -- is there an
> > uncommitted patch out there somewhere?
> 
> Yes there is a missing patch for aarch64 with the later kernel header files.

the bootstrap failure on aarch64 is caused by type mismatch.

in libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h

__kernel_old_uid_t should be unsigned int on aarch64, while it's defined as
"unsigned short" thus triggered the assertion failure.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux and aarch64-linux

[jiwang at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #47 from Jiong Wang <jiwang at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #44)
> (In reply to Sandra Loosemore from comment #43)
> > I'm seeing the same errors as in Comment 8 (complaints about arrays with
> > negative sizes) when building a cross for aarch64-linux-gnu from mainline
> > head.  I'm confused about the status of this issue -- is there an
> > uncommitted patch out there somewhere?
> 
> Yes there is a missing patch for aarch64 with the later kernel header files.

aha...found the discussion. for those interested on AArch64, the missing patch
is at https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02571.html

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux and aarch64-linux

[mkuvyrkov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mkuvyrkov at gcc dot gnu.org

--- Comment #48 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> ---
Discussing this issue with Arnd Bergmann (kernel developer) and Christophe
Lyon, here is the analysis and how, I think, we should fix it:

The /manifesting/ issue is that definitions of __kernel_old_uid_t and
__kernel_old_gid_t have changed in AArch64 kernel headers several months ago. 
This was a correct bug fix on kernel's part.

For various reason libsanitizer uses its own definitions of corresponding data
types (instead of including kernel headers), which, still, should match the
kernel definitions.

The /underlying/ issue is that libsanitizer is trying to handle compat syscalls
that should never occur in userspace.  Specifically, at least __NR_getresuid16
and __NR_setresuid16 will never occur in native AArch64 code and are present in
the kernel for benefit of AArch32 applications running on AArch64 systems.

More generally, all references to __NR_<xxx>uid16 and __NR_<xxx>gid16 syscalls
should be surrounded with

#ifdef __NR_<xxx>uid32
// References to __NR_<xxx>uid16 are OK
#endif

... and similar for __NR_<xxx>gid16 syscalls.

Quoting Arnd:
When __NR_<xxx>uid32 is present, then __NR_<xxx>uid refers to the uid16
version.
If __NR_<xxx>uid32 does not exist, this means that __NR_<xxx>uid refers to the
uid32 version.

In summary, this problem affects several targets, of which AArch64 is one.  I
believe the fix is confined to
lib/sanitizer_common/sanitizer_common_syscalls.inc and is a fairly mechanical
one.

The last bit of business left is for someone to implement the above fix, test
it, and commit to both LLVM and GCC.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux and aarch64-linux

[mkuvyrkov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |christophe.lyon at st dot com

--- Comment #49 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> ---
Christophe,

Are you working on this issue?

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux and aarch64-linux

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

clyon at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clyon at gcc dot gnu.org

--- Comment #50 from clyon at gcc dot gnu.org ---
Yes, I am looking at it.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux and aarch64-linux

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #51 from clyon at gcc dot gnu.org ---
Created attachment 34678
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34678&action=edit
tentative patch

Here is a patch proposal: with it I an able to cross-build GCC for
aarch64-linux and arm-linux against either 3.7 or 3.17 kernel headers (that is,
before and after the changes for AArch64).

I'd like to make sure it works in the LLVM/compiler-rt environment too.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux and aarch64-linux

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #52 from clyon at gcc dot gnu.org ---
The patch I propose is broken, I missed the new warnings in my build log.
I inserted
#ifdef SYSCALL(chown32)
before
 PRE_SYSCALL(chown16)....
in sanitizer_common/sanitizer_common_syscalls.inc
but the SYSCALL is not defined there, resulting in #if 0 like behaviour.

I'm now wondering how can I get the information to know if
#ifdef __NR_<xxx>uid32
i.e. which headers am I allowed to include here?
Can I add
#include <sys/syscall.h> or is it not desirable?

Quoting Arnd:
> To provide a little more background, uid16 support can be further limited to
> these cases:
>
> * arm32 || x86-32 || sparc32 || sh || m68k
> * libc5 || glibc-2.0 || glibc-2.1 || (glibc-2.2 to 2.15 built against
>   linux-2.2 kernel headers)
>
> or in other words, uid16 is never used
>
> * on 64-bit architectures
> * on any glibc built against 2.4 or later kernel headers
> * on glibc-2.16 or later (which drops support for linux-2.2)
>
> I don't know what the respective minimum libc and kernel versions are
> for llvm and gcc, but it's possible that it could be dropped completely,
> but if there is already a dependency on at least linux-2.3.39 and
> glibc-2.2, the uid16 handling could just be removed.

So if inluding <sys/syscall.h> is not OK in
sanitizer_common/sanitizer_common_syscalls.inc and
b/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc (to avoid 
CHECK_TYPE_SIZE(__kernel_old_uid_t);
CHECK_TYPE_SIZE(__kernel_old_gid_t);
)
then it looks like the parts we want to #ifdef out should be removed instead.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux and aarch64-linux

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #53 from clyon at gcc dot gnu.org ---
The new patch I proposed has been accepted and committed upstream as r230324.

Can I cherry-pick it in GCC?

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux and aarch64-linux

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #54 from clyon at gcc dot gnu.org ---
Created attachment 34944
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34944&action=edit
compiler-rt-r230324

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux and aarch64-linux

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #55 from clyon at gcc dot gnu.org ---
compiler-rt-r230324 is the patch I would like to cherry-pick.

Jakub, is this OK?

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux and aarch64-linux

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #56 from clyon at gcc dot gnu.org ---
Author: clyon
Date: Mon Mar 23 13:43:22 2015
New Revision: 221593

URL: https://gcc.gnu.org/viewcvs?rev=221593&root=gcc&view=rev
Log:
2015-03-23  Christophe Lyon  <christophe.lyon@linaro.org>

    PR sanitizer/59009
    * sanitizer_common/sanitizer_platform_limits_posix.cc: Cherry pick
    upstream r230324.
    * sanitizer_common/sanitizer_platform.h: Likewise.
    * sanitizer_common/sanitizer_common_syscalls.inc: Likewise.


Modified:
    trunk/libsanitizer/ChangeLog
    trunk/libsanitizer/sanitizer_common/sanitizer_common_syscalls.inc
    trunk/libsanitizer/sanitizer_common/sanitizer_platform.h
    trunk/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux and aarch64-linux

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #57 from clyon at gcc dot gnu.org ---
Cherry-picked r230324 and committed in GCC as r221593, to fix aarch64 problems.

I'm not sure whether the "old arm" and hppa problems have been fixed?

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux and aarch64-linux

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

--- Comment #58 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.3 has been released.

[Bug sanitizer/59009] libsanitizer merge from upstream r191666 breaks bootstrap on powerpc64-linux and aarch64-linux

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59009

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.3                       |4.9.4