public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "pault at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/59198] [4.7/4.8/4.9 Regression] ICE on cyclically dependent polymorphic types Date: Tue, 25 Feb 2014 09:31:00 -0000 [thread overview] Message-ID: <bug-59198-4-0tyEg3boLF@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-59198-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59198 --- Comment #11 from Paul Thomas <pault at gcc dot gnu.org> --- A correct version of the patch of comment#6 to varasm.c is: Index: gcc/varasm.c =================================================================== *** gcc/varasm.c (revision 208048) --- gcc/varasm.c (working copy) *************** output_constructor_regular_field (oc_loc *** 4939,4944 **** --- 4939,4946 ---- better be last. */ gcc_assert (!fieldsize || !DECL_CHAIN (local->field)); } + else if (DECL_SIZE_UNIT (local->field) == NULL_TREE) + fieldsize = int_size_in_bytes (TREE_TYPE (local->field)); else fieldsize = tree_to_uhwi (DECL_SIZE_UNIT (local->field)); } Clearly, this is bomb-proof and so regtesting proceeds without problem for gcc and gfortran. It now remains to understand how structure fields can be built with type size information but with the decl comon information missing! ie. it should be possible to render the above unnecessary. Cheers Paul
next prev parent reply other threads:[~2014-02-25 9:31 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-11-20 2:30 [Bug fortran/59198] New: " juergen.reuter at desy dot de 2013-11-20 14:40 ` [Bug fortran/59198] [4.7/4.8/4.9 Regression] " janus at gcc dot gnu.org 2013-11-20 15:55 ` janus at gcc dot gnu.org 2013-12-19 15:20 ` rguenth at gcc dot gnu.org 2013-12-19 15:33 ` rguenth at gcc dot gnu.org 2014-01-19 21:31 ` mikael at gcc dot gnu.org 2014-02-09 17:50 ` janus at gcc dot gnu.org 2014-02-22 13:35 ` pault at gcc dot gnu.org 2014-02-22 15:35 ` burnus at gcc dot gnu.org 2014-02-22 16:02 ` paul.richard.thomas at gmail dot com 2014-02-24 9:20 ` paul.richard.thomas at gmail dot com 2014-02-25 9:31 ` pault at gcc dot gnu.org [this message] 2014-02-25 13:44 ` paul.richard.thomas at gmail dot com 2014-02-25 20:23 ` pault at gcc dot gnu.org 2014-06-12 13:46 ` [Bug fortran/59198] [4.7/4.8/4.9/4.10 " rguenth at gcc dot gnu.org 2014-12-19 13:40 ` [Bug fortran/59198] [4.8/4.9/5 " jakub at gcc dot gnu.org 2014-12-26 15:59 ` paul.richard.thomas at gmail dot com 2014-12-26 16:25 ` dominiq at lps dot ens.fr 2015-02-17 9:39 ` dominiq at lps dot ens.fr 2015-03-16 8:45 ` pault at gcc dot gnu.org 2015-03-16 11:26 ` juergen.reuter at desy dot de 2015-03-17 5:20 ` pault at gcc dot gnu.org 2015-03-18 20:22 ` [Bug fortran/59198] [4.8/4.9 " anlauf at gmx dot de 2015-03-18 21:19 ` pault at gcc dot gnu.org 2015-03-19 22:23 ` pault at gcc dot gnu.org 2015-06-23 8:47 ` [Bug fortran/59198] [4.8 " rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-59198-4-0tyEg3boLF@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).