From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-435189-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 9673 invoked by alias); 20 Nov 2013 08:45:06 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 9634 invoked by uid 48); 20 Nov 2013 08:45:02 -0000
From: "dcb314 at hotmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/59205] New: config/iq2000/iq2000.c:2188: possible cut'n'paste error ?
Date: Wed, 20 Nov 2013 08:45:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dcb314 at hotmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-59205-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-11/txt/msg01966.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59205

            Bug ID: 59205
           Summary: config/iq2000/iq2000.c:2188: possible cut'n'paste
                    error ?
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com

I just ran the static analyser cppcheck over the 
trunk source code.

It said

[trunk/gcc/config/iq2000/iq2000.c:2188] ->
[trunk/gcc/config/iq2000/iq2000.c:2173]: (style) Found duplicate branches for
'if' and 'else'.

Source code is

  if (TARGET_EMBEDDED_DATA)
    {
      /* For embedded applications, always put an object in read-only data
     if possible, in order to reduce RAM usage.  */
      if ((TREE_CODE (decl) == VAR_DECL
       && TREE_READONLY (decl) && !TREE_SIDE_EFFECTS (decl)
       && DECL_INITIAL (decl)
       && (DECL_INITIAL (decl) == error_mark_node
           || TREE_CONSTANT (DECL_INITIAL (decl))))
      /* Deal with calls from output_constant_def_contents.  */
      || TREE_CODE (decl) != VAR_DECL)
    return readonly_data_section;
      else
    return data_section;
    }
  else
    {
      /* For hosted applications, always put an object in small data if
     possible, as this gives the best performance.  */
      if ((TREE_CODE (decl) == VAR_DECL
       && TREE_READONLY (decl) && !TREE_SIDE_EFFECTS (decl)
       && DECL_INITIAL (decl)
       && (DECL_INITIAL (decl) == error_mark_node
           || TREE_CONSTANT (DECL_INITIAL (decl))))
      /* Deal with calls from output_constant_def_contents.  */
      || TREE_CODE (decl) != VAR_DECL)
    return readonly_data_section;
      else
    return data_section;
    }

Suggest code rework.