[Bug middle-end/59250] New: usan: ICE (segfault) with -fsanitize=undefined in ubsan_create_data

[Bug middle-end/59250] New: usan: ICE (segfault) with -fsanitize=undefined in ubsan_create_data

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59250

            Bug ID: 59250
           Summary: usan: ICE (segfault) with -fsanitize=undefined in
                    ubsan_create_data
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org
                CC: mpolacek at gcc dot gnu.org

Created attachment 31272
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=31272&action=edit
Test case: Run as "g++ -fsanitize=undefined test29.ii"

The followed code worked about week ago but fails now (r205246) with a segfault
on x86-64-gnu-linux.

$ g++ -fsanitize=undefined test29.ii
test29.ii: In constructor 'FileHandle::FileHandle(const char*)':
test29.ii:27:1: internal compiler error: Segmentation fault
 FileHandle::FileHandle (const char* fname) : fname(fname) {
 ^
0xb9f85f crash_signal
        ../../gcc/toplev.c:336
0xbbab24 ubsan_source_location
        ../../gcc/ubsan.c:230
0xbbab24 ubsan_create_data(char const*, unsigned int, ubsan_mismatch_data
const*, ...)
        ../../gcc/ubsan.c:463
0xbbb179 ubsan_expand_null_ifn(gimple_stmt_iterator_d)
        ../../gcc/ubsan.c:565

[Bug middle-end/59250] usan: ICE (segfault) with -fsanitize=undefined in ubsan_create_data

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59250

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Yeah, I bet this hunk

--- gcc/ubsan.c.jj    2013-11-22 01:40:03.000000000 +0100
+++ gcc/ubsan.c    2013-11-22 10:05:29.491725405 +0100
@@ -227,8 +227,8 @@ ubsan_source_location (location_t loc)
   xloc = expand_location (loc);

   /* Fill in the values from LOC.  */
-  size_t len = strlen (xloc.file);
-  tree str = build_string (len + 1, xloc.file);
+  size_t len = xloc.file ? strlen (xloc.file) : 0;
+  tree str = build_string (len + 1, xloc.file ? xloc.file : "");
   TREE_TYPE (str) = build_array_type (char_type_node,
                       build_index_type (size_int (len)));
   TREE_READONLY (str) = 1;
@@ -642,7 +642,7 @@ ubsan_pass (void)
     {
       struct walk_stmt_info wi;
       gimple stmt = gsi_stmt (gsi);
-      if (is_gimple_debug (stmt))
+      if (is_gimple_debug (stmt) || gimple_clobber_p (stmt))
         {
           gsi_next (&gsi);
           continue;

from Jakub's recent patch
(http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02831.html) will fix it.

[Bug sanitizer/59250] ubsan: ICE (segfault) with -fsanitize=undefined in ubsan_create_data

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59250

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-11-22
                 CC|                            |dodji at gcc dot gnu.org,
                   |                            |dvyukov at gcc dot gnu.org,
                   |                            |jakub at gcc dot gnu.org,
                   |                            |kcc at gcc dot gnu.org
          Component|middle-end                  |sanitizer
   Target Milestone|---                         |4.9.0
            Summary|usan: ICE (segfault) with   |ubsan: ICE (segfault) with
                   |-fsanitize=undefined in     |-fsanitize=undefined in
                   |ubsan_create_data           |ubsan_create_data
     Ever confirmed|0                           |1

[Bug sanitizer/59250] ubsan: ICE (segfault) with -fsanitize=undefined in ubsan_create_data

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59250

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Marek Polacek from comment #1)
> Yeah, I bet this hunk
>
> from Jakub's recent patch
> (http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02831.html) will fix it.

Which was committed as r205283.

[Bug sanitizer/59250] ubsan: ICE (segfault) with -fsanitize=undefined in ubsan_create_data

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59250

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |mpolacek at gcc dot gnu.org

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
I'll add the testcase.

[Bug sanitizer/59250] ubsan: ICE (segfault) with -fsanitize=undefined in ubsan_create_data

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59250

--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Mon Nov 25 11:17:23 2013
New Revision: 205349

URL: http://gcc.gnu.org/viewcvs?rev=205349&root=gcc&view=rev
Log:
2013-11-25  Marek Polacek  <polacek@redhat.com>

testsuite/
    * g++.dg/ubsan/pr59250.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/ubsan/pr59250.C
Modified:
    trunk/gcc/testsuite/ChangeLog

[Bug sanitizer/59250] ubsan: ICE (segfault) with -fsanitize=undefined in ubsan_create_data

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59250

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.