[Bug c++/59295] New: useless warning: 'Bar' is already a friend of 'Foo' [enabled by default]

[Bug c++/59295] New: useless warning: 'Bar' is already a friend of 'Foo' [enabled by default]

[ppluzhnikov at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59295

            Bug ID: 59295
           Summary: useless warning: 'Bar' is already a friend of 'Foo'
                    [enabled by default]
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ppluzhnikov at google dot com

Google ref: b/11542609

Using trunk gcc:
g++ (GCC) 4.9.0 20131125 (experimental)

/// -- cut ---
class Foo {
 friend class Bar;
 friend class Bar;
};
/// -- cut ---


g++ -c t.cc
t.cc:3:15: warning: 'Bar' is already a friend of 'Foo' [enabled by default]
  friend class Bar;
               ^

This warning is purely stylistic -- no possible bug could happen when this
warning is disabled.

It is also not suppressable :-(

In actual code, both friend declarations come from macro expansion, and are
somewhat hard to get rid of.

[Bug c++/59295] useless warning: 'Bar' is already a friend of 'Foo' [enabled by default]

[ppluzhnikov at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59295

--- Comment #1 from Paul Pluzhnikov <ppluzhnikov at google dot com> ---
Still broken in current head (r208736).

[Bug c++/59295] useless warning: 'Bar' is already a friend of 'Foo' [enabled by default]

[ppluzhnikov at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59295

--- Comment #2 from Paul Pluzhnikov <ppluzhnikov at google dot com> ---
This appears to be a very old warning.
Patch: http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01123.html

[Bug c++/59295] useless warning: 'Bar' is already a friend of 'Foo' [enabled by default]

[ppluzhnikov at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59295

--- Comment #3 from ppluzhnikov at gcc dot gnu.org ---
Author: ppluzhnikov
Date: Wed Apr 16 17:39:45 2014
New Revision: 209444

URL: http://gcc.gnu.org/viewcvs?rev=209444&root=gcc&view=rev
Log:
2014-04-16  Paul Pluzhnikov  <ppluzhnikov@google.com>

    PR c++/59295
    * friend.c (add_friend, make_friend_class): Move repeated friend
    warning under Wredundant_decls.


Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/friend.c

[Bug c++/59295] useless warning: 'Bar' is already a friend of 'Foo' [enabled by default]

[ppluzhnikov at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59295

Paul Pluzhnikov <ppluzhnikov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Paul Pluzhnikov <ppluzhnikov at google dot com> ---
Fixed on trunk.