public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "kcc at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/59302] tsan: Unexpected mmap in InternalAllocator!
Date: Wed, 27 Nov 2013 07:58:00 -0000	[thread overview]
Message-ID: <bug-59302-4-PCrQhYSwKx@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-59302-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59302

--- Comment #3 from Kostya Serebryany <kcc at gcc dot gnu.org> ---
(In reply to Joost VandeVondele from comment #2)
> (In reply to Kostya Serebryany from comment #1)
> > This isn't expected to happen and so we did not write a better warning
> > message.
> > We may be able to fix it, but the underlying problem is in your tests: 
> > it has a race that tsan is trying to report and which is suppressed
> > (probably because a similar races was reported before).
> > 
> > How many race reports do you see before tsan crashes? 
> > Did you suppress any of those?
> 
> yes, I have a suppression in place to workaround PR59194. As it is an atomic
> update in a hot loop, it will be triggered millions of times.

Suppressing a race that happens so many times is no good. 
Even if we fix the crash above (which I'd prefer not to; instead we should emit
a more descriptive message and die; we'll do that) tsan will remain very slow. 
The right solution is of course to fix the code to not have that race.
The next good solution is to annotate the function with
__attribute__((no_sanitize_thread)) -- but I don't know if fortran has anything
like this. 
The next somewhat good solution is to blacklist the function
(https://code.google.com/p/thread-sanitizer/wiki/Flags?ts=1385538776&updated=Flags#Blacklist_Format)
but that is not supported by GCC and will have to be implemented first.


  parent reply	other threads:[~2013-11-27  7:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-26 15:33 [Bug sanitizer/59302] New: " Joost.VandeVondele at mat dot ethz.ch
2013-11-27  7:13 ` [Bug sanitizer/59302] " kcc at gcc dot gnu.org
2013-11-27  7:30 ` Joost.VandeVondele at mat dot ethz.ch
2013-11-27  7:58 ` kcc at gcc dot gnu.org [this message]
2014-12-12 16:14 ` dvyukov at google dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-59302-4-PCrQhYSwKx@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).