public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/59308] New: gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5
@ 2013-11-27 8:28 christophe.lyon at st dot com
2013-11-27 8:55 ` [Bug testsuite/59308] [4.9 Regression] " rguenth at gcc dot gnu.org
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: christophe.lyon at st dot com @ 2013-11-27 8:28 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59308
Bug ID: 59308
Summary: gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail
on arm cortex-a5
Product: gcc
Version: 4.9.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: testsuite
Assignee: unassigned at gcc dot gnu.org
Reporter: christophe.lyon at st dot com
Commit 204194 from Andrew Pinski introduced several new tests, among which
gcc.dg/tree-ssa/ssa-ifcombine-ccmp-1.c scan-tree-dump optimized "&"
gcc.dg/tree-ssa/ssa-ifcombine-ccmp-4.c scan-tree-dump optimized "&"
gcc.dg/tree-ssa/ssa-ifcombine-ccmp-5.c scan-tree-dump-times optimized "&" 2
gcc.dg/tree-ssa/ssa-ifcombine-ccmp-6.c scan-tree-dump-times optimized "\\|" 2
fail when configuring --target arm-none-linux-gnueabihf --with-cpu=cortex-a5
--with-fpu=vfpv3-d16-fp16.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug testsuite/59308] [4.9 Regression] gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5
2013-11-27 8:28 [Bug testsuite/59308] New: gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5 christophe.lyon at st dot com
@ 2013-11-27 8:55 ` rguenth at gcc dot gnu.org
2014-02-18 7:14 ` jakub at gcc dot gnu.org
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-11-27 8:55 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59308
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2013-11-27
Target Milestone|--- |4.9.0
Summary|gcc.dg/tree-ssa/ssa-ifcombi |[4.9 Regression]
|ne-ccmp-[1456] tests fail |gcc.dg/tree-ssa/ssa-ifcombi
|on arm cortex-a5 |ne-ccmp-[1456] tests fail
| |on arm cortex-a5
Ever confirmed|0 |1
--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
They depend on BRANCH_COST, their target selector needs updating for arm.
/* { dg-do compile { target { ! "m68k*-*-* mmix*-*-* mep*-*-* bfin*-*-*
v850*-*-* picochip*-*-* moxie*-*-* cris*-*-* m32c*-*-* fr30*-*-* mcore*-*-*
powerpc*-*-* xtensa*-*-* arc*-*-*"} } } */
or rather we should have a effective-target logical_op_non_short_circuit
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug testsuite/59308] [4.9 Regression] gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5
2013-11-27 8:28 [Bug testsuite/59308] New: gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5 christophe.lyon at st dot com
2013-11-27 8:55 ` [Bug testsuite/59308] [4.9 Regression] " rguenth at gcc dot gnu.org
@ 2014-02-18 7:14 ` jakub at gcc dot gnu.org
2014-02-27 9:23 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2014-02-18 7:14 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59308
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org,
| |rsandifo at gcc dot gnu.org
--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
So, now that r207810 has been committed, shouldn't these tests be updated too?
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug testsuite/59308] [4.9 Regression] gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5
2013-11-27 8:28 [Bug testsuite/59308] New: gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5 christophe.lyon at st dot com
2013-11-27 8:55 ` [Bug testsuite/59308] [4.9 Regression] " rguenth at gcc dot gnu.org
2014-02-18 7:14 ` jakub at gcc dot gnu.org
@ 2014-02-27 9:23 ` rguenth at gcc dot gnu.org
2014-03-03 7:40 ` rearnsha at gcc dot gnu.org
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-02-27 9:23 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59308
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Yes.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug testsuite/59308] [4.9 Regression] gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5
2013-11-27 8:28 [Bug testsuite/59308] New: gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5 christophe.lyon at st dot com
` (2 preceding siblings ...)
2014-02-27 9:23 ` rguenth at gcc dot gnu.org
@ 2014-03-03 7:40 ` rearnsha at gcc dot gnu.org
2014-03-03 7:47 ` jakub at gcc dot gnu.org
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: rearnsha at gcc dot gnu.org @ 2014-03-03 7:40 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59308
--- Comment #4 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
It's not as simple as updating the target selector. LONSC_P depends on
BRANCH_COST, which can vary depending on the specific micro-architecture for
the target system.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug testsuite/59308] [4.9 Regression] gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5
2013-11-27 8:28 [Bug testsuite/59308] New: gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5 christophe.lyon at st dot com
` (3 preceding siblings ...)
2014-03-03 7:40 ` rearnsha at gcc dot gnu.org
@ 2014-03-03 7:47 ` jakub at gcc dot gnu.org
2014-03-04 11:19 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2014-03-03 7:47 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59308
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
So the test can then be improved for ARM by testing GCC predefined macros or
something similar, to make check_effective_target_logical_op_short_circuit
more precise. Are you sure check_effective_target_arm_cortex_m isn't good
enough for ARM?
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug testsuite/59308] [4.9 Regression] gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5
2013-11-27 8:28 [Bug testsuite/59308] New: gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5 christophe.lyon at st dot com
` (4 preceding siblings ...)
2014-03-03 7:47 ` jakub at gcc dot gnu.org
@ 2014-03-04 11:19 ` jakub at gcc dot gnu.org
2014-03-04 11:23 ` jakub at gcc dot gnu.org
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2014-03-04 11:19 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59308
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P1 |P2
--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Don't see why this should be P1, it is testsuite only thing.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug testsuite/59308] [4.9 Regression] gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5
2013-11-27 8:28 [Bug testsuite/59308] New: gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5 christophe.lyon at st dot com
` (5 preceding siblings ...)
2014-03-04 11:19 ` jakub at gcc dot gnu.org
@ 2014-03-04 11:23 ` jakub at gcc dot gnu.org
2014-03-05 20:08 ` jakub at gcc dot gnu.org
2014-03-12 14:02 ` jakub at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2014-03-04 11:23 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59308
--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 32258
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32258&action=edit
gcc49-pr59308.patch
Patch (only tested on x86_64-linux with
--target_board=unix\{-m32,-m32/-march=i386,-m64\} where some of those tests
previously also failed with -march=i386 variant).
Though, I wonder if it wouldn't be better to just compile or run those tests
just on targets which do support -mbranch-cost=2 option
(mips/avr/s390/i?86/x86_64) and ignore all other targets. The tests are
testing GIMPLE behavior anyway.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug testsuite/59308] [4.9 Regression] gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5
2013-11-27 8:28 [Bug testsuite/59308] New: gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5 christophe.lyon at st dot com
` (6 preceding siblings ...)
2014-03-04 11:23 ` jakub at gcc dot gnu.org
@ 2014-03-05 20:08 ` jakub at gcc dot gnu.org
2014-03-12 14:02 ` jakub at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2014-03-05 20:08 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59308
--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Wed Mar 5 20:07:50 2014
New Revision: 208354
URL: http://gcc.gnu.org/viewcvs?rev=208354&root=gcc&view=rev
Log:
PR testsuite/59308
* gcc.dg/pr46309.c: Don't compile on logical_op_short_circuit targets
other than mips/avr. Use -mbranch-cost=2 even for i?86/x86_64.
* gcc.dg/tree-ssa/reassoc-32.c: Use -mbranch-cost=2 even for
s390*/i?86/x86_64.
* gcc.dg/tree-ssa/reassoc-33.c: Likewise.
* gcc.dg/tree-ssa/reassoc-34.c: Likewise.
* gcc.dg/tree-ssa/reassoc-35.c: Likewise.
* gcc.dg/tree-ssa/reassoc-36.c: Likewise.
* gcc.dg/tree-ssa/ssa-ifcombine-ccmp-1.c: Don't compile on
logical_op_short_circuit targets other than avr. Use -mbranch-cost=2
even for mips*/s390*/i?86/x86_64.
* gcc.dg/tree-ssa/ssa-ifcombine-ccmp-2.c: Likewise.
* gcc.dg/tree-ssa/ssa-ifcombine-ccmp-3.c: Likewise.
* gcc.dg/tree-ssa/ssa-ifcombine-ccmp-4.c: Likewise.
* gcc.dg/tree-ssa/ssa-ifcombine-ccmp-5.c: Likewise.
* gcc.dg/tree-ssa/ssa-ifcombine-ccmp-6.c: Likewise.
Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gcc.dg/pr46309.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/reassoc-32.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/reassoc-33.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/reassoc-34.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/reassoc-35.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/reassoc-36.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-ifcombine-ccmp-1.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-ifcombine-ccmp-2.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-ifcombine-ccmp-3.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-ifcombine-ccmp-4.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-ifcombine-ccmp-5.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-ifcombine-ccmp-6.c
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug testsuite/59308] [4.9 Regression] gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5
2013-11-27 8:28 [Bug testsuite/59308] New: gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5 christophe.lyon at st dot com
` (7 preceding siblings ...)
2014-03-05 20:08 ` jakub at gcc dot gnu.org
@ 2014-03-12 14:02 ` jakub at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2014-03-12 14:02 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59308
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Assuming this is fixed, please reopen if not with details where it fails and
what.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-03-12 14:02 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-27 8:28 [Bug testsuite/59308] New: gcc.dg/tree-ssa/ssa-ifcombine-ccmp-[1456] tests fail on arm cortex-a5 christophe.lyon at st dot com
2013-11-27 8:55 ` [Bug testsuite/59308] [4.9 Regression] " rguenth at gcc dot gnu.org
2014-02-18 7:14 ` jakub at gcc dot gnu.org
2014-02-27 9:23 ` rguenth at gcc dot gnu.org
2014-03-03 7:40 ` rearnsha at gcc dot gnu.org
2014-03-03 7:47 ` jakub at gcc dot gnu.org
2014-03-04 11:19 ` jakub at gcc dot gnu.org
2014-03-04 11:23 ` jakub at gcc dot gnu.org
2014-03-05 20:08 ` jakub at gcc dot gnu.org
2014-03-12 14:02 ` jakub at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).