From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-436144-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 525 invoked by alias); 28 Nov 2013 13:32:34 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 501 invoked by uid 48); 28 Nov 2013 13:32:31 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/59326] FAIL: gcc.dg/vect/vect-simd-clone-*.c
Date: Thu, 28 Nov 2013 13:32:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: lto
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59326-4-QPYB8na3dj@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59326-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59326-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-11/txt/msg02921.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59326

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #3)
> Fix for that:
> 
> Index: gcc/omp-low.c
> ===================================================================
> --- gcc/omp-low.c       (revision 205484)
> +++ gcc/omp-low.c       (working copy)
> @@ -11734,8 +11734,13 @@ static unsigned int
>  ipa_omp_simd_clone (void)
>  {
>    struct cgraph_node *node;
> -  FOR_EACH_FUNCTION (node)
> -    expand_simd_clones (node);
> +  FOR_EACH_DEFINED_FUNCTION (node)
> +    {
> +      if (!cgraph_function_with_gimple_body_p (node))
> +       continue;
> +      cgraph_get_body (node);
> +      expand_simd_clones (node);
> +    }
>    return 0;
>  }
> 
> 
> and now it magically works.

But then it won't handle the !node->definition cloning (it isn't actually
cloning in that case, just creating another DECL_EXTERNAL FUNCTION_DECL with
adjusted arguments).  So it really needs to be FOR_EACH_FUNCTION, but perhaps
can avoid the cgraph_function_with_gimple_body_p/cgraph_get_body stuff if
!node->definition.