[Bug c++/59366] New: A friend function template defined in a class is found without ADL

[Bug c++/59366] New: A friend function template defined in a class is found without ADL

[ville.voutilainen at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59366

            Bug ID: 59366
           Summary: A friend function template defined in a class is found
                    without ADL
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ville.voutilainen at gmail dot com

Reduced test:

struct X
{
    //friend void f(int) {} // #1
    template <class T> friend void f(T) {} // #2
};

int main()
{
    f(5); // #3
}

The function in #1 is correctly not found at #3. The template
at #2 is, which shouldn't happen since such a friend should be
found by ADL only, and there's no ADL going on here.

[Bug c++/59366] A friend function template defined in a class is found without ADL

[momchil.velikov at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59366

--- Comment #1 from Momchil Velikov <momchil.velikov at gmail dot com> ---
Proposed fix:

http://gcc.gnu.org/ml/gcc-patches/2014-05/msg00198.html

[Bug c++/59366] A friend function template defined in a class is found without ADL

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59366

--- Comment #2 from Jason Merrill <jason at gcc dot gnu.org> ---
Author: jason
Date: Thu Jan 15 21:02:15 2015
New Revision: 219689

URL: https://gcc.gnu.org/viewcvs?rev=219689&root=gcc&view=rev
Log:
    PR c++/59366
    * name-lookup.c (pushdecl_maybe_friend_1): Hide friend functions
    and function templates, declared only in the class.
    * decl.c (duplicate_decls): Reveal hidden friend functions or
    function templates, if they are redeclared outside the class.

Added:
    trunk/gcc/testsuite/g++.dg/template/friend57.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/decl.c
    trunk/gcc/cp/name-lookup.c
    trunk/gcc/testsuite/g++.old-deja/g++.pt/friend5.C

[Bug c++/59366] A friend function template defined in a class is found without ADL

[ville.voutilainen at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59366

Ville Voutilainen <ville.voutilainen at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Ville Voutilainen <ville.voutilainen at gmail dot com> ---
Thus done.

[Bug c++/59366] A friend function template defined in a class is found without ADL

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59366

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |6.0