public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/59379] [4.9 Regression] gomp_init_num_threads is compiled into an infinite loop with --with-arch=corei7 --with-cpu=slm Date: Sat, 18 Jan 2014 17:13:00 -0000 [thread overview] Message-ID: <bug-59379-4-pgppKJKeGB@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-59379-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59379 H.J. Lu <hjl.tools at gmail dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ubizjak at gmail dot com --- Comment #15 from H.J. Lu <hjl.tools at gmail dot com> --- The problem is in ix86_split_lea_for_addr. For LEA operation with SImode_address_operand, which zero-extends SImode to DImode, it turns (set (reg:DI) ...) into (set (reg:SI) ...) We need to do (set (reg:DI) (zero_extend:DI (reg:SI))) at the end: --- diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index ff210c8..5ceccdf 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -18375,7 +18375,7 @@ ix86_split_lea_for_addr (rtx insn, rtx operands[], enum machine_mode mode) ix86_emit_binop (PLUS, mode, target, parts.disp); ix86_emit_binop (PLUS, mode, target, tmp1); - return; + goto check_mode; } ix86_emit_binop (PLUS, mode, target, tmp); @@ -18384,6 +18384,13 @@ ix86_split_lea_for_addr (rtx insn, rtx operands[], enum machine_mode mode) if (parts.disp && parts.disp != const0_rtx) ix86_emit_binop (PLUS, mode, target, parts.disp); } + +check_mode: + if (mode != GET_MODE (operands[0])) + { + gcc_assert (mode == SImode && GET_MODE (operands[0]) == DImode); + emit_insn (gen_zero_extendsidi2 (operands[0], target)); + } } /* Return true if it is ok to optimize an ADD operation to LEA --- Or we can avoid splitting LEA for SImode_address_operand by --- diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index 954bbed..e5e6e12 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -5415,10 +5415,11 @@ else return "lea{<imodesuffix>}\t{%E1, %0|%0, %E1}"; } - "reload_completed && ix86_avoid_lea_for_addr (insn, operands)" + "reload_completed + && !SImode_address_operand (operands[1], VOIDmode) + && ix86_avoid_lea_for_addr (insn, operands)" [(const_int 0)] { - enum machine_mode mode = <MODE>mode; rtx pat; /* ix86_avoid_lea_for_addr re-recognizes insn and may @@ -5428,12 +5429,7 @@ operands[0] = SET_DEST (pat); operands[1] = SET_SRC (pat); - /* Emit all operations in SImode for zero-extended addresses. Recall - that x86_64 inheretly zero-extends SImode operations to DImode. */ - if (SImode_address_operand (operands[1], VOIDmode)) - mode = SImode; - - ix86_split_lea_for_addr (curr_insn, operands, mode); + ix86_split_lea_for_addr (curr_insn, operands, <MODE>mode); DONE; } [(set_attr "type" "lea") --- Either patch fixes the problem.
next prev parent reply other threads:[~2014-01-18 17:13 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-12-03 21:40 [Bug target/59379] New: " hjl.tools at gmail dot com 2013-12-03 21:46 ` [Bug target/59379] " octoploid at yandex dot com 2013-12-03 21:51 ` hjl.tools at gmail dot com 2013-12-03 21:52 ` hjl.tools at gmail dot com 2013-12-04 0:41 ` hjl.tools at gmail dot com 2013-12-04 0:48 ` hjl.tools at gmail dot com 2013-12-04 10:52 ` [Bug target/59379] [4.9 Regression] " hjl.tools at gmail dot com 2013-12-04 23:39 ` hjl.tools at gmail dot com 2013-12-05 3:11 ` hjl.tools at gmail dot com 2013-12-05 11:17 ` rguenth at gcc dot gnu.org 2013-12-06 1:45 ` hjl.tools at gmail dot com 2013-12-19 15:37 ` rguenth at gcc dot gnu.org 2013-12-26 12:41 ` izamyatin at gmail dot com 2013-12-26 12:57 ` hjl.tools at gmail dot com 2013-12-26 14:41 ` hjl.tools at gmail dot com 2013-12-30 21:16 ` izamyatin at gmail dot com 2013-12-31 7:02 ` izamyatin at gmail dot com 2014-01-18 17:13 ` hjl.tools at gmail dot com [this message] 2014-01-18 19:47 ` ubizjak at gmail dot com 2014-01-19 9:51 ` ubizjak at gmail dot com 2014-01-19 14:18 ` hjl.tools at gmail dot com 2014-01-19 15:48 ` uros at gcc dot gnu.org 2014-01-22 18:29 ` uros at gcc dot gnu.org 2014-01-22 18:40 ` ubizjak at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-59379-4-pgppKJKeGB@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).