public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "olegendo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/59401] [SH] GBR addressing mode optimization produces wrong code
Date: Wed, 15 Oct 2014 13:45:00 -0000 [thread overview]
Message-ID: <bug-59401-4-KjhZG5TVSQ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-59401-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59401
--- Comment #11 from Oleg Endo <olegendo at gcc dot gnu.org> ---
Created attachment 33723
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33723&action=edit
Make GBR call preserved by default
(In reply to Oleg Endo from comment #10)
> (In reply to Kazumoto Kojima from comment #9)
> > (In reply to Oleg Endo from comment #8)
> > > change the
> > > value for gbr in sh.h CALL_USED_REGISTERS from '1' to '0' and confirm that
> > > everything is still OK?
> >
> > The comment and document about CALL_USED_REGISTERS say that it must be
> > a superset of FIXED_REGISTERS. CALL_REALLY_USED_REGISTERS might be
> > a macro for that purpose.
>
> Right. In this case it's probably better to do it in
> sh_conditional_register_usage. It would be nice if '-fcall-saved-gbr' and
> '-fcall-used-gbr' still remained functional afterwards ... I'll give it a
> try.
sh_conditional_register_usage is invoked after the -fcall-*-* options are
processed. Defining the CALL_REALLY_USED_REGISTERS macro with the default
values works as expected, i.e. -fcall-used-gbr still works.
Kaz, could you please add the attached patch to your test run?
next prev parent reply other threads:[~2014-10-15 13:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 20:19 [Bug target/59401] New: " olegendo at gcc dot gnu.org
2013-12-05 20:43 ` [Bug target/59401] " olegendo at gcc dot gnu.org
2014-10-12 23:14 ` olegendo at gcc dot gnu.org
2014-10-12 23:24 ` olegendo at gcc dot gnu.org
2014-10-13 5:17 ` kkojima at gcc dot gnu.org
2014-10-13 21:18 ` olegendo at gcc dot gnu.org
2014-10-13 22:48 ` olegendo at gcc dot gnu.org
2014-10-14 1:42 ` kkojima at gcc dot gnu.org
2014-10-14 1:51 ` olegendo at gcc dot gnu.org
2014-10-14 2:59 ` kkojima at gcc dot gnu.org
2014-10-14 3:33 ` olegendo at gcc dot gnu.org
2014-10-15 13:45 ` olegendo at gcc dot gnu.org [this message]
2014-10-16 12:22 ` olegendo at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-59401-4-KjhZG5TVSQ@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).