[Bug target/59422] New: Support more targets for function multi versioning

[Bug target/59422] New: Support more targets for function multi versioning

[linux at carewolf dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59422

            Bug ID: 59422
           Summary: Support more targets for function multi versioning
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: linux at carewolf dot com

Created attachment 31399
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=31399&action=edit
Patch

Trying to compile a function with an "xop" multiversion fails with a "No
dispatcher found for xop" error message. Similarly newer x86 architectures are
not detected. 

Patch attached. 

Adds support for haswell, silvermount, and the most recent amd models. It also
prioritizes AVX2 versions over AMD specific version pre-AVX2.

[Bug target/59422] Support more targets for function multi versioning

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59422

--- Comment #1 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Allan Jensen from comment #0)
> Created attachment 31399 [details]
> Patch
> 
> Trying to compile a function with an "xop" multiversion fails with a "No
> dispatcher found for xop" error message. Similarly newer x86 architectures
> are not detected. 
> 
> Patch attached. 
> 
> Adds support for haswell, silvermount, and the most recent amd models. It
> also prioritizes AVX2 versions over AMD specific version pre-AVX2.

Please post patch at gcc-patches@ mailing list, as instructed in [1].

[1] http://gcc.gnu.org/contribute.html
>From gcc-bugs-return-437023-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Dec 09 07:08:31 2013
Return-Path: <gcc-bugs-return-437023-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 16739 invoked by alias); 9 Dec 2013 07:08:31 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 16687 invoked by uid 48); 9 Dec 2013 07:08:27 -0000
From: "y.gribov at samsung dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/59410] tsan tests fail with address randomization disabled
Date: Mon, 09 Dec 2013 07:08:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: sanitizer
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: y.gribov at samsung dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59410-4-g0UMslB3Xi@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59410-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59410-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg00678.txt.bz2
Content-length: 313

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY410

--- Comment #28 from Yury Gribov <y.gribov at samsung dot com> ---
(In reply to H.J. Lu from comment #26)
> TSAN tests should specify a load address which
> works with TSAN.

We'll add `-Wl,-Ttext-segment,0x855555000000' to TSan tests compilation options
then.

[Bug target/59422] Support more targets for function multi versioning

[uros at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59422

--- Comment #2 from uros at gcc dot gnu.org ---
Author: uros
Date: Wed Dec 25 22:22:24 2013
New Revision: 206200

URL: http://gcc.gnu.org/viewcvs?rev=206200&root=gcc&view=rev
Log:
gcc/

2013-12-25  Allan Sandfeld Jensen  <sandfeld@kde.org>
        H.J. Lu  <hongjiu.lu@intel.com>

    PR target/59422
    * config/i386/i386.c (get_builtin_code_for_version): Handle
    PROCESSOR_HASWELL, PROCESSOR_SILVERMONT, PROCESSOR_BTVER1,
    PROCESSOR_BTVER2, PROCESSOR_BDVER3 and PROCESSOR_BDVER4.
    Change priority of PROCESSOR_BDVER1 to P_PROC_XOP.
    (fold_builtin_cpu): Add "ivybridge", "haswell", "bonnell",
    "silvermont", "bobcat" and "jaguar" CPU names.  Add "sse4a",
    "fma4", "xop" and "fma" ISA names.

libgcc/

2013-12-25  Allan Sandfeld Jensen  <sandfeld@kde.org>
        H.J. Lu  <hongjiu.lu@intel.com>

        PR target/59422
        * config/i386/cpuinfo.c (enum processor_types):  Add AMD_BOBCAT
    and AMD_JAGUAR.
    (enum processor_subtypes): Add AMDFAM15H_BDVER3, AMDFAM15H_BDVER4,
    INTEL_COREI7_IVYBRIDGE and INTEL_COREI7_HASWELL.
    (enum processor_features): Add  FEATURE_SSE4_A, FEATURE_FMA4,
    FEATURE_XOP and FEATURE_FMA.
    (get_amd_cpu): Handle AMD_BOBCAT, AMD_JAGUAR, AMDFAM15H_BDVER2 and
    AMDFAM15H_BDVER3.
    (get_intel_cpu): Handle INTEL_COREI7 and INTEL_COREI7_HASWELL.
        (get_available_features): Handle FEATURE_FMA, FEATURE_SSE4_A,
    FEATURE_FMA4 and FEATURE_XOP.

testsuite/

2013-12-25  Allan Sandfeld Jensen  <sandfeld@kde.org>

    PR target/59422
    * gcc.target/i386/funcspec-5.c (test_fma, test_xop, test_no_fma,
    test_no_xop, test_arch_corei7, test_arch_corei7_avx,
    test_arch_core_avx2, test_arch_bdver1, test_arch_bdver2,
    test_arch_bdver3, test_tune_corei7, test_tune_corei7_avx,
    test_tune_core_avx2, test_tune_bdver1, test_tune_bdver2 and
    test_tune_bdver3): New function prototypes.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/i386/funcspec-5.c
    trunk/libgcc/ChangeLog
    trunk/libgcc/config/i386/cpuinfo.c
    trunk/libgo/go/net/dial_test.go

[Bug target/59422] Support more targets for function multi versioning

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59422

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86
             Status|UNCONFIRMED                 |RESOLVED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2013-12/msg01862.htm
                   |                            |l
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.0

--- Comment #3 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed.
>From gcc-bugs-return-438518-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Dec 25 22:29:35 2013
Return-Path: <gcc-bugs-return-438518-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 18561 invoked by alias); 25 Dec 2013 22:29:34 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 18538 invoked by uid 48); 25 Dec 2013 22:29:31 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/59599] Compiler internal error on intrinsic ichar
Date: Wed, 25 Dec 2013 22:29:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on everconfirmed
Message-ID: <bug-59599-4-nHh9EbD0HW@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59599-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59599-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg02173.txt.bz2
Content-length: 1008

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY599

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-12-25
     Ever confirmed|0                           |1

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Reduced test

character(1) cpk(2)
integer res(2)
cpk = 'a'
res = ichar( cpk, kind=1 )
print *, ichar( cpk, kind=1 )
end

pr59599_red.f90:4:0: internal compiler error: in gfc_trans_assignment_1, at
fortran/trans-expr.c:8008
 res = ichar( cpk, kind=1 )

ICE for all revisions I have tried from 4.4.

If the line "res = ichar( cpk, kind=1 )" is commented, the ICE is

pr59599_red.f90:3:0: internal compiler error: in gfc_trans_transfer, at
fortran/trans-io.c:2324
 print *, ichar( cpk, kind=1 )

Note that cpm has to be an array.