public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug go/59430] [4.9 regression] os/user FAILs on Solaris
2013-12-09 15:29 [Bug go/59430] New: [4.9 regression] os/user FAILs on Solaris ro at gcc dot gnu.org
@ 2013-12-09 15:29 ` ro at gcc dot gnu.org
2013-12-17 18:31 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ro at gcc dot gnu.org @ 2013-12-09 15:29 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59430
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.9.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug go/59430] New: [4.9 regression] os/user FAILs on Solaris
@ 2013-12-09 15:29 ro at gcc dot gnu.org
2013-12-09 15:29 ` [Bug go/59430] " ro at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: ro at gcc dot gnu.org @ 2013-12-09 15:29 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59430
Bug ID: 59430
Summary: [4.9 regression] os/user FAILs on Solaris
Product: gcc
Version: 4.9.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: go
Assignee: ian at airs dot com
Reporter: ro at gcc dot gnu.org
Host: *-*-solaris2.*
Target: *-*-solaris2.*
Build: *-*-solaris2.*
The os/user test is now FAILing on Solaris:
--- FAIL: TestCurrent (0.00 seconds)
user_test.go:23: Current: user: lookup userid 2110: error 0
--- FAIL: TestLookup (0.00 seconds)
user_test.go:64: Current: user: lookup userid 2110: error 0
--- FAIL: TestLookupId (0.00 seconds)
user_test.go:82: Current: user: lookup userid 2110: error 0
FAIL
FAIL: os/user
I think this happens because lookup_unix.go assumes getpwnam_r and getpwuid_r
to return an int, while the Solaris functions return struct passwd unless
_POSIX_PTHREAD_SEMANTICS is defined (the POSIX.1c Draft 6 variants).
One needs to call __posix_getpwuid_r and __posix_getpwnam_r instead to get the
standard signatures.
Rainer
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug go/59430] [4.9 regression] os/user FAILs on Solaris
2013-12-09 15:29 [Bug go/59430] New: [4.9 regression] os/user FAILs on Solaris ro at gcc dot gnu.org
2013-12-09 15:29 ` [Bug go/59430] " ro at gcc dot gnu.org
@ 2013-12-17 18:31 ` jakub at gcc dot gnu.org
2014-01-08 1:08 ` ian at airs dot com
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-12-17 18:31 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59430
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P5
CC| |jakub at gcc dot gnu.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug go/59430] [4.9 regression] os/user FAILs on Solaris
2013-12-09 15:29 [Bug go/59430] New: [4.9 regression] os/user FAILs on Solaris ro at gcc dot gnu.org
2013-12-09 15:29 ` [Bug go/59430] " ro at gcc dot gnu.org
2013-12-17 18:31 ` jakub at gcc dot gnu.org
@ 2014-01-08 1:08 ` ian at airs dot com
2014-01-08 1:08 ` ian at gcc dot gnu.org
2014-01-09 12:46 ` ro at CeBiTec dot Uni-Bielefeld.DE
4 siblings, 0 replies; 6+ messages in thread
From: ian at airs dot com @ 2014-01-08 1:08 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59430
Ian Lance Taylor <ian at airs dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Ian Lance Taylor <ian at airs dot com> ---
This should be fixed now.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug go/59430] [4.9 regression] os/user FAILs on Solaris
2013-12-09 15:29 [Bug go/59430] New: [4.9 regression] os/user FAILs on Solaris ro at gcc dot gnu.org
` (2 preceding siblings ...)
2014-01-08 1:08 ` ian at airs dot com
@ 2014-01-08 1:08 ` ian at gcc dot gnu.org
2014-01-09 12:46 ` ro at CeBiTec dot Uni-Bielefeld.DE
4 siblings, 0 replies; 6+ messages in thread
From: ian at gcc dot gnu.org @ 2014-01-08 1:08 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59430
--- Comment #1 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> ---
Author: ian
Date: Wed Jan 8 01:08:29 2014
New Revision: 206412
URL: http://gcc.gnu.org/viewcvs?rev=206412&root=gcc&view=rev
Log:
PR go/59430
os/user: Use POSIX functions on Solaris.
Added:
trunk/libgo/go/os/user/decls_solaris.go
trunk/libgo/go/os/user/decls_unix.go
Modified:
trunk/libgo/Makefile.am
trunk/libgo/Makefile.in
trunk/libgo/go/os/user/lookup_unix.go
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug go/59430] [4.9 regression] os/user FAILs on Solaris
2013-12-09 15:29 [Bug go/59430] New: [4.9 regression] os/user FAILs on Solaris ro at gcc dot gnu.org
` (3 preceding siblings ...)
2014-01-08 1:08 ` ian at gcc dot gnu.org
@ 2014-01-09 12:46 ` ro at CeBiTec dot Uni-Bielefeld.DE
4 siblings, 0 replies; 6+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2014-01-09 12:46 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59430
--- Comment #3 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #2 from Ian Lance Taylor <ian at airs dot com> ---
> This should be fixed now.
Indeed, works fine everywhere.
Thanks.
Rainer
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-09 12:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-09 15:29 [Bug go/59430] New: [4.9 regression] os/user FAILs on Solaris ro at gcc dot gnu.org
2013-12-09 15:29 ` [Bug go/59430] " ro at gcc dot gnu.org
2013-12-17 18:31 ` jakub at gcc dot gnu.org
2014-01-08 1:08 ` ian at airs dot com
2014-01-08 1:08 ` ian at gcc dot gnu.org
2014-01-09 12:46 ` ro at CeBiTec dot Uni-Bielefeld.DE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).