From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27495 invoked by alias); 10 Dec 2013 23:59:13 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 27467 invoked by uid 48); 10 Dec 2013 23:59:10 -0000 From: "redi at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/59439] std::locale uses atomic instructions on construction Date: Tue, 10 Dec 2013 23:59:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: libstdc++ X-Bugzilla-Version: 4.8.3 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: redi at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2013-12/txt/msg00920.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59439 --- Comment #5 from Jonathan Wakely --- Don't do that then ;-) Noone ever claimed std::stringstream is a good way to convert integers to strings in performance critical code. Even if the std::locale construction is optimized further, stringstream still involves far more code than necessary for a simple conversion (to handle field widths, hex output and everything else that iostreams support). std::to_string() is a better alternative in C++11, re-using an existing stringstream object is another alternative, or just use your snprintf version. There's a good reason boost::lexical_cast is special-cased for the common int-to-string conversions that don't need fancy formatting.