[Bug libgomp/59467] New: copyprivate in the fortran testsuite

[Bug libgomp/59467] New: copyprivate in the fortran testsuite

[valeryweber at hotmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59467

            Bug ID: 59467
           Summary: copyprivate in the fortran testsuite
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgomp
          Assignee: unassigned at gcc dot gnu.org
          Reporter: valeryweber at hotmail dot com
                CC: jakub at gcc dot gnu.org

Dear All

the file

libgomp/testsuite/libgomp.fortran/crayptr2.f90

contains at line 26

!$omp end single copyprivate (d, ip)

but the variable "d" isnt declared as private (or threadprivate)
in its parallel region.

Isnt that a bug?

Thanks
Valery

[Bug libgomp/59467] copyprivate in the fortran testsuite

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59467

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Thu Dec 12 08:52:06 2013
New Revision: 205922

URL: http://gcc.gnu.org/viewcvs?rev=205922&root=gcc&view=rev
Log:
    PR libgomp/59467
    * gimplify.c (omp_check_private): Add copyprivate argument, if it
    is true, don't check omp_privatize_by_reference.
    (gimplify_scan_omp_clauses): For OMP_CLAUSE_COPYPRIVATE verify
    decl is private in outer context.  Adjust omp_check_private caller.

    * gfortran.dg/gomp/pr59467.f90: New test.
    * c-c++-common/gomp/pr59467.c: New test.

    * testsuite/libgomp.fortran/crayptr2.f90: Add private (d) clause to
    !$omp parallel.

Added:
    trunk/gcc/testsuite/c-c++-common/gomp/pr59467.c
    trunk/gcc/testsuite/gfortran.dg/gomp/pr59467.f90
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gimplify.c
    trunk/gcc/testsuite/ChangeLog
    trunk/libgomp/ChangeLog
    trunk/libgomp/testsuite/libgomp.fortran/crayptr2.f90

[Bug libgomp/59467] copyprivate in the fortran testsuite

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59467

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Thu Dec 12 08:57:22 2013
New Revision: 205923

URL: http://gcc.gnu.org/viewcvs?rev=205923&root=gcc&view=rev
Log:
    PR libgomp/59467
    * gimplify.c (omp_check_private): Add copyprivate argument, if it
    is true, don't check omp_privatize_by_reference.
    (gimplify_scan_omp_clauses): For OMP_CLAUSE_COPYPRIVATE verify
    decl is private in outer context.  Adjust omp_check_private caller.

    * gfortran.dg/gomp/pr59467.f90: New test.
    * c-c++-common/gomp/pr59467.c: New test.

    * testsuite/libgomp.fortran/crayptr2.f90: Add private (d) clause to
    !$omp parallel.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/c-c++-common/gomp/pr59467.c
    branches/gcc-4_8-branch/gcc/testsuite/gfortran.dg/gomp/pr59467.f90
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/gimplify.c
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_8-branch/libgomp/ChangeLog
    branches/gcc-4_8-branch/libgomp/testsuite/libgomp.fortran/crayptr2.f90

[Bug libgomp/59467] copyprivate in the fortran testsuite

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59467

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 4.8+, thanks for the report.