[Bug fortran/59493] New: internal compiler error: Segmentation fault on Class(*) pointer association with GCC 4.8.1

[Bug fortran/59493] New: internal compiler error: Segmentation fault on Class(*) pointer association with GCC 4.8.1

[talebi.hossein at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59493

            Bug ID: 59493
           Summary: internal compiler error: Segmentation fault on
                    Class(*) pointer association with GCC 4.8.1
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: talebi.hossein at gmail dot com

Hi there,

I get the segmentation fault on compilation of this code. This compiles with
Intel Fortran Compiler.


module mode1
   implicit none

   integer :: a=1

   type ty_mytype1
      integer :: b1=1
   end type ty_mytype1

   type, extends(ty_mytype1) :: ty_extend

      integer :: b2=2
   end type ty_extend


end module mode1


program hello
   use mode1
   implicit none

   class(ty_mytype1), allocatable,target:: cla1
   class(*), pointer :: ptr_cla1


   allocate(ty_extend :: cla1)

   ptr_cla1 => cla1
   print *, 'cla1%b1', cla1%b1

end program

[Bug fortran/59493] [OOP] ICE: Segfault on Class(*) pointer association

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59493

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-12-13
                 CC|                            |janus at gcc dot gnu.org
            Summary|internal compiler error:    |[OOP] ICE: Segfault on
                   |Segmentation fault on       |Class(*) pointer
                   |Class(*) pointer            |association
                   |association with GCC 4.8.1  |
     Ever confirmed|0                           |1
      Known to fail|                            |4.8.1, 4.9.0

--- Comment #1 from janus at gcc dot gnu.org ---
Confirmed with 4.9 and trunk. Slightly reduced test case:


  implicit none

  type ty_mytype1
  end type

  class(ty_mytype1), allocatable,target:: cla1
  class(*), pointer :: ptr

  ptr => cla1

end



The backtrace on trunk is:

c0.f90: In function ‘MAIN__’:
c0.f90:2:0: internal compiler error: Segmentation fault
   implicit none
 ^
0x93662f crash_signal
    /home/jweil/gcc49/trunk/gcc/toplev.c:336
0x66c231 gfc_get_derived_type(gfc_symbol*)
    /home/jweil/gcc49/trunk/gcc/fortran/trans-types.c:2351
0x66c968 gfc_typenode_for_spec(gfc_typespec*)
    /home/jweil/gcc49/trunk/gcc/fortran/trans-types.c:1112
0x66b223 gfc_sym_type(gfc_symbol*)
    /home/jweil/gcc49/trunk/gcc/fortran/trans-types.c:2137
0x66b6e8 gfc_get_function_type(gfc_symbol*)
    /home/jweil/gcc49/trunk/gcc/fortran/trans-types.c:2797
0x62cb0f build_function_decl
    /home/jweil/gcc49/trunk/gcc/fortran/trans-decl.c:1879
0x62e11b gfc_create_function_decl(gfc_namespace*, bool)
    /home/jweil/gcc49/trunk/gcc/fortran/trans-decl.c:2534
0x634f79 gfc_generate_contained_functions
    /home/jweil/gcc49/trunk/gcc/fortran/trans-decl.c:4714
0x634f79 gfc_generate_function_code(gfc_namespace*)
    /home/jweil/gcc49/trunk/gcc/fortran/trans-decl.c:5541
0x5d5710 translate_all_program_units
    /home/jweil/gcc49/trunk/gcc/fortran/parse.c:4536
0x5d5710 gfc_parse_file()
    /home/jweil/gcc49/trunk/gcc/fortran/parse.c:4733
0x611fa5 gfc_be_parse_file
    /home/jweil/gcc49/trunk/gcc/fortran/f95-lang.c:188
>From gcc-bugs-return-437506-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Dec 13 13:05:44 2013
Return-Path: <gcc-bugs-return-437506-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 1606 invoked by alias); 13 Dec 2013 13:05:43 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 1109 invoked by uid 48); 13 Dec 2013 13:05:39 -0000
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/59492] [4.9 Regression] bootstrap failure on x32 when configured with --enable-libstdcxx-debug
Date: Fri, 13 Dec 2013 13:05:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: hjl.tools at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-59492-4-7frtdpbiKD@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59492-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59492-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01161.txt.bz2
Content-length: 457

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY492

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tmsriram at google dot com

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> ---
It is caused by r205616, which fails to properly save and restore all
compiler options.

[Bug fortran/59493] [OOP] ICE: Segfault on Class(*) pointer association

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59493

--- Comment #2 from janus at gcc dot gnu.org ---
(In reply to janus from comment #1)
> Confirmed with 4.9 and trunk.

Sorry, that was supposed to be "4.8 and trunk", obviously ;)

[Bug fortran/59493] [OOP] ICE: Segfault on Class(*) pointer association

[talebi.hossein at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59493

--- Comment #3 from Hossein Talebi <talebi.hossein at gmail dot com> ---

Will it be fixed in gfortran 4.8 or 4.9?

[Bug fortran/59493] [OOP] ICE: Segfault on Class(*) pointer association

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59493

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |janus at gcc dot gnu.org

--- Comment #4 from janus at gcc dot gnu.org ---
(In reply to Hossein Talebi from comment #3)
> Will it be fixed in gfortran 4.8 or 4.9?

Since I already found out what goes wrong, it will pretty certainly get fixed
on the trunk (to-be-4.9) soon. Since it is not a regression, probably no
backporting to 4.8 will be done.

In any case: The problem was that 'gfc_find_intrinsic_vtab' failed to handle
BT_CLASS. The following patch fixes it (and does some minor cleanup):

Index: gcc/fortran/class.c
===================================================================
--- gcc/fortran/class.c    (revision 205948)
+++ gcc/fortran/class.c    (working copy)
@@ -2413,29 +2413,34 @@ gfc_find_intrinsic_vtab (gfc_typespec *ts)
   gfc_symbol *copy = NULL, *src = NULL, *dst = NULL;
   int charlen = 0;

-  if (ts->type == BT_CHARACTER && ts->deferred)
+  switch (ts->type)
     {
-      gfc_error ("TODO: Deferred character length variable at %C cannot "
-         "yet be associated with unlimited polymorphic entities");
+    case BT_UNKNOWN:
       return NULL;
+    case BT_DERIVED:
+      return gfc_find_derived_vtab (ts->u.derived);
+    case BT_CLASS:
+      return gfc_find_derived_vtab (ts->u.derived->components->ts.u.derived);
+    case (BT_CHARACTER):
+      if (ts->deferred)
+    {
+      gfc_error ("TODO: Deferred character length variable at %C cannot "
+            "yet be associated with unlimited polymorphic entities");
+      return NULL;
+    }
+      else if (ts->u.cl && ts->u.cl->length
+           && ts->u.cl->length->expr_type == EXPR_CONSTANT)
+    charlen = mpz_get_si (ts->u.cl->length->value.integer);
+      break;
+    default:
+      break;
     }

-  if (ts->type == BT_UNKNOWN)
-    return NULL;
-
-  /* Sometimes the typespec is passed from a single call.  */
-  if (ts->type == BT_DERIVED)
-    return gfc_find_derived_vtab (ts->u.derived);
-
   /* Find the top-level namespace.  */
   for (ns = gfc_current_ns; ns; ns = ns->parent)
     if (!ns->parent)
       break;

-  if (ts->type == BT_CHARACTER && ts->u.cl && ts->u.cl->length
-      && ts->u.cl->length->expr_type == EXPR_CONSTANT)
-    charlen = mpz_get_si (ts->u.cl->length->value.integer);
-
   if (ns)
     {
       char name[GFC_MAX_SYMBOL_LEN+1], tname[GFC_MAX_SYMBOL_LEN+1];

[Bug fortran/59493] [OOP] ICE: Segfault on Class(*) pointer association

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59493

--- Comment #5 from janus at gcc dot gnu.org ---
Here is a simpler patch (which could even be considered for backporting to
4.8):


Index: gcc/fortran/class.c
===================================================================
--- gcc/fortran/class.c    (revision 205982)
+++ gcc/fortran/class.c    (working copy)
@@ -2424,7 +2424,7 @@ gfc_find_intrinsic_vtab (gfc_typespec *ts)
     return NULL;

   /* Sometimes the typespec is passed from a single call.  */
-  if (ts->type == BT_DERIVED)
+  if (ts->type == BT_DERIVED || ts->type == BT_CLASS)
     return gfc_find_derived_vtab (ts->u.derived);

   /* Find the top-level namespace.  */

[Bug fortran/59493] [OOP] ICE: Segfault on Class(*) pointer association

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59493

--- Comment #6 from janus at gcc dot gnu.org ---
(In reply to janus from comment #5)
> Here is a simpler patch (which could even be considered for backporting to
> 4.8):

Just verified that it is free of testsuite regressions.

[Bug fortran/59493] [OOP] ICE: Segfault on Class(*) pointer association

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59493

--- Comment #7 from janus at gcc dot gnu.org ---
Author: janus
Date: Sun Dec 15 09:49:51 2013
New Revision: 205997

URL: http://gcc.gnu.org/viewcvs?rev=205997&root=gcc&view=rev
Log:
2013-12-15  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/59493
    * class.c (gfc_find_intrinsic_vtab): Handle BT_CLASS.


2013-12-15  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/59493
    * gfortran.dg/unlimited_polymorphic_15.f90: New.

Added:
    trunk/gcc/testsuite/gfortran.dg/unlimited_polymorphic_15.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/class.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/59493] [OOP] ICE: Segfault on Class(*) pointer association

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59493

--- Comment #8 from janus at gcc dot gnu.org ---
Author: janus
Date: Wed Dec 18 12:36:00 2013
New Revision: 206085

URL: http://gcc.gnu.org/viewcvs?rev=206085&root=gcc&view=rev
Log:
2013-12-18  Janus Weil  <janus@gcc.gnu.org>

    Backport from mainline
    2013-12-15  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/59493
    * class.c (gfc_find_intrinsic_vtab): Handle BT_CLASS.

2013-12-18  Janus Weil  <janus@gcc.gnu.org>

    Backport from mainline
    2013-12-15  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/59493
    * gfortran.dg/unlimited_polymorphic_15.f90: New.

Added:
   
branches/gcc-4_8-branch/gcc/testsuite/gfortran.dg/unlimited_polymorphic_15.f90
Modified:
    branches/gcc-4_8-branch/gcc/fortran/ChangeLog
    branches/gcc-4_8-branch/gcc/fortran/class.c
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog

[Bug fortran/59493] [OOP] ICE: Segfault on Class(*) pointer association

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59493

--- Comment #9 from janus at gcc dot gnu.org ---
The fix has been committed to trunk and the 4.8 branch, so that it will be
included in the upcoming releases 4.9.0 and 4.8.3.

[Bug fortran/59493] [OOP] ICE: Segfault on Class(*) pointer association

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59493

--- Comment #10 from janus at gcc dot gnu.org ---
Author: janus
Date: Wed Dec 18 22:00:53 2013
New Revision: 206101

URL: http://gcc.gnu.org/viewcvs?rev=206101&root=gcc&view=rev
Log:
2013-12-18  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/59493
    * gfortran.h (gfc_find_intrinsic_vtab): Removed prototype.
    (gfc_find_vtab): New prototype.
    * class.c (gfc_find_intrinsic_vtab): Rename to 'find_intrinsic_vtab' and
    make static. Minor modifications.
    (gfc_find_vtab): New function.
    (gfc_class_initializer): Use new function 'gfc_find_vtab'.
    * check.c (gfc_check_move_alloc): Ditto.
    * expr.c (gfc_check_pointer_assign): Ditto.
    * interface.c (compare_actual_formal): Ditto.
    * resolve.c (resolve_allocate_expr, resolve_select_type): Ditto.
    * trans-expr.c (gfc_conv_intrinsic_to_class, gfc_trans_class_assign):
    Ditto.
    * trans-intrinsic.c (conv_intrinsic_move_alloc): Ditto.
    * trans-stmt.c (gfc_trans_allocate): Ditto.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/check.c
    trunk/gcc/fortran/class.c
    trunk/gcc/fortran/expr.c
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/interface.c
    trunk/gcc/fortran/resolve.c
    trunk/gcc/fortran/trans-expr.c
    trunk/gcc/fortran/trans-intrinsic.c
    trunk/gcc/fortran/trans-stmt.c

[Bug fortran/59493] [OOP] ICE: Segfault on Class(*) pointer association

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59493

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from janus at gcc dot gnu.org ---
After it has been fixed on 4.8 and trunk (with some additional cleanup on
trunk), I think this PR can be closed. Thanks for reporting!