[Bug sanitizer/59503] New: Bogus integer-overflow error with long long with -m32

[Bug sanitizer/59503] New: Bogus integer-overflow error with long long with -m32

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59503

            Bug ID: 59503
           Summary: Bogus integer-overflow error with long long with -m32
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: mpolacek at gcc dot gnu.org
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org

We wrongly issue runtime error on:

int
main (void)
{
  long long int a = 14;
  long int b = 9;
  if ((a - b) != 5)
    __builtin_abort ();
  return 0;
}

$ gcc -O0 -fsanitize=signed-integer-overflow -m32 bug.c
$ ./a.out
bug.c:6:10: runtime error: signed integer overflow: 14 - 9 cannot be
represented in type 'long long int'
Aborted

This happens on PPC64 as well, as the bug is in generic handling of add/sub
instrumentation.

[Bug sanitizer/59503] Bogus integer-overflow error with long long with -m32

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59503

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2013-12-14
           Assignee|unassigned at gcc dot gnu.org      |mpolacek at gcc dot gnu.org
   Target Milestone|---                         |4.9.0
     Ever confirmed|0                           |1

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
I have a fix.

[Bug sanitizer/59503] Bogus integer-overflow error with long long with -m32

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59503

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.

[Bug sanitizer/59503] Bogus integer-overflow error with long long with -m32

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59503

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Sat Dec 14 12:19:56 2013
New Revision: 205984

URL: http://gcc.gnu.org/viewcvs?rev=205984&root=gcc&view=rev
Log:
    PR sanitizer/59503
    * internal-fn.c (ubsan_expand_si_overflow_addsub_check): Call
    expand_binop with correct optab depending on code.
testsuite/
    * c-c++-common/ubsan/pr59503.c: New test.


Added:
    trunk/gcc/testsuite/c-c++-common/ubsan/pr59503.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/internal-fn.c
    trunk/gcc/testsuite/ChangeLog