[Bug rtl-optimization/59511] New: [4.9 Regression] FAIL: gcc.target/i386/pr36222-1.c scan-assembler-not movdqa with -mtune=corei7

[Bug rtl-optimization/59511] New: [4.9 Regression] FAIL: gcc.target/i386/pr36222-1.c scan-assembler-not movdqa with -mtune=corei7

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59511

            Bug ID: 59511
           Summary: [4.9 Regression] FAIL: gcc.target/i386/pr36222-1.c
                    scan-assembler-not movdqa with -mtune=corei7
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ubizjak at gmail dot com

Hello!

The gcc.target/i386/pr36222-1.c compiles for x86_64-linux-gnu with "-O2
-mno-sse3 -mtune=corei7" to:

_mm_set_epi32:
        movd    %ecx, %xmm1
        movd    %edx, %xmm4
        movd    %esi, %xmm0
        movd    %edi, %xmm3
        punpckldq       %xmm4, %xmm1
        movdqa  %xmm1, %xmm2
        punpckldq       %xmm3, %xmm0
        punpcklqdq      %xmm0, %xmm2
        movdqa  %xmm2, %xmm0
        ret

However, 4.8 branch compiles to:

_mm_set_epi32:
        movd    %esi, %xmm1
        movd    %edi, %xmm2
        movd    %ecx, %xmm0
        movd    %edx, %xmm3
        punpckldq       %xmm2, %xmm1
        punpckldq       %xmm3, %xmm0
        punpcklqdq      %xmm1, %xmm0
        ret

[Bug rtl-optimization/59511] [4.9 Regression] FAIL: gcc.target/i386/pr36222-1.c scan-assembler-not movdqa with -mtune=corei7

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59511

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ra
             Target|                            |x86_64-pc-linux-gnu
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-12-15
                 CC|                            |vmakarov at gcc dot gnu.org
   Target Milestone|---                         |4.9.0
     Ever confirmed|0                           |1

--- Comment #1 from Uroš Bizjak <ubizjak at gmail dot com> ---
Confirmed as RA regression.
>From gcc-bugs-return-437622-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Dec 15 12:23:00 2013
Return-Path: <gcc-bugs-return-437622-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 32300 invoked by alias); 15 Dec 2013 12:23:00 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 32253 invoked by uid 48); 15 Dec 2013 12:22:55 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/58630] [4.9 Regression] Revision 203171 breaks several MS-ABI tests
Date: Sun, 15 Dec 2013 12:23:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: testsuite
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: component
Message-ID: <bug-58630-4-lBiECqW33s@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58630-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58630-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01277.txt.bz2
Content-length: 668

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58630

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|target                      |testsuite

--- Comment #8 from Uroš Bizjak <ubizjak at gmail dot com> ---
This is a testsuite bug. ms_abi option requires -maccumulate-outgoung-args, and
this is documented in option documentation. The patch adds new target tuning
option that avoids setting this flag for certain targets (i.e. corei7)
automatically. The ms-abi test cases must set this option in any case.
>From gcc-bugs-return-437623-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Dec 15 12:25:23 2013
Return-Path: <gcc-bugs-return-437623-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 1547 invoked by alias); 15 Dec 2013 12:25:23 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 1492 invoked by uid 48); 15 Dec 2013 12:25:19 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/58630] [4.9 Regression] Revision 203171 breaks several MS-ABI tests
Date: Sun, 15 Dec 2013 12:25:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: testsuite
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-58630-4-Tnxwdv3FUB@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58630-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58630-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01278.txt.bz2
Content-length: 3252

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58630

--- Comment #9 from Uroš Bizjak <ubizjak at gmail dot com> ---
Author: uros
Date: Sun Dec 15 11:20:53 2013
New Revision: 205998

URL: http://gcc.gnu.org/viewcvs?rev=205998&root=gcc&view=rev
Log:
    * gcc.target/i386/pr43662.c (dg-options):
    Add -maccumulate-outgoing-args.
    * gcc.target/i386/pr43869.c (dg-options): Ditto.
    * gcc.target/i386/pr57003.c (dg-options): Ditto.
    * gcc.target/i386/avx-vzeroupper-16.c (dg-options):
    Remove -mtune=generic and add -maccumulate-outgoing-args instead.
    * gcc.target/i386/avx-vzeroupper-17.c (dg-options): Ditto.
    * gcc.target/i386/avx-vzeroupper-18.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/func-1.c (dg-options):
    Add -maccumulate-outgoing-args.
    * gcc.target/x86_64/abi/callabi/func-2a.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/func-2b.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/func-indirect.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/func-indirect-2a.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/func-indirect-2b.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/leaf-1.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/leaf-2.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/pr38891.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/vaarg-1.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/vaarg-2.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/vaarg-3.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/vaarg-4a.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/vaarg-4b.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/vaarg-5a.c (dg-options): Ditto.
    * gcc.target/x86_64/abi/callabi/vaarg-5b.c (dg-options): Ditto.


Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/i386/avx-vzeroupper-16.c
    trunk/gcc/testsuite/gcc.target/i386/avx-vzeroupper-17.c
    trunk/gcc/testsuite/gcc.target/i386/avx-vzeroupper-18.c
    trunk/gcc/testsuite/gcc.target/i386/pr43662.c
    trunk/gcc/testsuite/gcc.target/i386/pr43869.c
    trunk/gcc/testsuite/gcc.target/i386/pr57003.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/func-1.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/func-2a.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/func-2b.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/func-indirect-2a.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/func-indirect-2b.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/func-indirect.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/leaf-1.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/leaf-2.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/pr38891.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-1.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-2.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-3.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-4a.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-4b.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-5a.c
    trunk/gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-5b.c
>From gcc-bugs-return-437624-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Dec 15 12:27:14 2013
Return-Path: <gcc-bugs-return-437624-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 2647 invoked by alias); 15 Dec 2013 12:27:14 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 2608 invoked by uid 48); 15 Dec 2013 12:27:07 -0000
From: "doront at mellanox dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/59495] -ftrack-macro-expansion=2 ignores warnings originated from /usr/include headers
Date: Sun, 15 Dec 2013 12:27:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: doront at mellanox dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59495-4-5hbJZOfuU5@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59495-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59495-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01279.txt.bz2
Content-length: 1942

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY495

--- Comment #3 from Doron Tsur <doront at mellanox dot com> ---
It is probably a false positive bug - warning is undetected.

Consider the following code:

$ cat define_compare_test.c
#include "define_compare_test.h"
#include <stdio.h>

int main(int argc __attribute__((unused)), char** argv __attribute__((unused)))
{
        const int number_int = -1;
        const unsigned int number_unsigned_int = 0xFFFFFFFF;

        printf("%d and %u are %s\n", number_int, number_unsigned_int,
               DEFINE_COMPARE(number_int, number_unsigned_int) );
        return 0;
}

$ cat define_compare_test/define_compare_test.h

#define DEFINE_COMPARE(X,Y) \
                ((X)==(Y)) ? "equal" : "different"

$ ... cp -v define_compare_test/define_compare_test.h /usr/include
'define_compare_test/define_compare_test.h' ->
'/usr/include/define_compare_test.h'

$ gcc -Wall -Wextra -Werror  define_compare_test.c -I define_compare_test -H
. define_compare_test/define_compare_test.h
...
In file included from define_compare_test.c:1:0:
define_compare_test.c: In function 'main':
define_compare_test/define_compare_test.h:3:7: error: comparison between signed
and unsigned integer expressions [-Werror=sign-compare]
   ((X)==(Y)) ? "equal" : "different"
       ^
define_compare_test.c:9:9: note: in expansion of macro 'DEFINE_COMPARE'
         DEFINE_COMPARE(number_int, number_unsigned_int) );
         ^
Multiple include guards may be useful for:
/usr/include/wchar.h
...
/usr/include/x86_64-linux-gnu/gnu/stubs.h
define_compare_test/define_compare_test.h
cc1: all warnings being treated as errors

$ gcc -Wall -Wextra -Werror  define_compare_test.c -H
. /usr/include/define_compare_test.h
. /usr/include/stdio.h
...
Multiple include guards may be useful for:
/usr/include/define_compare_test.h
/usr/include/wchar.h
...
$ ./a.out
-1 and 4294967295 are equal

[Bug rtl-optimization/59511] [4.9 Regression] FAIL: gcc.target/i386/pr36222-1.c scan-assembler-not movdqa with -mtune=corei7

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59511

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
One movdqa started appearing with r204212, the second movdqa started appearing
with r204752.  Vlad, can you please have a look?

[Bug rtl-optimization/59511] [4.9 Regression] FAIL: gcc.target/i386/pr36222-1.c scan-assembler-not movdqa with -mtune=corei7

[vmakarov at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59511

--- Comment #3 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #2)
> One movdqa started appearing with r204212, the second movdqa started
> appearing with r204752.  Vlad, can you please have a look?

It seems the changes triggered a bug in register move cost calculations.  I
have a patch to fix it but I need more time to check affect of it on the
performance.  So the fix will be ready at the end of week if everything is ok.

[Bug rtl-optimization/59511] [4.9 Regression] FAIL: gcc.target/i386/pr36222-1.c scan-assembler-not movdqa with -mtune=corei7

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59511

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug rtl-optimization/59511] [4.9 Regression] FAIL: gcc.target/i386/pr36222-1.c scan-assembler-not movdqa with -mtune=corei7

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59511

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed, thanks.