[Bug gcov-profile/59527] [4.9 Regression] ICE: in fixup_reorder_chain, at cfgrtl.c:3739 during PGO Firefox build

["tejohnson at google dot com" <gcc-bugzilla@gcc.gnu.org>]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527

--- Comment #8 from Teresa Johnson <tejohnson at google dot com> ---
I can't reproduce this one using your source/profles and command line
(using a trunk updated to head last night plus my fix for the assert).
I verified that splitting is kicking in, but no error occurs. Do you
want to generate and tar up the dumps, and I can try to figure out
what might be going on from that?

Thanks,
Teresa

On Tue, Dec 17, 2013 at 11:48 AM, trippels at gcc dot gnu.org
<gcc-bugzilla@gcc.gnu.org> wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527
>
> --- Comment #6 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
> The testcase is too big to attach.
>
>  % wget trippelsdorf.de/testcase.tar.bz2
>  % tar xvjf testcase.tar.bz2
>  % g++ -w -nostdlib -r -flto=4 -fprofile-use -fprofile-correction
> -march=amdfam10 -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pipe
> -O3 Unified_cpp_7.ii Unified_cpp_8.ii
>
> /var/tmp/mozilla-central/js/src/vm/Interpreter.cpp: In function ‘Interpret’:
> /var/tmp/mozilla-central/js/src/vm/Interpreter.cpp:3469:1: error: non-cold
> basic block 39 dominated by a block in the cold partition (2517)
>  }
>  ^
> /var/tmp/mozilla-central/js/src/vm/Interpreter.cpp:3469:1: internal compiler
> error: verify_flow_info failed
> 0x5a1ecd verify_flow_info()
>         ../../gcc/gcc/cfghooks.c:260
> 0x5b4ee2 cfg_layout_finalize()
>         ../../gcc/gcc/cfgrtl.c:4286
> 0xd44662 duplicate_computed_gotos
>         ../../gcc/gcc/bb-reorder.c:2492
> 0xd44662 execute
>         ../../gcc/gcc/bb-reorder.c:2524
> Please submit a full bug report,
> with preprocessed source if appropriate.
> Please include the complete backtrace with any bug report.
> See <http://gcc.gnu.org/bugs.html> for instructions.
> make: *** [/tmp/ccvLwfUA.ltrans0.ltrans.o] Error 1
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
>From gcc-bugs-return-437945-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Dec 18 07:22:13 2013
Return-Path: <gcc-bugs-return-437945-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 26343 invoked by alias); 18 Dec 2013 07:22:12 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 26300 invoked by uid 48); 18 Dec 2013 07:22:08 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/59534] [4.9 Regression] FAIL: libgomp.fortran/retval1.f90  execution test due to denormals
Date: Wed, 18 Dec 2013 07:22:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: testsuite
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status bug_file_loc resolution target_milestone
Message-ID: <bug-59534-4-3KdccVaJYB@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59534-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59534-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01600.txt.bz2
Content-length: 758

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59534

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2013-12/msg01505.htm
                   |                            |l
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.0

--- Comment #11 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed [1].

[1] http://gcc.gnu.org/ml/gcc-testresults/2013-12/msg01719.html
>From gcc-bugs-return-437946-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Dec 18 07:46:44 2013
Return-Path: <gcc-bugs-return-437946-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 3728 invoked by alias); 18 Dec 2013 07:46:44 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 3682 invoked by uid 48); 18 Dec 2013 07:46:39 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/59541] New: [4.9 Regression] Revision 206070 breaks bootstrap on darwin
Date: Wed, 18 Dec 2013 07:46:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc cf_gcctarget
Message-ID: <bug-59541-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01601.txt.bz2
Content-length: 2734

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY541

            Bug ID: 59541
           Summary: [4.9 Regression] Revision 206070 breaks bootstrap on
                    darwin
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dominiq at lps dot ens.fr
                CC: howarth at bromo dot med.uc.edu, iains at gcc dot gnu.org,
                    marxin.liska at gmail dot com
            Target: *-*-darwin*

Revision 206070 breaks bootstrap on darwin:

/opt/gcc/build_c/./prev-gcc/xg++ -B/opt/gcc/build_c/./prev-gcc/
-B/opt/gcc/gcc4.9c/x86_64-apple-darwin13.0.0/bin/ -nostdinc++
-B/opt/gcc/build_c/prev-x86_64-apple-darwin13.0.0/libstdc++-v3/src/.libs
-B/opt/gcc/build_c/prev-x86_64-apple-darwin13.0.0/libstdc++-v3/libsupc++/.libs
-I/opt/gcc/build_c/prev-x86_64-apple-darwin13.0.0/libstdc++-v3/include/x86_64-apple-darwin13.0.0
-I/opt/gcc/build_c/prev-x86_64-apple-darwin13.0.0/libstdc++-v3/include
-I/opt/gcc/_clean/libstdc++-v3/libsupc++
-L/opt/gcc/build_c/prev-x86_64-apple-darwin13.0.0/libstdc++-v3/src/.libs
-L/opt/gcc/build_c/prev-x86_64-apple-darwin13.0.0/libstdc++-v3/libsupc++/.libs
-c   -g -O2  -gtoggle -DIN_GCC    -fno-exceptions -fno-rtti
-fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common
-DHAVE_CONFIG_H -I. -I. -I../../_clean/gcc -I../../_clean/gcc/.
-I../../_clean/gcc/../include -I./../intl -I../../_clean/gcc/../libcpp/include
-I/opt/mp/include  -I../../_clean/gcc/../libdecnumber
-I../../_clean/gcc/../libdecnumber/dpd -I../libdecnumber
-I../../_clean/gcc/../libbacktrace -DCLOOG_INT_GMP  -I/opt/mp/include  -o
darwin.o -MT darwin.o -MMD -MP -MF ./.deps/darwin.TPo
../../_clean/gcc/config/darwin.c
../../_clean/gcc/config/darwin.c: In function 'section*
darwin_function_section(tree, node_frequency, bool, bool)':
../../_clean/gcc/config/darwin.c:3665:1: error: control reaches end of non-void
function [-Werror=return-type]
 }
 ^
cc1plus: all warnings being treated as errors

I fixed it with the following patch:

--- ../_clean/gcc/config/darwin.c    2013-12-17 23:28:53.000000000 +0100
+++ gcc/config/darwin.c    2013-12-18 00:46:28.000000000 +0100
@@ -3654,7 +3654,8 @@ darwin_function_section (tree decl, enum
           return (weak)
                   ? darwin_sections[text_hot_coal_section]
                   : darwin_sections[text_hot_section];
-        break;
+    else
+      return text_section;
       }
       default:
     return (weak)

Testing in progress.