[Bug gcov-profile/59527] New: [4.9 Regression] ICE: in fixup_reorder_chain, at cfgrtl.c:3739 during PGO Firefox build

[Bug gcov-profile/59527] New: [4.9 Regression] ICE: in fixup_reorder_chain, at cfgrtl.c:3739 during PGO Firefox build

[octoploid at yandex dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527

            Bug ID: 59527
           Summary: [4.9 Regression] ICE: in fixup_reorder_chain, at
                    cfgrtl.c:3739 during PGO Firefox build
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: gcov-profile
          Assignee: unassigned at gcc dot gnu.org
          Reporter: octoploid at yandex dot com

src % /var/tmp/gcc_test/usr/local/bin/g++ -w -r -nostdlib -o js -flto=4
-fprofile-use -fprofile-correction -march=native -fno-rtti -fno-exceptions
-fno-math-errno -std=gnu++0x -pthread -pipe -O3 Unified_cpp_9.ii
...
/var/tmp/mozilla-central/js/src/vm/Stack.cpp: In member function ‘operator++’:
/var/tmp/mozilla-central/js/src/vm/Stack.cpp:717:1: internal compiler error: in
fixup_reorder_chain, at cfgrtl.c:3739
 }
 ^
0x5b594c fixup_reorder_chain
        ../../gcc/gcc/cfgrtl.c:3738
0x5b594c cfg_layout_finalize()
        ../../gcc/gcc/cfgrtl.c:4295
0xd42eb2 duplicate_computed_gotos
        ../../gcc/gcc/bb-reorder.c:2492
0xd42eb2 execute
        ../../gcc/gcc/bb-reorder.c:2524
Please submit a full bug report,

-fno-reorder-blocks-and-partition fixes the issue.

I'm currently reducing this further.
>From gcc-bugs-return-437729-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Dec 16 14:13:38 2013
Return-Path: <gcc-bugs-return-437729-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 12096 invoked by alias); 16 Dec 2013 14:13:37 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 12050 invoked by uid 48); 16 Dec 2013 14:13:32 -0000
From: "jamborm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/59008] [4.9 Regression] ICEs in try_make_edge_direct_simple_call / propagate_controlled_uses
Date: Mon, 16 Dec 2013 14:13:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jamborm at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: jamborm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cc assigned_to
Message-ID: <bug-59008-4-1QsPXjDn4i@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59008-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59008-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01384.txt.bz2
Content-length: 594

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY008

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jamborm at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |jamborm at gcc dot gnu.org

--- Comment #4 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Indeed. Unfortunately, I will not be able to take a look until January.

[Bug gcov-profile/59527] [4.9 Regression] ICE: in fixup_reorder_chain, at cfgrtl.c:3739 during PGO Firefox build

[octoploid at yandex dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527

--- Comment #1 from Markus Trippelsdorf <octoploid at yandex dot com> ---
Created attachment 31447
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=31447&action=edit
unreduced testcase

 % g++ -w -r -nostdlib -fprofile-use -fprofile-correction -march=amdfam10
-fno-exceptions -std=gnu++0x -O3 test.ii
In file included from /var/tmp/moz-build-dir/js/src/Unified_cpp_9.cpp:101:0:
/var/tmp/mozilla-central/js/src/vm/Stack.cpp: In member function
‘js::ScriptFrameIter& js::ScriptFrameIter::operator++()’:
/var/tmp/mozilla-central/js/src/vm/Stack.cpp:717:1: internal compiler error: in
fixup_reorder_chain, at cfgrtl.c:3739
>From gcc-bugs-return-437743-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Dec 16 16:26:39 2013
Return-Path: <gcc-bugs-return-437743-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 30502 invoked by alias); 16 Dec 2013 16:26:39 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 30466 invoked by uid 48); 16 Dec 2013 16:26:36 -0000
From: "jamborm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/59471] [4.9 Regression] ICE using vector extensions (non-top-level BIT_FIELD_REF, IMAGPART_EXPR or REALPART_EXPR)
Date: Mon, 16 Dec 2013 16:26:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jamborm at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59471-4-RgdHqSvVtN@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59471-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59471-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01398.txt.bz2
Content-length: 604

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY471

--- Comment #3 from Martin Jambor <jamborm at gcc dot gnu.org> ---
It should be easy to make SRA safely cope with BIT_FIELD_REFs,
REALPART_EXPRs and IMAGPART_EXPRs under a VIEW_CONVERT_EXPR (as
opposed to those under a COMPONENT_REF, ARRAY_REF, MEM_REF or
similar).  I'd prefer it over detecting the other cases if it is
enough to relax the verification in this way.

I just wonder why do we have VIEW_CONVERT_EXPRs of BIT_FIELD_REFs at
all, can't we fold them just to one B_F_R with the expected final
type?  Or does it have some different semantics?

[Bug gcov-profile/59527] [4.9 Regression] ICE: in fixup_reorder_chain, at cfgrtl.c:3739 during PGO Firefox build

[tejohnson at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527

--- Comment #3 from Teresa Johnson <tejohnson at google dot com> ---
On Mon, Dec 16, 2013 at 10:41 AM, Teresa Johnson <tejohnson@google.com> wrote:
> I will take a look and report back. -freorder-blocks-and-partition was
> recently enabled by default, which presumably exposed this issue.

The issue is that there is a region crossing branch that cannot be
optimized away (since it is needed to cross the region boundary), and
fixup_reorder_chain was not handling this case. In the case where
there was no fallthru for a conditional jump the comments indicate
that this can happen if the conditional jump has side effects and
can't be deleted, in which case a barrier is inserted and no change is
made to the branch. In this case since the branch is region crossing
it also cannot be eliminated, but the assert was not handling that
case. I fixed by simply adding a check for it to the assert.

This routine already has some handling for region-crossing branches,
but it was only handling the case where there was both a taken and
fallthru edge. In this case we had no fallthru. The reason was that
the fallthru had been eliminated in an earlier round of cfg
optimizations when going in/out of cfglayout mode during
pro_and_epilogue. The fallthru was an empty block that appears to be
due to switch expansion with the case having a
__builtin_unreachable().

Here is the patch that fixes the issue, regression testing in progress:

2013-12-17  Teresa Johnson  <tejohnson@google.com>

        * cfgrtl.c (fixup_reorder_chain): Handle a region-crossing
        branch, which can't be eliminated.

Index: cfgrtl.c
===================================================================
--- cfgrtl.c    (revision 206033)
+++ cfgrtl.c    (working copy)
@@ -3736,7 +3736,8 @@ fixup_reorder_chain (void)
              if (!e_fall)
                {
                  gcc_assert (!onlyjump_p (bb_end_insn)
-                             || returnjump_p (bb_end_insn));
+                             || returnjump_p (bb_end_insn)
+                              || (e_taken->flags & EDGE_CROSSING));
                  emit_barrier_after (bb_end_insn);
                  continue;
                }


Thanks,
Teresa

> Thanks,
> Teresa
>
> On Mon, Dec 16, 2013 at 8:21 AM, octoploid at yandex dot com
> <gcc-bugzilla@gcc.gnu.org> wrote:
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527
>>
>> --- Comment #1 from Markus Trippelsdorf <octoploid at yandex dot com> ---
>> Created attachment 31447
>>   --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=31447&action=edit
>> unreduced testcase
>>
>>  % g++ -w -r -nostdlib -fprofile-use -fprofile-correction -march=amdfam10
>> -fno-exceptions -std=gnu++0x -O3 test.ii
>> In file included from /var/tmp/moz-build-dir/js/src/Unified_cpp_9.cpp:101:0:
>> /var/tmp/mozilla-central/js/src/vm/Stack.cpp: In member function
>> ‘js::ScriptFrameIter& js::ScriptFrameIter::operator++()’:
>> /var/tmp/mozilla-central/js/src/vm/Stack.cpp:717:1: internal compiler error: in
>> fixup_reorder_chain, at cfgrtl.c:3739
>>
>> --
>> You are receiving this mail because:
>> You are on the CC list for the bug.
>
>
>
> --
> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
>From gcc-bugs-return-437847-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Dec 17 14:46:52 2013
Return-Path: <gcc-bugs-return-437847-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 11126 invoked by alias); 17 Dec 2013 14:46:52 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 10885 invoked by uid 48); 17 Dec 2013 14:46:48 -0000
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/59486] math functions take more cycles after running any Intel AVX function
Date: Tue, 17 Dec 2013 14:46:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.4.6
X-Bugzilla-Keywords:
X-Bugzilla-Severity: major
X-Bugzilla-Who: hjl.tools at gmail dot com
X-Bugzilla-Status: REOPENED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on version resolution everconfirmed
Message-ID: <bug-59486-4-gjj76eg7kw@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59486-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59486-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01502.txt.bz2
Content-length: 618

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY486

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
   Last reconfirmed|                            |2013-12-17
            Version|unknown                     |4.4.6
         Resolution|INVALID                     |---
     Ever confirmed|0                           |1

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
It was fixed in GCC 4.6 by adding -mvzeroupper.

[Bug gcov-profile/59527] [4.9 Regression] ICE: in fixup_reorder_chain, at cfgrtl.c:3739 during PGO Firefox build

[trippels at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |trippels at gcc dot gnu.org

--- Comment #4 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Teresa,

I've tested your patch but the Firefox build still fails:

/var/tmp/mozilla-central/js/src/vm/Interpreter.cpp: In function ‘Interpret’:
/var/tmp/mozilla-central/js/src/vm/Interpreter.cpp:3469:1: error: non-cold
basic block 37 dominated by a block in the cold partition (2441)
 }
 ^
/var/tmp/mozilla-central/js/src/vm/Interpreter.cpp:3469:1: internal compiler
error: verify_flow_info failed
0x5a1ecd verify_flow_info()
        ../../gcc/gcc/cfghooks.c:260
0x5b4ee2 cfg_layout_finalize()
        ../../gcc/gcc/cfgrtl.c:4286
0xd44662 duplicate_computed_gotos
        ../../gcc/gcc/bb-reorder.c:2492
0xd44662 execute
        ../../gcc/gcc/bb-reorder.c:2524
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
make[8]: *** [/tmp/ccN0aFCW.ltrans17.ltrans.o] Error 1
>From gcc-bugs-return-437894-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Dec 17 18:48:10 2013
Return-Path: <gcc-bugs-return-437894-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 23832 invoked by alias); 17 Dec 2013 18:48:09 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 23805 invoked by uid 48); 17 Dec 2013 18:48:06 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libfortran/59513] Fortran runtime error: Sequential READ or WRITE not allowed after EOF marker, possibly use REWIND or BACKSPACE
Date: Tue, 17 Dec 2013 18:48:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libfortran
X-Bugzilla-Version: 4.7.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59513-4-u3J8rEpVOb@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59513-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59513-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01549.txt.bz2
Content-length: 304

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY513

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
I installed foil today through fink and noticed that the fortran files are
compiled (gfortran 4.8.2) with '-O0 -fdefault-real-8 -fdefault-integer-8'. Are
you using these options?

[Bug gcov-profile/59527] [4.9 Regression] ICE: in fixup_reorder_chain, at cfgrtl.c:3739 during PGO Firefox build

[tejohnson at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527

--- Comment #5 from Teresa Johnson <tejohnson at google dot com> ---
This seems like a separate issue - can you give me a reproducer? The
attached minimized test case does not hit this.

Thanks,
Teresa

On Tue, Dec 17, 2013 at 10:45 AM, trippels at gcc dot gnu.org
<gcc-bugzilla@gcc.gnu.org> wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527
>
> Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |trippels at gcc dot gnu.org
>
> --- Comment #4 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
> Teresa,
>
> I've tested your patch but the Firefox build still fails:
>
> /var/tmp/mozilla-central/js/src/vm/Interpreter.cpp: In function ‘Interpret’:
> /var/tmp/mozilla-central/js/src/vm/Interpreter.cpp:3469:1: error: non-cold
> basic block 37 dominated by a block in the cold partition (2441)
>  }
>  ^
> /var/tmp/mozilla-central/js/src/vm/Interpreter.cpp:3469:1: internal compiler
> error: verify_flow_info failed
> 0x5a1ecd verify_flow_info()
>         ../../gcc/gcc/cfghooks.c:260
> 0x5b4ee2 cfg_layout_finalize()
>         ../../gcc/gcc/cfgrtl.c:4286
> 0xd44662 duplicate_computed_gotos
>         ../../gcc/gcc/bb-reorder.c:2492
> 0xd44662 execute
>         ../../gcc/gcc/bb-reorder.c:2524
> Please submit a full bug report,
> with preprocessed source if appropriate.
> Please include the complete backtrace with any bug report.
> See <http://gcc.gnu.org/bugs.html> for instructions.
> make[8]: *** [/tmp/ccN0aFCW.ltrans17.ltrans.o] Error 1
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
>From gcc-bugs-return-437896-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Dec 17 18:56:46 2013
Return-Path: <gcc-bugs-return-437896-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 31362 invoked by alias); 17 Dec 2013 18:56:46 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 31313 invoked by uid 48); 17 Dec 2013 18:56:43 -0000
From: "dimhen at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/59350] [4.9 regression] ICE: in vt_expand_var_loc_chain, at var-tracking.c:8212
Date: Tue, 17 Dec 2013 18:56:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dimhen at gmail dot com
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ebotcazou at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59350-4-LNRy4ne8aV@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59350-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59350-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01551.txt.bz2
Content-length: 272

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY350

--- Comment #34 from Dmitry G. Dyachenko <dimhen at gmail dot com> ---
(In reply to Eric Botcazou from comment #33)
> OK, thanks for the testcase, which boils down to:

FAIL for me too
r205459 PASS
r205461, r206013 FAIL

[Bug gcov-profile/59527] [4.9 Regression] ICE: in fixup_reorder_chain, at cfgrtl.c:3739 during PGO Firefox build

[trippels at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527

--- Comment #6 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
The testcase is too big to attach.

 % wget trippelsdorf.de/testcase.tar.bz2
 % tar xvjf testcase.tar.bz2
 % g++ -w -nostdlib -r -flto=4 -fprofile-use -fprofile-correction
-march=amdfam10 -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pipe
-O3 Unified_cpp_7.ii Unified_cpp_8.ii

/var/tmp/mozilla-central/js/src/vm/Interpreter.cpp: In function ‘Interpret’:
/var/tmp/mozilla-central/js/src/vm/Interpreter.cpp:3469:1: error: non-cold
basic block 39 dominated by a block in the cold partition (2517)
 }
 ^
/var/tmp/mozilla-central/js/src/vm/Interpreter.cpp:3469:1: internal compiler
error: verify_flow_info failed
0x5a1ecd verify_flow_info()
        ../../gcc/gcc/cfghooks.c:260
0x5b4ee2 cfg_layout_finalize()
        ../../gcc/gcc/cfgrtl.c:4286
0xd44662 duplicate_computed_gotos
        ../../gcc/gcc/bb-reorder.c:2492
0xd44662 execute
        ../../gcc/gcc/bb-reorder.c:2524
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
make: *** [/tmp/ccvLwfUA.ltrans0.ltrans.o] Error 1
>From gcc-bugs-return-437907-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Dec 17 20:02:03 2013
Return-Path: <gcc-bugs-return-437907-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 13412 invoked by alias); 17 Dec 2013 20:02:03 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 13373 invoked by uid 48); 17 Dec 2013 20:02:00 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/58668] [4.8/4.9 regression] internal compiler error: in cond_exec_process_insns, at ifcvt.c:339
Date: Tue, 17 Dec 2013 20:02:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.3
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-58668-4-MCsxfwYfAM@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58668-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58668-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01562.txt.bz2
Content-length: 732

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX668

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Reduced testcase, ICEs with -march=armv7-a -mthumb -O2:

void *fn1 (void *);
void *fn2 (void *, const char *);
void fn3 (void *);
void fn4 (void *, int);

void *
test (void *x)
{
  void *a, *b;
  if (!(a = fn1 (x)))
    return (void *) 0;
  if (!(b = fn2 (a, "w")))
    {
      fn3 (a);
      return (void *) 0;
    }
  fn3 (a);
  fn4 (b, 1);
  return b;
}

[Bug gcov-profile/59527] [4.9 Regression] ICE: in fixup_reorder_chain, at cfgrtl.c:3739 during PGO Firefox build

[tejohnson at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527

--- Comment #7 from tejohnson at gcc dot gnu.org ---
Author: tejohnson
Date: Tue Dec 17 22:35:38 2013
New Revision: 206072

URL: http://gcc.gnu.org/viewcvs?rev=206072&root=gcc&view=rev
Log:
2013-12-17  Teresa Johnson  <tejohnson@google.com>

    PR gcov-profile/59527
    * cfgrtl.c (fixup_reorder_chain): Handle a region-crossing
        branch, which can't be eliminated.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cfgrtl.c

[Bug gcov-profile/59527] [4.9 Regression] ICE: in fixup_reorder_chain, at cfgrtl.c:3739 during PGO Firefox build

[tejohnson at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527

--- Comment #8 from Teresa Johnson <tejohnson at google dot com> ---
I can't reproduce this one using your source/profles and command line
(using a trunk updated to head last night plus my fix for the assert).
I verified that splitting is kicking in, but no error occurs. Do you
want to generate and tar up the dumps, and I can try to figure out
what might be going on from that?

Thanks,
Teresa

On Tue, Dec 17, 2013 at 11:48 AM, trippels at gcc dot gnu.org
<gcc-bugzilla@gcc.gnu.org> wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527
>
> --- Comment #6 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
> The testcase is too big to attach.
>
>  % wget trippelsdorf.de/testcase.tar.bz2
>  % tar xvjf testcase.tar.bz2
>  % g++ -w -nostdlib -r -flto=4 -fprofile-use -fprofile-correction
> -march=amdfam10 -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pipe
> -O3 Unified_cpp_7.ii Unified_cpp_8.ii
>
> /var/tmp/mozilla-central/js/src/vm/Interpreter.cpp: In function ‘Interpret’:
> /var/tmp/mozilla-central/js/src/vm/Interpreter.cpp:3469:1: error: non-cold
> basic block 39 dominated by a block in the cold partition (2517)
>  }
>  ^
> /var/tmp/mozilla-central/js/src/vm/Interpreter.cpp:3469:1: internal compiler
> error: verify_flow_info failed
> 0x5a1ecd verify_flow_info()
>         ../../gcc/gcc/cfghooks.c:260
> 0x5b4ee2 cfg_layout_finalize()
>         ../../gcc/gcc/cfgrtl.c:4286
> 0xd44662 duplicate_computed_gotos
>         ../../gcc/gcc/bb-reorder.c:2492
> 0xd44662 execute
>         ../../gcc/gcc/bb-reorder.c:2524
> Please submit a full bug report,
> with preprocessed source if appropriate.
> Please include the complete backtrace with any bug report.
> See <http://gcc.gnu.org/bugs.html> for instructions.
> make: *** [/tmp/ccvLwfUA.ltrans0.ltrans.o] Error 1
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
>From gcc-bugs-return-437945-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Dec 18 07:22:13 2013
Return-Path: <gcc-bugs-return-437945-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 26343 invoked by alias); 18 Dec 2013 07:22:12 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 26300 invoked by uid 48); 18 Dec 2013 07:22:08 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/59534] [4.9 Regression] FAIL: libgomp.fortran/retval1.f90  execution test due to denormals
Date: Wed, 18 Dec 2013 07:22:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: testsuite
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status bug_file_loc resolution target_milestone
Message-ID: <bug-59534-4-3KdccVaJYB@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59534-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59534-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01600.txt.bz2
Content-length: 758

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59534

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2013-12/msg01505.htm
                   |                            |l
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.0

--- Comment #11 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed [1].

[1] http://gcc.gnu.org/ml/gcc-testresults/2013-12/msg01719.html
>From gcc-bugs-return-437946-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Dec 18 07:46:44 2013
Return-Path: <gcc-bugs-return-437946-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 3728 invoked by alias); 18 Dec 2013 07:46:44 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 3682 invoked by uid 48); 18 Dec 2013 07:46:39 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/59541] New: [4.9 Regression] Revision 206070 breaks bootstrap on darwin
Date: Wed, 18 Dec 2013 07:46:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc cf_gcctarget
Message-ID: <bug-59541-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01601.txt.bz2
Content-length: 2734

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY541

            Bug ID: 59541
           Summary: [4.9 Regression] Revision 206070 breaks bootstrap on
                    darwin
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dominiq at lps dot ens.fr
                CC: howarth at bromo dot med.uc.edu, iains at gcc dot gnu.org,
                    marxin.liska at gmail dot com
            Target: *-*-darwin*

Revision 206070 breaks bootstrap on darwin:

/opt/gcc/build_c/./prev-gcc/xg++ -B/opt/gcc/build_c/./prev-gcc/
-B/opt/gcc/gcc4.9c/x86_64-apple-darwin13.0.0/bin/ -nostdinc++
-B/opt/gcc/build_c/prev-x86_64-apple-darwin13.0.0/libstdc++-v3/src/.libs
-B/opt/gcc/build_c/prev-x86_64-apple-darwin13.0.0/libstdc++-v3/libsupc++/.libs
-I/opt/gcc/build_c/prev-x86_64-apple-darwin13.0.0/libstdc++-v3/include/x86_64-apple-darwin13.0.0
-I/opt/gcc/build_c/prev-x86_64-apple-darwin13.0.0/libstdc++-v3/include
-I/opt/gcc/_clean/libstdc++-v3/libsupc++
-L/opt/gcc/build_c/prev-x86_64-apple-darwin13.0.0/libstdc++-v3/src/.libs
-L/opt/gcc/build_c/prev-x86_64-apple-darwin13.0.0/libstdc++-v3/libsupc++/.libs
-c   -g -O2  -gtoggle -DIN_GCC    -fno-exceptions -fno-rtti
-fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common
-DHAVE_CONFIG_H -I. -I. -I../../_clean/gcc -I../../_clean/gcc/.
-I../../_clean/gcc/../include -I./../intl -I../../_clean/gcc/../libcpp/include
-I/opt/mp/include  -I../../_clean/gcc/../libdecnumber
-I../../_clean/gcc/../libdecnumber/dpd -I../libdecnumber
-I../../_clean/gcc/../libbacktrace -DCLOOG_INT_GMP  -I/opt/mp/include  -o
darwin.o -MT darwin.o -MMD -MP -MF ./.deps/darwin.TPo
../../_clean/gcc/config/darwin.c
../../_clean/gcc/config/darwin.c: In function 'section*
darwin_function_section(tree, node_frequency, bool, bool)':
../../_clean/gcc/config/darwin.c:3665:1: error: control reaches end of non-void
function [-Werror=return-type]
 }
 ^
cc1plus: all warnings being treated as errors

I fixed it with the following patch:

--- ../_clean/gcc/config/darwin.c    2013-12-17 23:28:53.000000000 +0100
+++ gcc/config/darwin.c    2013-12-18 00:46:28.000000000 +0100
@@ -3654,7 +3654,8 @@ darwin_function_section (tree decl, enum
           return (weak)
                   ? darwin_sections[text_hot_coal_section]
                   : darwin_sections[text_hot_section];
-        break;
+    else
+      return text_section;
       }
       default:
     return (weak)

Testing in progress.

[Bug gcov-profile/59527] [4.9 Regression] ICE: in fixup_reorder_chain, at cfgrtl.c:3739 during PGO Firefox build

[trippels at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
(In reply to Teresa Johnson from comment #8)
> I can't reproduce this one using your source/profles and command line
> (using a trunk updated to head last night plus my fix for the assert).
> I verified that splitting is kicking in, but no error occurs. Do you
> want to generate and tar up the dumps, and I can try to figure out
> what might be going on from that?

Sorry for not checking earlier, but this issue only happens with 
the gold linker. So please add -fuse-ld=gold to the command line.

Anyway lets close this bug. I'll open a new one for the 
"verify_flow_info failed" ICE.

[Bug gcov-profile/59527] [4.9 Regression] ICE: in fixup_reorder_chain, at cfgrtl.c:3739 during PGO Firefox build

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59527

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.0