public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
       [not found] <bug-59541-4@http.gcc.gnu.org/bugzilla/>
@ 2013-12-18 19:17 ` dominiq at lps dot ens.fr
  2013-12-18 19:22 ` dominiq at lps dot ens.fr
                   ` (11 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2013-12-18 19:17 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
I have reverted the changes in gcc/config/darwin.c done by r 206070 and
bootstrap went fine. The new failing tests are still there.


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
       [not found] <bug-59541-4@http.gcc.gnu.org/bugzilla/>
  2013-12-18 19:17 ` [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin dominiq at lps dot ens.fr
@ 2013-12-18 19:22 ` dominiq at lps dot ens.fr
  2013-12-19 12:54 ` rguenth at gcc dot gnu.org
                   ` (10 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2013-12-18 19:22 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541

--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> The new failing tests are still there.

I was wrong: gcc.dg/tree-prof/crossmodule-indircall-1.c passes.


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
       [not found] <bug-59541-4@http.gcc.gnu.org/bugzilla/>
  2013-12-18 19:17 ` [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin dominiq at lps dot ens.fr
  2013-12-18 19:22 ` dominiq at lps dot ens.fr
@ 2013-12-19 12:54 ` rguenth at gcc dot gnu.org
  2013-12-19 15:45 ` iains at gcc dot gnu.org
                   ` (9 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-12-19 12:54 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
   Target Milestone|---                         |4.9.0


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
       [not found] <bug-59541-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2013-12-19 12:54 ` rguenth at gcc dot gnu.org
@ 2013-12-19 15:45 ` iains at gcc dot gnu.org
  2013-12-19 18:53 ` dominiq at lps dot ens.fr
                   ` (8 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: iains at gcc dot gnu.org @ 2013-12-19 15:45 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-12-19
     Ever confirmed|0                           |1

--- Comment #4 from Iain Sandoe <iains at gcc dot gnu.org> ---
could someone please point me at the original post for this patch?

The darwin_function_section() stuff seems to be inconsistent.

Is the intention to say:

if not reordering functions - return the default.

If doing_lto && flag_profile_values ;
  ignore frequencies (i.e. return the default)?

why is the action applied to startup and unlikely (but no test for weak)

and not exit and unlikely ..

and not "general and unlikely"

perhaps this is all explained in the original patch - but I couldn't find it on
a quick search.


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
       [not found] <bug-59541-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2013-12-19 15:45 ` iains at gcc dot gnu.org
@ 2013-12-19 18:53 ` dominiq at lps dot ens.fr
  2013-12-19 23:01 ` dominiq at lps dot ens.fr
                   ` (7 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2013-12-19 18:53 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541

--- Comment #5 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
The failure of FAIL: gcc.dg/tree-prof/crossmodule-indircall-1.c is due to the
first part of
http://gcc.gnu.org/viewcvs/gcc/trunk/gcc/config/darwin.c?r1=206070&r2=206069&pathrev=206070&sortby=date&view=patch.


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
       [not found] <bug-59541-4@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2013-12-19 18:53 ` dominiq at lps dot ens.fr
@ 2013-12-19 23:01 ` dominiq at lps dot ens.fr
  2013-12-20  8:59 ` dominiq at lps dot ens.fr
                   ` (6 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2013-12-19 23:01 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jh at suse dot cz,
                   |                            |marxin at gcc dot gnu.org,
                   |                            |mjambor at suse dot cz

--- Comment #6 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> could someone please point me at the original post for this patch?

I have the same question.


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
       [not found] <bug-59541-4@http.gcc.gnu.org/bugzilla/>
                   ` (5 preceding siblings ...)
  2013-12-19 23:01 ` dominiq at lps dot ens.fr
@ 2013-12-20  8:59 ` dominiq at lps dot ens.fr
  2013-12-20 11:34 ` dominiq at lps dot ens.fr
                   ` (5 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2013-12-20  8:59 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541

--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Note that on x86_64-apple-darwin10 the test
gcc.dg/tree-prof/cold_partition_label.c has started to fail (compilation, 
-fprofile-use -D_PROFILE_USE) between r204856 (OK) and r205324 (fail). This is
fixed at 206120 with the faulty part of 206070 reverted.


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
       [not found] <bug-59541-4@http.gcc.gnu.org/bugzilla/>
                   ` (6 preceding siblings ...)
  2013-12-20  8:59 ` dominiq at lps dot ens.fr
@ 2013-12-20 11:34 ` dominiq at lps dot ens.fr
  2013-12-20 22:40 ` marxin.liska at gmail dot com
                   ` (4 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2013-12-20 11:34 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541

--- Comment #8 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> > could someone please point me at the original post for this patch?
>
> I have the same question.

I have finally found the answer: final patch at

http://gcc.gnu.org/ml/gcc-patches/2013-12/msg01368.html

OKed by Jan Hubicka at

http://gcc.gnu.org/ml/gcc-patches/2013-12/msg01379.html


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
       [not found] <bug-59541-4@http.gcc.gnu.org/bugzilla/>
                   ` (7 preceding siblings ...)
  2013-12-20 11:34 ` dominiq at lps dot ens.fr
@ 2013-12-20 22:40 ` marxin.liska at gmail dot com
  2013-12-21  0:36 ` dominiq at lps dot ens.fr
                   ` (3 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: marxin.liska at gmail dot com @ 2013-12-20 22:40 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541

--- Comment #9 from Martin Liška <marxin.liska at gmail dot com> ---
Hello,
   thank you for the hotfix that repaired switch/case missing return value.

Actually I was told by Jan to reproduce the functionality from varasm.c that I
was able to bootstrap and test.

The idea of reordering pass is to order all functions that are seen during
instrumentation run and are executed during start-up of an application.

So that, we do not build separate sections for .text, .text.hot and
.text.startup. On the other hand: any execute function should not live in
.text.unlikely and .text.startup. If so, it means that we miss profile info and
these functions can be identified during debugging process.

I am not familiar with darwin format, Jan do you know what could cause problem?
>From gcc-bugs-return-438317-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Dec 20 22:45:23 2013
Return-Path: <gcc-bugs-return-438317-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 10711 invoked by alias); 20 Dec 2013 22:45:23 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 10455 invoked by uid 48); 20 Dec 2013 22:45:19 -0000
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/37336] [F03] Finish derived-type finalization
Date: Fri, 20 Dec 2013 22:45:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: janus at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: burnus at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-37336-4-unMTVITptp@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-37336-4@http.gcc.gnu.org/bugzilla/>
References: <bug-37336-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01972.txt.bz2
Content-length: 363

http://gcc.gnu.org/bugzilla/show_bug.cgi?id7336

--- Comment #27 from janus at gcc dot gnu.org ---
>From http://gcc.gnu.org/ml/fortran/2013-12/msg00104.html ...

Currently missing are:

a) Finalization of the LHS during intrinsic assignment:
b) Finalization of functions results after their use
c) Finalization of structure/array constructors after their use.


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
       [not found] <bug-59541-4@http.gcc.gnu.org/bugzilla/>
                   ` (8 preceding siblings ...)
  2013-12-20 22:40 ` marxin.liska at gmail dot com
@ 2013-12-21  0:36 ` dominiq at lps dot ens.fr
  2014-01-05 21:47 ` [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on Darwin: config/darwin.c:3665:1: error: control reaches end of non-void function [-Werror=return-type] iains at gcc dot gnu.org
                   ` (2 subsequent siblings)
  12 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2013-12-21  0:36 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541

--- Comment #10 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Hello,
>   thank you for the hotfix that repaired switch/case missing return value.

Nothing has been committed yet to fix darwin bootstrap!-(


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on Darwin: config/darwin.c:3665:1: error: control reaches end of non-void function [-Werror=return-type]
       [not found] <bug-59541-4@http.gcc.gnu.org/bugzilla/>
                   ` (9 preceding siblings ...)
  2013-12-21  0:36 ` dominiq at lps dot ens.fr
@ 2014-01-05 21:47 ` iains at gcc dot gnu.org
  2014-01-05 22:50 ` dominiq at lps dot ens.fr
  2014-01-06  7:48 ` dominiq at lps dot ens.fr
  12 siblings, 0 replies; 13+ messages in thread
From: iains at gcc dot gnu.org @ 2014-01-05 21:47 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541

--- Comment #12 from Iain Sandoe <iains at gcc dot gnu.org> ---
Author: iains
Date: Sun Jan  5 21:47:43 2014
New Revision: 206348

URL: http://gcc.gnu.org/viewcvs?rev=206348&root=gcc&view=rev
Log:
gcc:

    PR bootstrap/59541
    * config/darwin.c (darwin_function_section): Adjust return values to
    correspond to optimisation changes made in r206070.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/darwin.c


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on Darwin: config/darwin.c:3665:1: error: control reaches end of non-void function [-Werror=return-type]
       [not found] <bug-59541-4@http.gcc.gnu.org/bugzilla/>
                   ` (10 preceding siblings ...)
  2014-01-05 21:47 ` [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on Darwin: config/darwin.c:3665:1: error: control reaches end of non-void function [-Werror=return-type] iains at gcc dot gnu.org
@ 2014-01-05 22:50 ` dominiq at lps dot ens.fr
  2014-01-06  7:48 ` dominiq at lps dot ens.fr
  12 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2014-01-05 22:50 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |juergen.reuter at desy dot de

--- Comment #13 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
*** Bug 59688 has been marked as a duplicate of this bug. ***


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on Darwin: config/darwin.c:3665:1: error: control reaches end of non-void function [-Werror=return-type]
       [not found] <bug-59541-4@http.gcc.gnu.org/bugzilla/>
                   ` (11 preceding siblings ...)
  2014-01-05 22:50 ` dominiq at lps dot ens.fr
@ 2014-01-06  7:48 ` dominiq at lps dot ens.fr
  12 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2014-01-06  7:48 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59541

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Closing as FIXED. Thanks for the patch.


^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-01-06  7:48 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-59541-4@http.gcc.gnu.org/bugzilla/>
2013-12-18 19:17 ` [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin dominiq at lps dot ens.fr
2013-12-18 19:22 ` dominiq at lps dot ens.fr
2013-12-19 12:54 ` rguenth at gcc dot gnu.org
2013-12-19 15:45 ` iains at gcc dot gnu.org
2013-12-19 18:53 ` dominiq at lps dot ens.fr
2013-12-19 23:01 ` dominiq at lps dot ens.fr
2013-12-20  8:59 ` dominiq at lps dot ens.fr
2013-12-20 11:34 ` dominiq at lps dot ens.fr
2013-12-20 22:40 ` marxin.liska at gmail dot com
2013-12-21  0:36 ` dominiq at lps dot ens.fr
2014-01-05 21:47 ` [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on Darwin: config/darwin.c:3665:1: error: control reaches end of non-void function [-Werror=return-type] iains at gcc dot gnu.org
2014-01-05 22:50 ` dominiq at lps dot ens.fr
2014-01-06  7:48 ` dominiq at lps dot ens.fr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).