[Bug middle-end/59569] New: [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[Bug middle-end/59569] New: [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59569

            Bug ID: 59569
           Summary: [4.9 Regression] r206148 causes internal compiler
                    error: in vect_create_destination_var, at
                    tree-vect-data-refs.c:4294
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hjl.tools at gmail dot com
                CC: bmei at broadcom dot com

When compiling 253.perlbmk from SPEC CPU 2K on Linux/x86-64,
I got

[hjl@gnu-mic-2 00000001]$
/export/project/git/gcc-regression/master/206150/usr/bin/gcc -c -o pp.o  
-DSPEC_CPU2000_LP64 -DSPEC_CPU2000_LINUX_I386 -DSPEC_CPU2000_NEED_BOOL
-DSPEC_CPU2000_GLIBC22        -O3 -funroll-loops -ffast-math   pp.c
In file included from perl.h:1090:0,
                 from pp.c:16:
handy.h:71:0: warning: "bool" redefined [enabled by default]
 #  define bool char
 ^
In file included from config.h:1:0,
                 from perl.h:137,
                 from pp.c:16:
spec_config.h:160:0: note: this is the location of the previous definition
 #define bool int
 ^
In file included from perl.h:2121:0,
                 from pp.c:16:
pp.c: In function \u2018Perl_pp_splice\u2019:
embed.h:759:20: internal compiler error: in vect_create_destination_var, at
tree-vect-data-refs.c:4294
 #define pp_splice  Perl_pp_splice
                    ^
pp.h:20:20: note: in definition of macro \u2018PP\u2019
 #define PP(s) OP * s(ARGSproto)
                    ^
pp.c:2687:4: note: in expansion of macro \u2018pp_splice\u2019
 PP(pp_splice)
    ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
[hjl@gnu-mic-2 00000001]$

[Bug middle-end/59569] [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59569

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 31494
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=31494&action=edit
A testcase

[hjl@gnu-mic-2 00000001]$
/export/project/git/gcc-regression/master/206150/usr/bin/gcc -S -O3
-funroll-loops -ffast-math pr59569.c 
pr59569.c: In function ‘Perl_pp_splice’:
pr59569.c:7304:6: internal compiler error: in vect_create_destination_var, at
tree-vect-data-refs.c:4294
 OP * Perl_pp_splice(void)
      ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
[hjl@gnu-mic-2 00000001]$
>From gcc-bugs-return-438322-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Dec 21 01:13:12 2013
Return-Path: <gcc-bugs-return-438322-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 26326 invoked by alias); 21 Dec 2013 01:13:11 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 26301 invoked by uid 48); 21 Dec 2013 01:13:08 -0000
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/59569] [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294
Date: Sat, 21 Dec 2013 01:13:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: hjl.tools at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on target_milestone everconfirmed
Message-ID: <bug-59569-4-69kxYSDJxe@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59569-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59569-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg01977.txt.bz2
Content-length: 450

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY569

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-12-21
   Target Milestone|---                         |4.9.0
     Ever confirmed|0                           |1

[Bug middle-end/59569] [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59569

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
254.gap in SPEC CPU 2K is also failed.

[Bug middle-end/59569] [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59569

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Reduced testcase:
extern char c;

void
foo (int i, char **j)
{
  while (i)
    j[--i] = &c;
}

[Bug middle-end/59569] [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[su at cs dot ucdavis.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59569

Zhendong Su <su at cs dot ucdavis.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |su at cs dot ucdavis.edu

--- Comment #4 from Zhendong Su <su at cs dot ucdavis.edu> ---
(In reply to Jakub Jelinek from comment #3)
> Reduced testcase:
> extern char c;
> 
> void
> foo (int i, char **j)
> {
>   while (i)
>     j[--i] = &c;
> }


Below is a very similar testcase that I've encountered: 

void foo (int *a, int b)
{
  for (; b; b--)
    a[b] = 1;
}

[Bug middle-end/59569] [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[dcb314 at hotmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59569

--- Comment #5 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Zhendong Su from comment #4)
> Below is a very similar testcase that I've encountered: 

I have a third test case available on request.

[Bug middle-end/59569] [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59569

--- Comment #6 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to David Binderman from comment #5)
> (In reply to Zhendong Su from comment #4)
> > Below is a very similar testcase that I've encountered: 
> 
> I have a third test case available on request.

Please upload it here. Thanks.

[Bug middle-end/59569] [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[dcb314 at hotmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59569

--- Comment #7 from David Binderman <dcb314 at hotmail dot com> ---
Created attachment 31501
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=31501&action=edit
C source code

Source code from bug # 45948. Compiler flag -O3 required.
Machine type x86_64.

[Bug middle-end/59569] [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59569

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug middle-end/59569] [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[bmei at broadcom dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59569

--- Comment #8 from Bingfeng Mei <bmei at broadcom dot com> ---
Sorry for the regression. The assertion happens if storing a constant value
with negative step. Doing permutation of constant is not the best optimization
here. So the easy way to fix is to skip vectorizing this statement in the same
way as before the patch. Or maybe better way is to form a constant vector to
store.

[Bug middle-end/59569] [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[bmei at broadcom dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59569

--- Comment #9 from Bingfeng Mei <bmei at broadcom dot com> ---
Seems simple patch is to just bypass permutation for constant operand as
vec_oprnd is a constant vector with identical elements.

Index: tree-vect-stmts.c
===================================================================
--- tree-vect-stmts.c   (revision 206176)
+++ tree-vect-stmts.c   (working copy)
@@ -5353,7 +5353,8 @@ vectorizable_store (gimple stmt, gimple_
                set_ptr_info_alignment (get_ptr_info (dataref_ptr), align,
                                        misalign);

-             if (negative)
+             if (negative
+                 && !CONSTANT_CLASS_P (gimple_assign_rhs1 (stmt)))
                {
                  tree perm_mask = perm_mask_for_reverse (vectype);
                  tree perm_dest

[Bug middle-end/59569] [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59569

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Bingfeng Mei from comment #9)
> Seems simple patch is to just bypass permutation for constant operand as
> vec_oprnd is a constant vector with identical elements.
> 
> Index: tree-vect-stmts.c
> ===================================================================
> --- tree-vect-stmts.c   (revision 206176)
> +++ tree-vect-stmts.c   (working copy)
> @@ -5353,7 +5353,8 @@ vectorizable_store (gimple stmt, gimple_
>                 set_ptr_info_alignment (get_ptr_info (dataref_ptr), align,
>                                         misalign);
> 
> -             if (negative)
> +             if (negative
> +                 && !CONSTANT_CLASS_P (gimple_assign_rhs1 (stmt)))
>                 {
>                   tree perm_mask = perm_mask_for_reverse (vectype);
>                   tree perm_dest

I think checking dt == vect_constant_def || dt == vect_external_def would be
more appropriate.  But, IMNSHO you don't need to check at the analysis phase
!perm_mask_for_reverse (vectype)
either.

[Bug middle-end/59569] [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[meibf at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59569

--- Comment #11 from meibf at gcc dot gnu.org ---
Author: meibf
Date: Mon Dec 23 15:07:58 2013
New Revision: 206179

URL: http://gcc.gnu.org/viewcvs?rev=206179&root=gcc&view=rev
Log:
2013-12-23  Bingfeng Mei  <bmei@broadcom.com>

    PR middle-end/59569
    * tree-vect-stmts.c (vectorizable_store): Skip permutation for
    consant operand, and add a few missing \n.

    * gcc.c-torture/compile/pr59569-1.c: New test.
    * gcc.c-torture/compile/pr59569-2.c: Ditto.

Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/pr59569-1.c
    trunk/gcc/testsuite/gcc.c-torture/compile/pr59569-2.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-vect-stmts.c

[Bug middle-end/59569] [4.9 Regression] r206148 causes internal compiler error: in vect_create_destination_var, at tree-vect-data-refs.c:4294

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59569

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.