[Bug fortran/59612] New: iso_fortran_env segfaults with -fdump-fortran-original

[Bug fortran/59612] New: iso_fortran_env segfaults with -fdump-fortran-original

[tkoenig at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59612

            Bug ID: 59612
           Summary: iso_fortran_env segfaults with -fdump-fortran-original
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: tkoenig at gcc dot gnu.org

ig25@linux-fd1f:~/Krempel/NoRange> cat iso.f90
program main
  use iso_fortran_env
end program main
ig25@linux-fd1f:~/Krempel/NoRange> gfortran -fdump-fortran-original iso.f90 

Namespace: A-H: (REAL 4) I-N: (INTEGER 4) O-Z: (REAL 4)
procedure name = main
  symtree: 'Lock_type'   || symbol: 'lock_type'    
    type spec : (UNKNOWN 0)
    attributes: (DERIVED  USE-ASSOC(iso_fortran_env))
  symtree: 'atomic_int_kind'|| symbol: 'atomic_int_kind' 
    type spec : (INTEGER 4)
    attributes: (PARAMETER  USE-ASSOC(iso_fortran_env))
    value: 4
  symtree: 'atomic_logical_kind'|| symbol: 'atomic_logical_kind' 
    type spec : (INTEGER 4)
    attributes: (PARAMETER  USE-ASSOC(iso_fortran_env))
    value: 4
  symtree: 'character_kinds'|| symbol: 'character_kinds' 
    type spec : (INTEGER 4)
    attributes: (PARAMETER  DIMENSION USE-ASSOC(iso_fortran_env))
    value: (/ 1 , 4 /)
    Array spec:(1 [0] AS_EXPLICIT 1 2 )
  symtree: 'character_storage_size'|| symbol: 'character_storage_size' 
    type spec : (INTEGER 4)
    attributes: (PARAMETER  USE-ASSOC(iso_fortran_env))
    value: 8
  symtree: 'compiler_options'|| symbol: 'compiler_options' 
f951: interner Compiler-Fehler: Speicherzugriffsfehler
0x9f9dff crash_signal
        ../../trunk/gcc/toplev.c:336
0x5635bc show_typespec
        ../../trunk/gcc/fortran/dump-parse-tree.c:113
0x566a3c show_symbol
        ../../trunk/gcc/fortran/dump-parse-tree.c:841
0x566a3c show_symtree
        ../../trunk/gcc/fortran/dump-parse-tree.c:1000
0x5dcdc9 do_traverse_symtree
        ../../trunk/gcc/fortran/symbol.c:3581
0x566571 show_namespace
        ../../trunk/gcc/fortran/dump-parse-tree.c:2284
0x5b09ee gfc_parse_file()
        ../../trunk/gcc/fortran/parse.c:4728
0x5ee895 gfc_be_parse_file
        ../../trunk/gcc/fortran/f95-lang.c:188
Bitte senden Sie einen vollständigen Fehlerbericht auf Englisch ein;
bearbeiten Sie die Quellen zunächst mit einem Präprozessor, wenn es
dienlich ist.
Please include the complete backtrace with any bug report.
Siehe <http://gcc.gnu.org/bugs.html> für nähere Anweisungen.
ig25@linux-fd1f:~/Krempel/NoRange> gfortran -v
Es werden eingebaute Spezifikationen verwendet.
COLLECT_GCC=gfortran
COLLECT_LTO_WRAPPER=/home/ig25/lib/gcc/x86_64-unknown-linux-gnu/4.9.0/lto-wrapper
Ziel: x86_64-unknown-linux-gnu
Konfiguriert mit: ../trunk/configure --prefix=/home/ig25
--enable-languages=c,fortran,c++
Thread-Modell: posix
gcc-Version 4.9.0 20131225 (experimental) (GCC) 

valgrind shows:
==13350== Invalid read of size 8
==13350==    at 0x5635BC: show_typespec(gfc_typespec*) (dump-parse-tree.c:113)
==13350==    by 0x566A3C: show_symtree(gfc_symtree*) (dump-parse-tree.c:841)
==13350==    by 0x5DCDC9: do_traverse_symtree(gfc_symtree*, void
(*)(gfc_symtree*), void (*)(gfc_symbol*)) (symbol.c:3581)
==13350==    by 0x566571: show_namespace(gfc_namespace*)
(dump-parse-tree.c:2284)
==13350==    by 0x5B09EE: gfc_parse_file() (parse.c:4728)
==13350==    by 0x5EE895: gfc_be_parse_file() (f95-lang.c:188)
==13350==    by 0x9F9E25: compile_file() (toplev.c:547)
==13350==    by 0x9FBDF7: toplev_main(int, char**) (toplev.c:1887)
==13350==    by 0x5A54BE4: (below main) (in /lib64/libc-2.18.so)
==13350==  Address 0x0 is not stack'd, malloc'd or (recently) free'd

gdb shows that the typespec for compiler_options is NULL:

 symtree: 'compiler_options'|| symbol: 'compiler_options' 

Program received signal SIGSEGV, Segmentation fault.
0x00000000005635bc in show_typespec (ts=0x0) at
../../trunk/gcc/fortran/dump-parse-tree.c:113
113           show_expr (ts->u.cl->length);
(gdb) up
#1  0x0000000000566a3d in show_symbol (sym=0x184ee10) at
../../trunk/gcc/fortran/dump-parse-tree.c:841
841       show_typespec (&sym->ts);
(gdb) p sym
$1 = (gfc_symbol *) 0x184ee10
(gdb) p *sym
$2 = {name = 0x7ffff6c53738 "compiler_options", module = 0x7ffff6d33340
"iso_fortran_env", declared_at = {nextc = 0x17dcb68, lb = 0x17dcb30}, ts = {
    type = BT_CHARACTER, kind = 1, u = {derived = 0x0, cl = 0x0, pad = 0},
interface = 0x0, is_c_interop = 0, is_iso_c = 0, f90_type = BT_UNKNOWN, 
    deferred = false}, attr = {allocatable = 0, dimension = 0, codimension = 0,
external = 0, intrinsic = 1, optional = 0, pointer = 0, target = 0, 
    value = 0, volatile_ = 0, temporary = 0, dummy = 0, result = 0, assign = 0,
threadprivate = 0, not_always_present = 0, implied_index = 0, 
    subref_array_pointer = 0, proc_pointer = 0, asynchronous = 0, contiguous =
0, class_pointer = 0, save = SAVE_NONE, data = 0, is_protected = 0, 
    use_assoc = 1, use_only = 0, use_rename = 0, imported = 0, host_assoc = 0,
in_namelist = 0, in_common = 0, in_equivalence = 0, function = 1, 
    subroutine = 0, procedure = 0, generic = 0, generic_copy = 0, implicit_type
= 0, untyped = 0, is_bind_c = 0, extension = 0, is_class = 0, 
    class_ok = 0, vtab = 0, vtype = 0, is_c_interop = 0, is_iso_c = 0, sequence
= 0, elemental = 0, pure = 1, recursive = 0, unmaskable = 0, masked = 0, 
    contained = 0, mod_proc = 0, abstract = 0, public_used = 0, implicit_pure =
0, noreturn = 0, entry = 0, entry_master = 0, mixed_entry_master = 0, 
    always_explicit = 0, artificial = 0, referenced = 0, is_main_program = 0,
access = ACCESS_UNKNOWN, intent = INTENT_UNKNOWN, flavor = FL_PROCEDURE, 
    if_source = IFSRC_DECL, proc = PROC_UNKNOWN, cray_pointer = 0, cray_pointee
= 0, alloc_comp = 0, pointer_comp = 0, proc_pointer_comp = 0, 
    private_comp = 0, zero_comp = 0, coarray_comp = 0, lock_comp = 0,
defined_assign_comp = 0, unlimited_polymorphic = 0, select_type_temporary = 0, 
    associate_var = 0, ext_attr = 0, volatile_ns = 0x0, asynchronous_ns = 0x0},
generic = 0x0, component_access = ACCESS_UNKNOWN, formal = 0x0, 
  formal_ns = 0x0, f2k_derived = 0x0, value = 0x0, as = 0x0, result = 0x0,
components = 0x0, cp_pointer = 0x0, entry_id = 0, hash_value = 0, 
  common_next = 0x0, common_head = 0x0, dummy_order = 0, namelist = 0x0,
namelist_tail = 0x0, old_symbol = 0x0, tlink = 0x0, mark = 1, gfc_new = 0, 
  equiv_built = 0, forall_index = 0, resolved = 1, refs = 1, ns = 0x17d71b0,
backend_decl = 0x0, from_intmod = INTMOD_ISO_FORTRAN_ENV, intmod_sym_id = 26, 
  binding_label = 0x0, common_block = 0x0, assoc = 0x0}
>From gcc-bugs-return-438617-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Dec 27 21:42:37 2013
Return-Path: <gcc-bugs-return-438617-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 32087 invoked by alias); 27 Dec 2013 21:42:36 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 32046 invoked by uid 55); 27 Dec 2013 21:42:31 -0000
From: "ian at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug go/59506] net FAILs (timeout) on alpha
Date: Fri, 27 Dec 2013 21:42:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: go
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ian at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ian at airs dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59506-4-leTC7yRxoI@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59506-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59506-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg02272.txt.bz2
Content-length: 831

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY506

--- Comment #4 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> ---
Author: ian
Date: Fri Dec 27 21:42:26 2013
New Revision: 206224

URL: http://gcc.gnu.org/viewcvs?rev 6224&root=gcc&view=rev
Log:
    PR go/59506

net: use DialTimeout in TestSelfConnect

Backported from master repository.

This avoids problems with systems that take a long time to
find out nothing is listening, while still testing for the
self-connect misfeature since a self-connect should be fast.
With this we may be able to remove the test for non-Linux
systems.

Tested (on GNU/Linux) by editing selfConnect in
tcpsock_posix.go to always return false and verifying that
TestSelfConnect then fails with and without this change.

Idea from Uros Bizjak.

Modified:
    trunk/libgo/go/net/dial_test.go

[Bug fortran/59612] iso_fortran_env segfaults with -fdump-fortran-original

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59612

--- Comment #2 from janus at gcc dot gnu.org ---
Note that there are two small errors in the related documentation:


Index: gcc/fortran/invoke.texi
===================================================================
--- gcc/fortran/invoke.texi    (revision 206176)
+++ gcc/fortran/invoke.texi    (working copy)
@@ -989,11 +989,12 @@ Output the internal parse tree after translating t
 into internal representation.  Only really useful for debugging the
 GNU Fortran compiler itself.

-@item -fdump-optimized-tree
+@item -fdump-fortran-optimized
 @opindex @code{fdump-fortran-optimized}
 Output the parse tree after front-end optimization.  Only really
 useful for debugging the GNU Fortran compiler itself.

+@item -dump-parse-tree
 @opindex @code{fdump-parse-tree}
 Output the internal parse tree after translating the source program
 into internal representation.  Only really useful for debugging the


Does -fdump-fortran-optimized actually do anything?

[Bug fortran/59612] iso_fortran_env segfaults with -fdump-fortran-original

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59612

--- Comment #3 from janus at gcc dot gnu.org ---
Maybe it would make sense to run the testsuite with -fdump-fortran-original, in
order to check for further problems:


Index: gcc/testsuite/gfortran.dg/dg.exp
===================================================================
--- gcc/testsuite/gfortran.dg/dg.exp    (revision 206231)
+++ gcc/testsuite/gfortran.dg/dg.exp    (working copy)
@@ -22,7 +22,7 @@
 # If a testcase doesn't have special options, use these.
 global DEFAULT_FFLAGS
 if ![info exists DEFAULT_FFLAGS] then {
-    set DEFAULT_FFLAGS " -pedantic-errors"
+    set DEFAULT_FFLAGS " -pedantic-errors -fdump-fortran-original"
 }

 # Initialize `dg'.

[Bug fortran/59612] iso_fortran_env segfaults with -fdump-fortran-original

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59612

--- Comment #4 from janus at gcc dot gnu.org ---
(In reply to janus from comment #3)
> Maybe it would make sense to run the testsuite with -fdump-fortran-original,
> in order to check for further problems:

Does not seem to yield any failures here (with the patch from comment 1
applied).

[Bug fortran/59612] iso_fortran_env segfaults with -fdump-fortran-original

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59612

--- Comment #5 from janus at gcc dot gnu.org ---
Author: janus
Date: Sun Dec 29 17:20:50 2013
New Revision: 206237

URL: http://gcc.gnu.org/viewcvs?rev=206237&root=gcc&view=rev
Log:
2013-12-29  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/59612
    * dump-parse-tree.c (show_typespec): Check for charlen.
    * invoke.texi: Fix documentation of -fdump-fortran-optimized and
    -fdump-parse-tree.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/dump-parse-tree.c
    trunk/gcc/fortran/invoke.texi

[Bug fortran/59612] iso_fortran_env segfaults with -fdump-fortran-original

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59612

--- Comment #7 from janus at gcc dot gnu.org ---
(In reply to janus from comment #2)
> Does -fdump-fortran-optimized actually do anything?

The reason why I did not get any output from it is of course that it is only in
effect if -ffrontend-optimize is given in addition. Maybe it would be worth to
mention this in the documentation, e.g. like this:


Index: invoke.texi
===================================================================
--- invoke.texi    (revision 206237)
+++ invoke.texi    (working copy)
@@ -991,8 +991,9 @@

 @item -fdump-fortran-optimized
 @opindex @code{fdump-fortran-optimized}
-Output the parse tree after front-end optimization.  Only really
-useful for debugging the GNU Fortran compiler itself.
+Output the parse tree after front-end optimization (if enabled via
+@option{-ffrontend-optimize}).  Only really useful for debugging the GNU
+Fortran compiler itself.

 @item -fdump-parse-tree
 @opindex @code{fdump-parse-tree}

[Bug fortran/59612] [F03] iso_fortran_env segfaults with -fdump-fortran-original

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59612

--- Comment #8 from janus at gcc dot gnu.org ---
Author: janus
Date: Sat Jan 11 20:34:48 2014
New Revision: 206556

URL: http://gcc.gnu.org/viewcvs?rev=206556&root=gcc&view=rev
Log:
2014-01-11  Janus Weil  <janus@gcc.gnu.org>

    Backport from mainline
    2013-12-29  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/59612
    PR fortran/57042
    * dump-parse-tree.c (show_typespec): Check for charlen.
    * invoke.texi: Fix documentation of -fdump-fortran-optimized and
    -fdump-parse-tree.

Modified:
    branches/gcc-4_8-branch/gcc/fortran/ChangeLog
    branches/gcc-4_8-branch/gcc/fortran/dump-parse-tree.c
    branches/gcc-4_8-branch/gcc/fortran/invoke.texi

[Bug fortran/59612] [F03] iso_fortran_env segfaults with -fdump-fortran-original

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59612

--- Comment #9 from janus at gcc dot gnu.org ---
Author: janus
Date: Sat Jan 11 22:47:25 2014
New Revision: 206560

URL: http://gcc.gnu.org/viewcvs?rev=206560&root=gcc&view=rev
Log:
2014-01-11  Janus Weil  <janus@gcc.gnu.org>

    Backport from mainline
    2013-12-29  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/59612
    PR fortran/57042
    * dump-parse-tree.c (show_typespec): Check for charlen.
    * invoke.texi: Fix documentation of -fdump-fortran-optimized and
    -fdump-parse-tree.

Modified:
    branches/gcc-4_7-branch/gcc/fortran/ChangeLog
    branches/gcc-4_7-branch/gcc/fortran/dump-parse-tree.c
    branches/gcc-4_7-branch/gcc/fortran/invoke.texi

[Bug fortran/59612] [F03] iso_fortran_env segfaults with -fdump-fortran-original

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59612

--- Comment #10 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Should not this PR be closed as FIXED?

[Bug fortran/59612] [F03] iso_fortran_env segfaults with -fdump-fortran-original

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59612

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Should not this PR be closed as FIXED?

No answer since more than three months. I rechecked today that the test in
comment 0 does not ICE with revisions from 4.7.4 up to trunk (4.10) r210889.
Closing as FIXED.