[Bug tree-optimization/59617] [vectorizer] ICE in vectorizable_mask_load_store with AVX-512F's gathers enabled.

["dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59617

--- Comment #5 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Created attachment 32530
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32530&action=edit
Preprocessed file for avx512f-gather-5.c on x86_64-apple-darwin13

(In reply to UroÅ Bizjak from comment #4)
> I have compiled the preprocessed file with a crosscompiler from
> x86_64-pc-linux-gnu to x86_64-apple-darwin10.8.0 (gcc was configured with
> --target=x86_64-apple-darwin10.8.0) without problems.
>
> (preprocessed file was obtained from the native x86_64-pc-linux-gnu
> compilation).
>
> $ ~/gcc-build-xxx/gcc/cc1 -O3 -mavx512f -quiet avx512f-gather-5.i
> $ grep gather avx512f-gather-5.s
>        vgatherdps      (%rbx,%zmm0,4), %zmm2{%k2}
>        vgatherdps      (%rdx,%zmm0,4), %zmm1{%k3}

Could you compare your preprocessed file obtained from the native
x86_64-pc-linux-gnu to the attached one obtained from the native
x86_64-apple-darwin13?
>From gcc-bugs-return-448171-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Apr 03 08:59:17 2014
Return-Path: <gcc-bugs-return-448171-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 30118 invoked by alias); 3 Apr 2014 08:59:17 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 30057 invoked by uid 48); 3 Apr 2014 08:59:07 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/59617] [vectorizer] ICE in vectorizable_mask_load_store with AVX-512F's gathers enabled.
Date: Thu, 03 Apr 2014 08:59:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-59617-4-Xv9HdrK43Q@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59617-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59617-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-04/txt/msg00191.txt.bz2
Content-length: 320

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59617

--- Comment #6 from Uroš Bizjak <ubizjak at gmail dot com> ---
Created attachment 32531
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32531&action=edit
Preprocessed file for avx512f-gather-5.c on x86_64-pc-linux-gnu

Preprocessed file from Comment #4.
>From gcc-bugs-return-448172-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Apr 03 09:04:44 2014
Return-Path: <gcc-bugs-return-448172-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 32634 invoked by alias); 3 Apr 2014 09:04:44 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 32594 invoked by uid 48); 3 Apr 2014 09:04:39 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/59617] [vectorizer] ICE in vectorizable_mask_load_store with AVX-512F's gathers enabled.
Date: Thu, 03 Apr 2014 09:04:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59617-4-Uk5LoKA2H0@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59617-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59617-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-04/txt/msg00192.txt.bz2
Content-length: 1423

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59617

--- Comment #7 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Dominique d'Humieres from comment #5)
> Created attachment 32530 [details]
> Preprocessed file for avx512f-gather-5.c on x86_64-apple-darwin13
> 
> (In reply to UroÅ Bizjak from comment #4)
> > I have compiled the preprocessed file with a crosscompiler from
> > x86_64-pc-linux-gnu to x86_64-apple-darwin10.8.0 (gcc was configured with
> > --target=x86_64-apple-darwin10.8.0) without problems.
> >
> > (preprocessed file was obtained from the native x86_64-pc-linux-gnu
> > compilation).
> >
> > $ ~/gcc-build-xxx/gcc/cc1 -O3 -mavx512f -quiet avx512f-gather-5.i
> > $ grep gather avx512f-gather-5.s
> >        vgatherdps      (%rbx,%zmm0,4), %zmm2{%k2}
> >        vgatherdps      (%rdx,%zmm0,4), %zmm1{%k3}
> 
> Could you compare your preprocessed file obtained from the native
> x86_64-pc-linux-gnu to the attached one obtained from the native
> x86_64-apple-darwin13?

linux preprocessed file has a couple of *__restrict modifiers in:

-# 6 "avx512f-gather-4.c" 2
+# 6 "/opt/gcc/_clean/gcc/testsuite/gcc.target/i386/avx512f-gather-4.c" 2


 int a[1024], b[1024], c[1024], d[1024];

 __attribute__((noinline, noclone)) void
-foo (float *__restrict p, float *__restrict q, float *__restrict r,
+foo (float * p, float * q, float * r,
      int s1, int s2, int s3)
 {
   int i;
>From gcc-bugs-return-448173-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Apr 03 09:11:01 2014
Return-Path: <gcc-bugs-return-448173-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 2567 invoked by alias); 3 Apr 2014 09:11:00 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 2529 invoked by uid 48); 3 Apr 2014 09:10:55 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/59617] [vectorizer] ICE in vectorizable_mask_load_store with AVX-512F's gathers enabled.
Date: Thu, 03 Apr 2014 09:11:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59617-4-zDtDILpNsw@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59617-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59617-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-04/txt/msg00193.txt.bz2
Content-length: 483

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59617

--- Comment #8 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Uroš Bizjak from comment #7)
> 
> linux preprocessed file has a couple of *__restrict modifiers in:

Indeed, there is no vgather in the resulting assembly when darwin version of
the preprocessed file is compiled. OTOH, when __restrict modifiers are added to
foo, darwin file compiles to the assembly that includes expected vgather insns.
>From gcc-bugs-return-448174-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Apr 03 09:30:11 2014
Return-Path: <gcc-bugs-return-448174-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 16115 invoked by alias); 3 Apr 2014 09:30:10 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 16049 invoked by uid 48); 3 Apr 2014 09:30:06 -0000
From: "pault at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/60717] Wrong code with recursive procedure with unlimited polymorphic dummy argument
Date: Thu, 03 Apr 2014 09:30:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pault at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: pault at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-60717-4-HdDqqdYHxN@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60717-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60717-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-04/txt/msg00194.txt.bz2
Content-length: 612

http://gcc.gnu.org/bugzilla/show_bug.cgi?id`717

--- Comment #5 from Paul Thomas <pault at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #4)
> > Could there be a connection http://gcc.gnu.org/bugzilla/show_bug.cgi?idX085 ?
>
> May be, but pr58085 is not fixed by the patch in comment 2 (submitted at
> http://gcc.gnu.org/ml/fortran/2014-04/msg00005.html).

Thanks for bringing this PR to my attention. I would point a finger at
trans-stmt.c(trans_associate_var), which, ignoring the error in comment 2, was
one of the areas that I suspected would benefit from this fix.

Cheers

Paul