[Bug target/59663] New: [4.9 Regression] config/darwin.c:3665:1: error: control reaches end of non-void function [-Werror=return-type]

[Bug target/59663] New: [4.9 Regression] config/darwin.c:3665:1: error: control reaches end of non-void function [-Werror=return-type]

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59663

            Bug ID: 59663
           Summary: [4.9 Regression] config/darwin.c:3665:1: error:
                    control reaches end of non-void function
                    [-Werror=return-type]
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org
                CC: hubicka at gcc dot gnu.org, marxin.liska at gmail dot com
            Target: *-*-darwin*

Cf. https://trac.macports.org/ticket/41964 and PR59654 comment 20.

gcc/config/darwin.c: In function 'section* darwin_function_section(tree,
node_frequency, bool, bool)':
gcc/config/darwin.c:3665:1: error: control reaches end of non-void function
[-Werror=return-type]
 }

I think the culprit is Martin's patch r206070 - as there is no return after the
"switch":


@@ -3642,6 +3649,11 @@ darwin_function_section (tree decl, enum node_frequency 
       case NODE_FREQUENCY_HOT:
-       return (weak)
-               ? darwin_sections[text_hot_coal_section]
-               : darwin_sections[text_hot_section];
-       break;
+      {
+     /* If we do have a profile or(and) LTO phase is executed, we do not need
+           these ELF section.  */
+        if (!in_lto_p || !flag_profile_values)
+          return (weak)
+                  ? darwin_sections[text_hot_coal_section]
+                  : darwin_sections[text_hot_section];
+        break;
+      }

[Bug target/59663] [4.9 Regression] Bootstrap failure: config/darwin.c:3665:1: error: control reaches end of non-void function [-Werror=return-type]

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59663

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.0
            Summary|[4.9 Regression]            |[4.9 Regression] Bootstrap
                   |config/darwin.c:3665:1:     |failure:
                   |error: control reaches end  |config/darwin.c:3665:1:
                   |of non-void function        |error: control reaches end
                   |[-Werror=return-type]       |of non-void function
                   |                            |[-Werror=return-type]

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Draft patch – I have no idea about that code part, but the following patch
mimics what code before the switch statement. 

diff --git a/gcc/config/darwin.c b/gcc/config/darwin.c
index 63a385c..bb787f0 100644
--- a/gcc/config/darwin.c
+++ b/gcc/config/darwin.c
@@ -3654,6 +3654,8 @@ darwin_function_section (tree decl, enum node_frequency
freq,
           return (weak)
                   ? darwin_sections[text_hot_coal_section]
                   : darwin_sections[text_hot_section];
+    else
+      return text_section;
         break;
       }
       default:
>From gcc-bugs-return-439052-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Jan 04 18:48:04 2014
Return-Path: <gcc-bugs-return-439052-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 467 invoked by alias); 4 Jan 2014 18:48:04 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 32697 invoked by uid 48); 4 Jan 2014 18:48:01 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/59541] [4.9 Regression] Revision 206070 breaks bootstrap on darwin
Date: Sat, 04 Jan 2014 18:48:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-59541-4-kd7Fx1d52L@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59541-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59541-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-01/txt/msg00194.txt.bz2
Content-length: 455

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY541

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #11 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
*** Bug 59663 has been marked as a duplicate of this bug. ***

[Bug target/59663] [4.9 Regression] Bootstrap failure: config/darwin.c:3665:1: error: control reaches end of non-void function [-Werror=return-type]

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59663

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Duplicate of pr59541. See
http://gcc.gnu.org/ml/gcc-testresults/2013-12/msg02179.html for a better patch.
Iain Sandoe should submit something along this line soon(?).

*** This bug has been marked as a duplicate of bug 59541 ***