[Bug sanitizer/59758] New: [4.9 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[Bug sanitizer/59758] New: [4.9 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[doko at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

            Bug ID: 59758
           Summary: [4.9 Regression] bootstrap failure in
                    libsanitizer/asan on sparc-linux-gnu
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at gcc dot gnu.org
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org

seen with trunk 20140109:

/bin/bash ../libtool --tag=CXX   --mode=compile /«PKGBUILDDIR»/build/./gcc/xgcc
-shared-libgcc -B/«PKGBUILDDIR»/build/./gcc -nostdinc++
-L/«PKGBUILDDIR»/build/sparc-linux-gnu/libstdc++-v3/src
-L/«PKGBUILDDIR»/build/sparc-linux-gnu/libstdc++-v3/src/.libs
-L/«PKGBUILDDIR»/build/sparc-linux-gnu/libstdc++-v3/libsupc++/.libs
-B/usr/sparc-linux-gnu/bin/ -B/usr/sparc-linux-gnu/lib/ -isystem
/usr/sparc-linux-gnu/include -isystem /usr/sparc-linux-gnu/sys-include -isystem
/«PKGBUILDDIR»/build/sys-include    -D_GNU_SOURCE -D_DEBUG
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS  -I.
-I../../../../src/libsanitizer/sanitizer_common  -I
../../../../src/libsanitizer/include   -Wall -W -Wno-unused-parameter
-Wwrite-strings -pedantic -Wno-long-long -fPIC -fno-builtin -fno-exceptions
-fno-rtti -fomit-frame-pointer -funwind-tables -fvisibility=hidden
-Wno-variadic-macros -I../../libstdc++-v3/include    
-I../../libstdc++-v3/include/sparc-linux-gnu    
-I../../../../src/libsanitizer/../libstdc++-v3/libsupc++ -g -O2 -D_GNU_SOURCE
-MT sanitizer_platform_limits_linux.lo -MD -MP -MF
.deps/sanitizer_platform_limits_linux.Tpo -c -o
sanitizer_platform_limits_linux.lo
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc
libtool: compile:  /«PKGBUILDDIR»/build/./gcc/xgcc -shared-libgcc
-B/«PKGBUILDDIR»/build/./gcc -nostdinc++
-L/«PKGBUILDDIR»/build/sparc-linux-gnu/libstdc++-v3/src
-L/«PKGBUILDDIR»/build/sparc-linux-gnu/libstdc++-v3/src/.libs
-L/«PKGBUILDDIR»/build/sparc-linux-gnu/libstdc++-v3/libsupc++/.libs
-B/usr/sparc-linux-gnu/bin/ -B/usr/sparc-linux-gnu/lib/ -isystem
/usr/sparc-linux-gnu/include -isystem /usr/sparc-linux-gnu/sys-include -isystem
/«PKGBUILDDIR»/build/sys-include -D_GNU_SOURCE -D_DEBUG
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I.
-I../../../../src/libsanitizer/sanitizer_common -I
../../../../src/libsanitizer/include -Wall -W -Wno-unused-parameter
-Wwrite-strings -pedantic -Wno-long-long -fPIC -fno-builtin -fno-exceptions
-fno-rtti -fomit-frame-pointer -funwind-tables -fvisibility=hidden
-Wno-variadic-macros -I../../libstdc++-v3/include
-I../../libstdc++-v3/include/sparc-linux-gnu
-I../../../../src/libsanitizer/../libstdc++-v3/libsupc++ -g -O2 -D_GNU_SOURCE
-MT sanitizer_platform_limits_linux.lo -MD -MP -MF
.deps/sanitizer_platform_limits_linux.Tpo -c
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc
 -fPIC -DPIC -o .libs/sanitizer_platform_limits_linux.o
In file included from
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:40:0:
/usr/include/sparc-linux-gnu/asm/stat.h:60:2: error: 'time_t' does not name a
type
  time_t  st_atime;
  ^
/usr/include/sparc-linux-gnu/asm/stat.h:62:2: error: 'time_t' does not name a
type
  time_t  st_mtime;
  ^
/usr/include/sparc-linux-gnu/asm/stat.h:64:2: error: 'time_t' does not name a
type
  time_t  st_ctime;
  ^
In file included from
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:20:0:
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:66:16:
error: 'struct___old_kernel_stat_sz' was not declared in this scope
 COMPILER_CHECK(struct___old_kernel_stat_sz == sizeof(struct
__old_kernel_stat));
                ^
../../../../src/libsanitizer/sanitizer_common/sanitizer_internal_defs.h:257:65:
note: in definition of macro 'IMPL_COMPILER_ASSERT'
     typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int)(pred)-1]
                                                                 ^
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:66:1:
note: in expansion of macro 'COMPILER_CHECK'
 COMPILER_CHECK(struct___old_kernel_stat_sz == sizeof(struct
__old_kernel_stat));
 ^
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:66:78:
error: invalid application of 'sizeof' to incomplete type '__old_kernel_stat'
 COMPILER_CHECK(struct___old_kernel_stat_sz == sizeof(struct
__old_kernel_stat));
                                                                              ^
../../../../src/libsanitizer/sanitizer_common/sanitizer_internal_defs.h:257:65:
note: in definition of macro 'IMPL_COMPILER_ASSERT'
     typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int)(pred)-1]
                                                                 ^
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:66:1:
note: in expansion of macro 'COMPILER_CHECK'
 COMPILER_CHECK(struct___old_kernel_stat_sz == sizeof(struct
__old_kernel_stat));
 ^
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:69:16:
error: 'struct_kernel_stat_sz' was not declared in this scope
 COMPILER_CHECK(struct_kernel_stat_sz == sizeof(struct stat));
                ^
../../../../src/libsanitizer/sanitizer_common/sanitizer_internal_defs.h:257:65:
note: in definition of macro 'IMPL_COMPILER_ASSERT'
     typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int)(pred)-1]
                                                                 ^
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:69:1:
note: in expansion of macro 'COMPILER_CHECK'
 COMPILER_CHECK(struct_kernel_stat_sz == sizeof(struct stat));
 ^
make[6]: *** [sanitizer_platform_limits_linux.lo] Error 1
make[6]: *** Waiting for unfinished jobs....
libtool: compile:  /«PKGBUILDDIR»/build/./gcc/xgcc -shared-libgcc
-B/«PKGBUILDDIR»/build/./gcc -nostdinc++
-L/«PKGBUILDDIR»/build/sparc-linux-gnu/libstdc++-v3/src
-L/«PKGBUILDDIR»/build/sparc-linux-gnu/libstdc++-v3/src/.libs
-L/«PKGBUILDDIR»/build/sparc-linux-gnu/libstdc++-v3/libsupc++/.libs
-B/usr/sparc-linux-gnu/bin/ -B/usr/sparc-linux-gnu/lib/ -isystem
/usr/sparc-linux-gnu/include -isystem /usr/sparc-linux-gnu/sys-include -isystem
/«PKGBUILDDIR»/build/sys-include -D_GNU_SOURCE -D_DEBUG
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I.
-I../../../../src/libsanitizer/sanitizer_common -I
../../../../src/libsanitizer/include -Wall -W -Wno-unused-parameter
-Wwrite-strings -pedantic -Wno-long-long -fPIC -fno-builtin -fno-exceptions
-fno-rtti -fomit-frame-pointer -funwind-tables -fvisibility=hidden
-Wno-variadic-macros -I../../libstdc++-v3/include
-I../../libstdc++-v3/include/sparc-linux-gnu
-I../../../../src/libsanitizer/../libstdc++-v3/libsupc++ -g -O2 -D_GNU_SOURCE
-MT sanitizer_linux.lo -MD -MP -MF .deps/sanitizer_linux.Tpo -c
../../../../src/libsanitizer/sanitizer_common/sanitizer_linux.cc -o
sanitizer_linux.o >/dev/null 2>&1
mv -f .deps/sanitizer_linux.Tpo .deps/sanitizer_linux.Plo
make[6]: Leaving directory
`/«PKGBUILDDIR»/build/sparc-linux-gnu/libsanitizer/sanitizer_common'
make[5]: *** [all-recursive] Error 1
make[5]: Leaving directory `/«PKGBUILDDIR»/build/sparc-linux-gnu/libsanitizer'
make[4]: *** [all-stage1-target-libsanitizer] Error 2
make[4]: Leaving directory `/«PKGBUILDDIR»/build'
make[3]: *** [stage1-bubble] Error 2
make[3]: Leaving directory `/«PKGBUILDDIR»/build'
make[2]: *** [bootstrap] Error 2
>From gcc-bugs-return-439960-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jan 10 14:30:58 2014
Return-Path: <gcc-bugs-return-439960-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 2964 invoked by alias); 10 Jan 2014 14:30:58 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 2589 invoked by uid 55); 10 Jan 2014 14:30:54 -0000
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/59698] The type of NULL is described elsewhere
Date: Fri, 10 Jan 2014 14:30:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords: documentation
X-Bugzilla-Severity: trivial
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: redi at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59698-4-PVRQUc91uj@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59698-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59698-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-01/txt/msg01102.txt.bz2
Content-length: 747

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY698

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Fri Jan 10 14:30:21 2014
New Revision: 206524

URL: http://gcc.gnu.org/viewcvs?rev 6524&root=gcc&view=rev
Log:
    PR libstdc++/59698
    * doc/xml/manual/status_cxx1998.xml (iso.1998.specific): Markup
    and stylistic improvements.
    * doc/xml/manual/codecvt.xml (std.localization.facet.codecvt): Likewise
    and update for C++11.
    * doc/xml/manual/ctype.xml (std.localization.facet.ctype): Likewise.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/doc/xml/manual/codecvt.xml
    trunk/libstdc++-v3/doc/xml/manual/ctype.xml
    trunk/libstdc++-v3/doc/xml/manual/status_cxx1998.xml

[Bug sanitizer/59758] [4.9 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.0

[Bug sanitizer/59758] [4.9 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |davem at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Someone who can reproduce it (not me any longer, my SPARC boxes are dead) needs
to debug this and write a patch, or drop SPARC from libsanitizer list of
supported targets.

[Bug sanitizer/59758] [4.9 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4

[Bug sanitizer/59758] [4.9 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[jose.marchesi at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

--- Comment #2 from Jose E. Marchesi <jose.marchesi at oracle dot com> ---
I can reproduce this problem in sparc64-*-linux-gnu.  Looks like there
are many missing definitions for stub structs in
sanitizer_platform_limits_posix.h for sparc.  Working on this.. after
I get it building I will run some tests and post a patch.

[Bug sanitizer/59758] [4.9 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[jose.marchesi at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

Jose E. Marchesi <jose.marchesi at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jose.marchesi at oracle dot com

--- Comment #3 from Jose E. Marchesi <jose.marchesi at oracle dot com> ---
Created attachment 32165
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32165&action=edit
fix sanitizer build on sparc

Patch attached.  Sent to gcc-patches as well.
Build tested on sparc64-*-linux-gnu with linux 3.8.13 headers.

[Bug sanitizer/59758] [4.9 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-02-18
                 CC|                            |ebotcazou at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #4 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Confirmed by Jose.

[Bug sanitizer/59758] [4.9/4.10 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[aaro.koskinen at iki dot fi]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

Aaro Koskinen <aaro.koskinen at iki dot fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aaro.koskinen at iki dot fi

--- Comment #5 from Aaro Koskinen <aaro.koskinen at iki dot fi> ---
The bug is still present in gcc-4.9.0-RC-20140411.

[Bug sanitizer/59758] [4.9/4.10 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.0                       |4.9.1

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.0 has been released

[Bug sanitizer/59758] [4.9/4.10 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[davem at davemloft dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

David S. Miller <davem at davemloft dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |davem at davemloft dot net

--- Comment #8 from David S. Miller <davem at davemloft dot net> ---
That's because struct_kernel_stat_sz should be 64, not 120.

[Bug sanitizer/59758] [4.9/4.10 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[davem at davemloft dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

--- Comment #9 from David S. Miller <davem at davemloft dot net> ---
The next problem you'll run into is that the shmid additions for sparc weren't
done correctly in the patch.  Where you see 's64', it should be 'long', and
where you see 'u64' it should be 'unsigned long'.

I strongly suspect the patch was only build tested on 64-bit, as all of the
mistakes in the patch are for 32-bit cases.

[Bug sanitizer/59758] [4.9/4.10 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[davem at davemloft dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

--- Comment #10 from David S. Miller <davem at davemloft dot net> ---
Created attachment 32723
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=32723&action=edit
Fix for libsanitizer build on sparc

This adjusted patch fixes the build for me.

[Bug sanitizer/59758] [4.9/4.10 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.1                       |4.9.2

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.1 has been released.

[Bug sanitizer/59758] [4.9/5 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[rth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

Richard Henderson <rth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rth at gcc dot gnu.org

--- Comment #12 from Richard Henderson <rth at gcc dot gnu.org> ---
(In reply to David S. Miller from comment #10)
> Created attachment 32723 [details]
> Fix for libsanitizer build on sparc
> 
> This adjusted patch fixes the build for me.

Looks good to me.

Given the lack of attention the sanitizers are getting, perhaps
you should just check this in.  Especially to the branch.

[Bug sanitizer/59758] [4.9/5 Regression] bootstrap failure in libsanitizer/asan on sparc-linux-gnu

[davem at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59758

davem at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from davem at gcc dot gnu.org ---
Fixed in 4.9 branch and the trunk.