public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jvdelisle at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libfortran/59764] Read logicals, line buffer, item_count, and error message consistancy
Date: Fri, 10 Jan 2014 22:31:00 -0000	[thread overview]
Message-ID: <bug-59764-4-LmrSDzSLnK@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-59764-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59764

--- Comment #3 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
I have a patch successfully regression tested.

Basically, I have change in io.h as follows.  The component expanded_read is
just a flag and does not need to an integer, so I have used an available bit
above it for this and and then used the integer slot for line_buffer_pos.

This integer is then used in those places where needed for the look-ahead
buffer.  I will submit a patch for approval as soon as I get coordinated with
Steves patch for pr59700. 

Index: io.h
===================================================================
--- io.h    (revision 206351)
+++ io.h    (working copy)
@@ -430,7 +430,10 @@
       unsigned g0_no_blanks : 1;
       /* Used to signal use of free_format_data.  */
       unsigned format_not_saved : 1;
-      /* 14 unused bits.  */
+      /* A flag used to identify when a non-standard expanded namelist read
+         has occurred.  */
+      unsigned expanded_read : 1;
+      /* 13 unused bits.  */

       /* Used for ungetc() style functionality. Possible values
          are an unsigned char, EOF, or EOF - 1 used to mark the
@@ -447,9 +450,8 @@
       char *line_buffer;
       struct format_data *fmt;
       namelist_info *ionml;
-      /* A flag used to identify when a non-standard expanded namelist read
-         has occurred.  */
-      int expanded_read;
+      /* Current position within the look-ahead line buffer.  */
+      int line_buffer_pos;
       /* Storage area for values except for strings.  Must be
          large enough to hold a complex value (two reals) of the
          largest kind.  */


  parent reply	other threads:[~2014-01-10 22:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-59764-4@http.gcc.gnu.org/bugzilla/>
2014-01-10 19:20 ` jvdelisle at gcc dot gnu.org
2014-01-10 22:26 ` dominiq at lps dot ens.fr
2014-01-10 22:31 ` jvdelisle at gcc dot gnu.org [this message]
2014-01-11 18:57 ` jvdelisle at gcc dot gnu.org
2014-02-21 23:57 ` jvdelisle at gcc dot gnu.org
2014-02-22  2:12 ` jvdelisle at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-59764-4-LmrSDzSLnK@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).