[Bug fortran/59765] New: ICE on valid with allocatable component and type extension

[Bug fortran/59765] New: ICE on valid with allocatable component and type extension

[abensonca at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

            Bug ID: 59765
           Summary: ICE on valid with allocatable component and type
                    extension
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: abensonca at gmail dot com

The following causes an ICE with gfortran 4.9.0 r206484, but compiles
successfully with r205975:

module mtds
  type umd
     integer, dimension(:), allocatable :: c
  end type umd
  type mtd
     type(umd), dimension(1) :: u
  end type mtd
contains
  subroutine add(s)
    class(mtd), intent(inout) :: s
  end subroutine add
end module mtds


$ gfortran -v
Using built-in specs.
COLLECT_GCC=gfortran
COLLECT_LTO_WRAPPER=/nfs/04/osu7985/Galacticus/Tools/libexec/gcc/x86_64-unknown-linux-gnu/4.9.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ../trunk/configure --prefix=/nfs/04/osu7985/Galacticus/Tools
--enable-languages=c++,c,fortran --disable-multilib
Thread model: posix
gcc version 4.9.0 20140109 (experimental) (GCC) 

$ gfortran -c tmp1.F90 -o tmp1.o 
tmp1.F90: In function ‘__final_mtds_Mtd’:
tmp1.F90:10:0: internal compiler error: in gfc_conv_descriptor_data_get, at
fortran/trans-array.c:145
     class(mtd), intent(inout) :: s
 ^
0x65cd8d gfc_conv_descriptor_data_get(tree_node*)
        ../../trunk/gcc/fortran/trans-array.c:145
0x66454f gfc_array_deallocate(tree_node*, tree_node*, tree_node*, tree_node*,
tree_node*, gfc_expr*)
        ../../trunk/gcc/fortran/trans-array.c:5335
0x6bedfd gfc_trans_deallocate(gfc_code*)
        ../../trunk/gcc/fortran/trans-stmt.c:5421
0x658c27 trans_code
        ../../trunk/gcc/fortran/trans.c:1782
0x6bc344 gfc_trans_simple_do
        ../../trunk/gcc/fortran/trans-stmt.c:1427
0x6bc344 gfc_trans_do(gfc_code*, tree_node*)
        ../../trunk/gcc/fortran/trans-stmt.c:1590
0x658cea trans_code
        ../../trunk/gcc/fortran/trans.c:1732
0x6827be gfc_generate_function_code(gfc_namespace*)
        ../../trunk/gcc/fortran/trans-decl.c:5605
0x65a6c1 gfc_generate_module_code(gfc_namespace*)
        ../../trunk/gcc/fortran/trans.c:1956
0x61689d translate_all_program_units
        ../../trunk/gcc/fortran/parse.c:4523
0x61689d gfc_parse_file()
        ../../trunk/gcc/fortran/parse.c:4733
0x654815 gfc_be_parse_file
        ../../trunk/gcc/fortran/f95-lang.c:188
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.


The ICE goes away if I do any of the following:

* Change "class(mtd)" to "type(mtd)"

* Make the "u" component of "mtd" allocatable, or make it a scalar

* Make the "c" component of "umd" non-allocatable
>From gcc-bugs-return-440035-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jan 10 20:18:23 2014
Return-Path: <gcc-bugs-return-440035-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 22542 invoked by alias); 10 Jan 2014 20:18:22 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 22504 invoked by uid 48); 10 Jan 2014 20:18:18 -0000
From: "trippels at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/59626] [4.9 lto] /usr/include/bits/unistd.h:173:1: error: inlining failed in call to always_inline 'readlinkat': recursive inlining
Date: Fri, 10 Jan 2014 20:18:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: lto
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: trippels at gcc dot gnu.org
X-Bugzilla-Status: WAITING
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59626-4-K3wN9gHwbz@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59626-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59626-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-01/txt/msg01177.txt.bz2
Content-length: 362

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY626

--- Comment #3 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
(In reply to Aldy Hernandez from comment #2)
>
> Do you think the error is incorrect, or do you think the same error should
> appear for -std=gnu99?


I think that erroring out is a bit drastic.
Or do you think this is a bug in glibc?

[Bug fortran/59765] [4.9 Regression] [OOP] ICE on valid with allocatable component

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-01-10
                 CC|                            |janus at gcc dot gnu.org
            Summary|ICE on valid with           |[4.9 Regression] [OOP] ICE
                   |allocatable component and   |on valid with allocatable
                   |type extension              |component
     Ever confirmed|0                           |1

--- Comment #1 from janus at gcc dot gnu.org ---
Confirmed. Slightly reduced test case:

  type umd
      integer, allocatable :: c(:)
  end type
  type mtd
      type(umd) :: u(1)
  end type
  class(mtd), allocatable :: s
end


I'm pretty sure this is my fault. I'd bet for r206379.

[Bug fortran/59765] [4.9 Regression] [OOP] ICE on valid with allocatable component

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> I'm pretty sure this is my fault. I'd bet for r206379.

r206362 is OK, r206444 is not.

[Bug fortran/59765] [4.9 Regression] [OOP] ICE on valid with allocatable component

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

--- Comment #3 from janus at gcc dot gnu.org ---
(In reply to Dominique d'Humieres from comment #2)
> > I'm pretty sure this is my fault. I'd bet for r206379.
> 
> r206362 is OK, r206444 is not.

... and indeed reverting r206379 makes the ICE go away. However I don't think
there is anything wrong with that revision. It probably just exposed a lower
lying problem.

[Bug fortran/59765] [4.9 Regression] [OOP] ICE on valid with allocatable component

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

--- Comment #4 from janus at gcc dot gnu.org ---
I think what happens is something like the following:

generate_finalization_wrapper currently produces code like this on the test
case:

type(mtd), pointer :: ptr
deallocate(ptr%u(:)%c)

This is certainly wrong. Feeding it back to gfortran yields:

  deallocate(ptr%u%c)
             1
Error: Component to the right of a part reference with nonzero rank must not
have the ALLOCATABLE attribute at (1)


For the test case here it is sufficient to just use

deallocate(ptr%u(1)%c)

but for longer arrays we need to generate a loop:

do i=...
  deallocate(ptr%u(i)%c)
end do

[Bug fortran/59765] [4.9 Regression] [OOP] ICE on valid with allocatable component

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

--- Comment #5 from janus at gcc dot gnu.org ---
In particular this code in finalize_component produces a full-array reference
for array components:

  if (comp->attr.dimension || comp->attr.codimension
      || (comp->ts.type == BT_CLASS && CLASS_DATA (comp)
      && (CLASS_DATA (comp)->attr.dimension
          || CLASS_DATA (comp)->attr.codimension)))
    {
      ref->next = gfc_get_ref ();
      ref->next->type = REF_ARRAY;
      ref->next->u.ar.dimen = 0;
      ref->next->u.ar.as = comp->ts.type == BT_CLASS ? CLASS_DATA (comp)->as
                            : comp->as;
      e->rank = ref->next->u.ar.as->rank;
      ref->next->u.ar.type = e->rank ? AR_FULL : AR_ELEMENT;
    }


Either we have to scalarize this later on (this is currently not implemented,
because this is forbidden in actual Fortran code, see comment 4), or we have to
generate a loop directly instead of the full-array expression.

[Bug fortran/59765] [4.9 Regression] [OOP] ICE on valid with finalizable array components

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.0

[Bug fortran/59765] [4.9 Regression] [OOP] ICE on valid with finalizable array components

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4

[Bug fortran/59765] [4.9/4.10 Regression] [OOP] ICE on valid with finalizable array components

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.0                       |4.9.1

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.0 has been released

[Bug fortran/59765] [4.9/4.10 Regression] [OOP] ICE on valid with finalizable array components

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.1                       |4.9.2

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.1 has been released.

[Bug fortran/59765] [4.9/4.10 Regression] [OOP] ICE on valid with finalizable array components

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carlos.a.cruz at nasa dot gov

--- Comment #8 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
*** Bug 60529 has been marked as a duplicate of this bug. ***

[Bug fortran/59765] [4.9/4.10 Regression] [OOP] ICE on valid with finalizable array components

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |juergen.reuter at desy dot de

--- Comment #9 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
*** Bug 61766 has been marked as a duplicate of this bug. ***

[Bug fortran/59765] [4.9/4.10 Regression] [OOP] ICE on valid with finalizable array components

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sfilippone at uniroma2 dot it

--- Comment #10 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
*** Bug 61819 has been marked as a duplicate of this bug. ***

[Bug fortran/59765] [4.9/5 Regression] [OOP] ICE on valid with finalizable array components

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.2                       |4.9.3

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.2 has been released.

[Bug fortran/59765] [4.9/5 Regression] [OOP] ICE on valid with finalizable array components

[a.vogt at fulguritus dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

Alexander Vogt <a.vogt at fulguritus dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.vogt at fulguritus dot com

--- Comment #12 from Alexander Vogt <a.vogt at fulguritus dot com> ---
Is there any update on this? This regression currently prohibits moving to
4.9.x for my code :(

Thanks a lot!

[Bug fortran/59765] [4.9/5 Regression] [OOP] ICE on valid with finalizable array components

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikael at gcc dot gnu.org

--- Comment #14 from Mikael Morin <mikael at gcc dot gnu.org> ---
(In reply to janus from comment #5)
> Either we have to scalarize this later on (this is currently not
> implemented, because this is forbidden in actual Fortran code, see comment
> 4), or we have to generate a loop directly instead of the full-array
> expression.

For what it's worth, class.c's finalizer_insert_packed call generates a
scalarization loop "by hand"; maybe part of it can be reused.

[Bug fortran/59765] [4.9/5 Regression] [OOP] ICE on valid with finalizable array components

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pault at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |pault at gcc dot gnu.org

--- Comment #15 from Paul Thomas <pault at gcc dot gnu.org> ---
This is one and the same as PR64932 for which I have just posted a fix. Thanks
to Dominique for noticing this.

Since it is a regression, I will be posting to 4.9 and 5.0.

Cheers


Paul

[Bug fortran/59765] [4.9/5 Regression] [OOP] ICE on valid with finalizable array components

[alipasha.celeris at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

--- Comment #16 from Alipasha <alipasha.celeris at gmail dot com> ---
(In reply to Paul Thomas from comment #15)
> This is one and the same as PR64932 for which I have just posted a fix.
> Thanks to Dominique for noticing this.
> 
> Since it is a regression, I will be posting to 4.9 and 5.0.
> 
> Cheers
> 
> 
> Paul

Is this fix committed to the trunk? I just updated to 

GNU Fortran (GCC) 5.0.0 20150210 (experimental)

and still get the ICE with the test case:

in gfc_conv_descriptor_data_get, at fortran/trans-array.c:157
...

Thank you for looking into this :)

[Bug fortran/59765] [4.9/5 Regression] [OOP] ICE on valid with finalizable array components

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

--- Comment #18 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
I think this PR is now fixed by r220654 for trunk (5.0) and r220659 (4.9).

[Bug fortran/59765] [4.9/5 Regression] [OOP] ICE on valid with finalizable array components

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59765

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #19 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> I think this PR is now fixed by r220654 for trunk (5.0) and r220659 (4.9).

Closing as FIXED.