[Bug c++/59766] New: c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[Bug c++/59766] New: c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[mizvekov at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

            Bug ID: 59766
           Summary: c++1y: declaring friend function with 'auto' return
                    type deduction is rejected with bogus reason
           Product: gcc
           Version: 4.8.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: mizvekov at gmail dot com

Simple example showing the problem:

struct foo {
    friend auto test(const foo &) { return 0; }
};

g++ rejects this with:

test.cc:2:30: error: non-static data member declared ‘auto’
  friend auto test(const foo &) { return 0; }
>From gcc-bugs-return-440067-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Jan 11 00:01:17 2014
Return-Path: <gcc-bugs-return-440067-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 27608 invoked by alias); 11 Jan 2014 00:01:17 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 27586 invoked by uid 48); 11 Jan 2014 00:01:14 -0000
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/47888] [4.6 Regression] tree check: expected array_type, have record_type in array_ref_low_bound, at expr.c:6249 / Segmentation fault
Date: Sat, 11 Jan 2014 00:01:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: lto
X-Bugzilla-Version: 4.6.0
X-Bugzilla-Keywords: ice-on-invalid-code, lto
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mpolacek at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.7.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-47888-4-7c71fKxsr4@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-47888-4@http.gcc.gnu.org/bugzilla/>
References: <bug-47888-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-01/txt/msg01209.txt.bz2
Content-length: 471

http://gcc.gnu.org/bugzilla/show_bug.cgi?idG888

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpolacek at gcc dot gnu.org

--- Comment #11 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
We don't support 4.6 anymore so if this is only 4.6 thing, we can't do much
about it.

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[lucdanton at free dot fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

--- Comment #1 from lucdanton at free dot fr ---
Happens too with GCC 4.9 (20140105), as well as when using decltype(auto).

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adam at jessamine dot co.uk

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Maybe Adam can have a look.

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at gcc dot gnu.org

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Sorry.

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[felix at fontein dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

--- Comment #4 from Felix Fontein <felix at fontein dot de> ---
I can confirm this bug for GCC 4.9.0 20140604 (prerelease).

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rejects-valid
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-12-05
     Ever confirmed|0                           |1

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[potswa at mac dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

--- Comment #5 from David Krauss <potswa at mac dot com> ---
Created attachment 34538
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34538&action=edit
ChangeLog entry

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[potswa at mac dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

--- Comment #6 from David Krauss <potswa at mac dot com> ---
Created attachment 34541
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34541&action=edit
Fix: disable the error for friend declarators.

The fix is simple. Tested and submitted for approval. (I am a registered
contributor.)

I don't suppose this warrants a testcase file. If you want to exercise the
compiler, here is a more interesting case:


template< typename k >
struct t {
    friend auto leak( t );

    template< typename v >
    struct m {
        friend auto leak( t ) { return v{}; }
    };
};

int main() {
    t< int >::m< char > a;
    decltype( leak( t< int >{} ) ) b;
    static_assert ( sizeof b == 1, "" );

    t< int >::m< short > c; // error: redefinition of ‘auto leak(t<int>)’
}
>From gcc-bugs-return-474504-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jan 23 09:49:11 2015
Return-Path: <gcc-bugs-return-474504-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 31184 invoked by alias); 23 Jan 2015 09:49:06 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 31019 invoked by uid 55); 23 Jan 2015 09:48:53 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/64511] [5 Regression] ICE at -O3 with -g enabled on x86_64-linux-gnu
Date: Fri, 23 Jan 2015 09:49:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: debug
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: compile-time-hog, memory-hog
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64511-4-BrzDIEByEF@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64511-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64511-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg02498.txt.bz2
Content-length: 410

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd511

--- Comment #18 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Fri Jan 23 09:47:51 2015
New Revision: 220031

URL: https://gcc.gnu.org/viewcvs?rev"0031&root=gcc&view=rev
Log:
    PR debug/64511
    * dwarf2out.c (struct dw_loc_descr_node): Add chain_next
    GTY markup.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/dwarf2out.h

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[glisse at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

--- Comment #8 from Marc Glisse <glisse at gcc dot gnu.org> ---
(In reply to David Krauss from comment #6)
> The fix is simple. Tested and submitted for approval.

Thank you. Did you send it to gcc-patches, with jason AT redhat in Cc: ? I
can't find any email from you around that date.

https://gcc.gnu.org/contribute.html

> I don't suppose this warrants a testcase file.

Why not? It is the only way to make sure a later refactoring of the code won't
regress on this.

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[potswa at mac dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

--- Comment #9 from David Krauss <potswa at mac dot com> ---
I didn't send it to gcc-patches. It's never been necessary for me before. I
suppose I can collect the examples here into a testcase file. In the meantime,
anyone else is free to take charge and submit it on their own. The change is
just a matter of "don't do that."

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

--- Comment #10 from Jason Merrill <jason at gcc dot gnu.org> ---
(In reply to David Krauss from comment #9)
> I didn't send it to gcc-patches. It's never been necessary for me before.

I appreciate getting direct mail about C++ patches so that I see them faster; I
didn't notice this one until today.  Also feel free to ping me if I haven't
responded after a week.

I'll check this in after GCC 5 branches.

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

--- Comment #11 from Jason Merrill <jason at gcc dot gnu.org> ---
Author: jason
Date: Tue Apr 14 15:29:27 2015
New Revision: 222095

URL: https://gcc.gnu.org/viewcvs?rev=222095&root=gcc&view=rev
Log:
    PR c++/59766
    * decl.c (grokdeclarator): Do not flag friends with deduced return.

Added:
    trunk/gcc/testsuite/g++.dg/cpp1y/auto-fn26.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/decl.c

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

--- Comment #12 from Jason Merrill <jason at gcc dot gnu.org> ---
Author: jason
Date: Wed Apr 22 20:52:52 2015
New Revision: 222337

URL: https://gcc.gnu.org/viewcvs?rev=222337&root=gcc&view=rev
Log:
    PR c++/59766
    * decl.c (grokdeclarator): Do not flag friends with deduced return.

Added:
    branches/gcc-5-branch/gcc/testsuite/g++.dg/cpp1y/auto-fn26.C
Modified:
    branches/gcc-5-branch/gcc/cp/ChangeLog
    branches/gcc-5-branch/gcc/cp/decl.c

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |5.2

--- Comment #13 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed for 5.2/6.

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

--- Comment #14 from Jason Merrill <jason at gcc dot gnu.org> ---
Author: jason
Date: Thu Apr 23 13:21:06 2015
New Revision: 222365

URL: https://gcc.gnu.org/viewcvs?rev=222365&root=gcc&view=rev
Log:
    PR c++/59766
    * decl.c (grokdeclarator): Do not flag friends with deduced return.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/g++.dg/cpp1y/auto-fn26.C
Modified:
    branches/gcc-4_9-branch/gcc/cp/ChangeLog
    branches/gcc-4_9-branch/gcc/cp/decl.c

[Bug c++/59766] c++1y: declaring friend function with 'auto' return type deduction is rejected with bogus reason

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59766

--- Comment #15 from Jason Merrill <jason at gcc dot gnu.org> ---
And 4.9.3.