* [Bug ipa/59831] ice in cgraph_speculative_call_info with -O3
2014-01-15 16:55 [Bug c/59831] New: ice in cgraph_speculative_call_info with -O3 dcb314 at hotmail dot com
@ 2014-01-15 20:20 ` trippels at gcc dot gnu.org
2014-01-16 14:26 ` [Bug ipa/59831] [4.9 Regression] " rguenth at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: trippels at gcc dot gnu.org @ 2014-01-15 20:20 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59831
Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2014-01-15
CC| |hubicka at gcc dot gnu.org,
| |trippels at gcc dot gnu.org
Component|c |ipa
Target Milestone|--- |4.9.0
Ever confirmed|0 |1
--- Comment #1 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Confirmed.
markus@x4 /tmp % cat test.ii
class A {};
class B {
public:
A &operator[](int);
};
class C : B {
public:
virtual int m_fn1() { return 0; }
A &operator[](int p1) {
int a;
a = m_fn1();
static_cast<void>(__builtin_expect(a, 0) ?: 0);
return B::operator[](p1);
}
};
C b;
int *e;
static void sort(C &p1, C &p2) {
for (int i=0;; i++) {
A c, d = p2[0];
p1[0] = c;
p2[0] = d;
}
}
void lookupSourceDone() { b[0]; }
void update_sources() {
if (e) {
C f;
sort(f, b);
}
}
markus@x4 /tmp % g++ -c -O3 test.ii
test.ii: In function ‘A& C::operator[].constprop()’:
test.ii:9:6: internal compiler error: in cgraph_speculative_call_info, at
cgraph.c:1197
A &operator[](int p1) {
^
Please submit a full bug report,
>From gcc-bugs-return-440480-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Jan 15 20:37:51 2014
Return-Path: <gcc-bugs-return-440480-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 16043 invoked by alias); 15 Jan 2014 20:37:51 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 15957 invoked by uid 48); 15 Jan 2014 20:37:47 -0000
From: "jason at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/59659] large zero-initialized std::array compile time excessive
Date: Wed, 15 Jan 2014 20:37:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords: compile-time-hog, memory-hog, missed-optimization
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jason at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jason at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution target_milestone
Message-ID: <bug-59659-4-NzzGzUWT7A@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59659-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59659-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-01/txt/msg01622.txt.bz2
Content-length: 485
http://gcc.gnu.org/bugzilla/show_bug.cgi?idY659
Jason Merrill <jason at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |4.9.0
--- Comment #10 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed for 4.9.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug ipa/59831] [4.9 Regression] ice in cgraph_speculative_call_info with -O3
2014-01-15 16:55 [Bug c/59831] New: ice in cgraph_speculative_call_info with -O3 dcb314 at hotmail dot com
2014-01-15 20:20 ` [Bug ipa/59831] " trippels at gcc dot gnu.org
@ 2014-01-16 14:26 ` rguenth at gcc dot gnu.org
2014-01-16 18:28 ` hubicka at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-01-16 14:26 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59831
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug ipa/59831] [4.9 Regression] ice in cgraph_speculative_call_info with -O3
2014-01-15 16:55 [Bug c/59831] New: ice in cgraph_speculative_call_info with -O3 dcb314 at hotmail dot com
2014-01-15 20:20 ` [Bug ipa/59831] " trippels at gcc dot gnu.org
2014-01-16 14:26 ` [Bug ipa/59831] [4.9 Regression] " rguenth at gcc dot gnu.org
@ 2014-01-16 18:28 ` hubicka at gcc dot gnu.org
2014-01-16 20:00 ` hubicka at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: hubicka at gcc dot gnu.org @ 2014-01-16 18:28 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59831
Jan Hubicka <hubicka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |hubicka at gcc dot gnu.org
--- Comment #2 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Here inliner turns virtual call to direct call while versioning. This
devirtualization is missed by ipa-cp, but anticipated by ipa-devirt's
speculative code. The ICE happens since inliner is done with copying edges but
not with references while it attempts to resolve the indirect call.
I am looking into fix.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug ipa/59831] [4.9 Regression] ice in cgraph_speculative_call_info with -O3
2014-01-15 16:55 [Bug c/59831] New: ice in cgraph_speculative_call_info with -O3 dcb314 at hotmail dot com
` (2 preceding siblings ...)
2014-01-16 18:28 ` hubicka at gcc dot gnu.org
@ 2014-01-16 20:00 ` hubicka at gcc dot gnu.org
2014-01-30 23:37 ` hubicka at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: hubicka at gcc dot gnu.org @ 2014-01-16 20:00 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59831
--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Easy fix is the following:
Index: cgraph.c
===================================================================
--- cgraph.c (revision 206617)
+++ cgraph.c (working copy)
@@ -815,6 +815,7 @@ cgraph_set_call_stmt (struct cgraph_edge
e->call_stmt = new_stmt;
if (e->indirect_unknown_callee
+ && !e->speculative
&& (decl = gimple_call_fndecl (new_stmt)))
{
/* Constant propagation (and possibly also inlining?) can turn an
I am however not entirely happy about it. The devirtualization happens while
saving function body for inlining, so it is obviously a missed optimization
here: I assume that we never fold the call pre-IPA.
Also we should resolve speculation here, for that we however need to copy the
associated references...
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug ipa/59831] [4.9 Regression] ice in cgraph_speculative_call_info with -O3
2014-01-15 16:55 [Bug c/59831] New: ice in cgraph_speculative_call_info with -O3 dcb314 at hotmail dot com
` (3 preceding siblings ...)
2014-01-16 20:00 ` hubicka at gcc dot gnu.org
@ 2014-01-30 23:37 ` hubicka at gcc dot gnu.org
2014-02-03 20:42 ` hubicka at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: hubicka at gcc dot gnu.org @ 2014-01-30 23:37 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59831
--- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Created attachment 31996
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=31996&action=edit
Proposed fix
OK, here we have
A& C::operator[](int) (struct C * const this, int p1)
{
int (*__vtbl_ptr_type) () * _3;
int (*__vtbl_ptr_type) () _4;
struct A & _8;
<bb 2>:
_3 = this_2(D)->_vptr.C;
_4 = *_3;
OBJ_TYPE_REF(_4;(struct C)this_2(D)->0) (this_2(D));
_8 = B::operator[] (this_2(D), p1_6(D));
return _8;
}
that is devirtualizable in the context of:
void sort(C&, C&) (struct C & p1, struct C & p2)
{
<bb 2>:
<bb 3>:
C::operator[] (p2_3(D), 0);
C::operator[] (p1_5(D), 0);
C::operator[] (p2_3(D), 0);
<bb 4>:
goto <bb 3>;
}
used exclusively from:
void sort(C&, C&) (struct C & p1, struct C & p2)
{
<bb 2>:
<bb 3>:
C::operator[] (p2_3(D), 0);
C::operator[] (p1_5(D), 0);
C::operator[] (p2_3(D), 0);
<bb 4>:
goto <bb 3>;
}
ipa-cp does:
Evaluating opportunities for void sort(C&, C&)/10.
- Creating a specialized node of void sort(C&, C&)/10 for all known contexts.
replacing param #1 p2 with const &b
Accounting size:2.00, time:0.00 on new predicate:(not inlined)
the new node is void sort.constprop(C&)/30.
Aggregate replacements: 0[0]=&MEM[(void *)&_ZTV1C + 16B]
Evaluating opportunities for void sort(C&, C&)/10.
Marking node as dead: void sort(C&, C&)/10.
Evaluating opportunities for A& C::operator[](int)/1.
- considering value &b for param #0 this (caller_count: 3)
good_cloning_opportunity_p (time: 1, size: 17, freq_sum: 201000) ->
evaluation: 11823, threshold: 500
Creating a specialized node of A& C::operator[](int)/1.
adding an extra known scalar value 0 for param #1 p1
replacing param #0 this with const &b
replacing param #1 p1 with const 0
Accounting size:1.00, time:1.00 on predicate:(true)
Accounting size:3.00, time:2.00 on new predicate:(not inlined)
Accounting size:0.50, time:0.50 on new predicate:(op0[ref
offset: 0] changed) && (not inlined)
Accounting size:0.50, time:0.50 on new predicate:(op0[ref
offset: 0] changed)
the new node is A& C::operator[].constprop()/31.
Evaluating opportunities for A& C::operator[](int)/1.
Evaluating opportunities for virtual int C::m_fn1()/0.
- considering value &b for param #0 this (caller_count: 1)
good_cloning_opportunity_p (time: 2, size: 3, freq_sum: 800) ->
evaluation: 533, threshold: 500
Creating a specialized node of virtual int C::m_fn1()/0.
replacing param #0 this with const &b
Accounting size:3.00, time:2.00 on new predicate:(not inlined)
the new node is int C::m_fn1.constprop()/32.
Evaluating opportunities for virtual int C::m_fn1()/0.
For some reason it gets right the aggregate value, but misses the
devirtualization.
devirtualization_time_bonus properly anticipates the devirtualization to
happen.
The problem is that later we replace BINFO by a constant. This is going throug
gimple_extract_binfo_from_cst that is known to be buggy.
This patch removes it and uses equivalent functionality of ipa-devirt.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug ipa/59831] [4.9 Regression] ice in cgraph_speculative_call_info with -O3
2014-01-15 16:55 [Bug c/59831] New: ice in cgraph_speculative_call_info with -O3 dcb314 at hotmail dot com
` (4 preceding siblings ...)
2014-01-30 23:37 ` hubicka at gcc dot gnu.org
@ 2014-02-03 20:42 ` hubicka at gcc dot gnu.org
2014-02-04 5:53 ` hubicka at gcc dot gnu.org
2014-02-04 5:54 ` hubicka at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: hubicka at gcc dot gnu.org @ 2014-02-03 20:42 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59831
--- Comment #5 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Author: hubicka
Date: Mon Feb 3 20:41:30 2014
New Revision: 207439
URL: http://gcc.gnu.org/viewcvs?rev=207439&root=gcc&view=rev
Log:
PR ipa/59831
* g++.dg/ipa/devirt-24.C: New testcase.
* ipa-cp.c (ipa_get_indirect_edge_target_1): Give up on -fno-devirtualize;
Try to devirtualize by the knowledge of virtual table pointer given by
aggregate propagation.
* ipa-prop.c (try_make_edge_direct_virtual_call): Likewise.
ipa_print_node_jump_functions): Dump also offset that
is relevant for polymorphic calls.
(determine_known_aggregate_parts): Add arg_type parameter; use it
instead of determining the type from pointer type.
(ipa_compute_jump_functions_for_edge): Update call of
determine_known_aggregate_parts.
* gimple-fold.c (gimple_get_virt_method_for_vtable): Break out from ...
(gimple_get_virt_method_for_binfo): ... here; simplify using
vtable_pointer_value_to_vtable.
* gimple-fold.h (gimple_get_virt_method_for_vtable): Declare.
* ipa-devirt.c (subbinfo_with_vtable_at_offset): Turn OFFSET parameter
to unsigned HOST_WIDE_INT; Use vtable_pointer_value_to_vtable.
(vtable_pointer_value_to_vtable): Break out from ...; handle also
POINTER_PLUS_EXPR.
(vtable_pointer_value_to_binfo): ... here.
* ipa-utils.h (vtable_pointer_value_to_vtable): Declare.
Added:
trunk/gcc/testsuite/g++.dg/ipa/devirt-24.C
Modified:
trunk/gcc/ChangeLog
trunk/gcc/gimple-fold.c
trunk/gcc/gimple-fold.h
trunk/gcc/ipa-cp.c
trunk/gcc/ipa-devirt.c
trunk/gcc/ipa-prop.c
trunk/gcc/ipa-utils.h
trunk/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug ipa/59831] [4.9 Regression] ice in cgraph_speculative_call_info with -O3
2014-01-15 16:55 [Bug c/59831] New: ice in cgraph_speculative_call_info with -O3 dcb314 at hotmail dot com
` (5 preceding siblings ...)
2014-02-03 20:42 ` hubicka at gcc dot gnu.org
@ 2014-02-04 5:53 ` hubicka at gcc dot gnu.org
2014-02-04 5:54 ` hubicka at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: hubicka at gcc dot gnu.org @ 2014-02-04 5:53 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59831
--- Comment #6 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Hopefully fixed now.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug ipa/59831] [4.9 Regression] ice in cgraph_speculative_call_info with -O3
2014-01-15 16:55 [Bug c/59831] New: ice in cgraph_speculative_call_info with -O3 dcb314 at hotmail dot com
` (6 preceding siblings ...)
2014-02-04 5:53 ` hubicka at gcc dot gnu.org
@ 2014-02-04 5:54 ` hubicka at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: hubicka at gcc dot gnu.org @ 2014-02-04 5:54 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59831
Jan Hubicka <hubicka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
I meant to change the status ;)
^ permalink raw reply [flat|nested] 9+ messages in thread